Skip to content

🎨 Palette: Add keyboard instructions and accessible score to Mario game #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EiJackGH wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🎨 Palette: Add keyboard instructions and accessible score to Mario game #160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .Jules/palette.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,11 @@
## 2025-03-23 - Game Key Scrolling
**Learning:** Browsers natively scroll the page when users press Space or Arrow keys. When building a web-based game, this creates a frustrating UX where the game viewport jumps around while playing.
**Action:** Always call `e.preventDefault()` on keydown events for typical game controls ("Space", "ArrowUp", etc.) when the focus is on a game container or the body.

## 2025-05-18 - Missing Screen Reader Feedback on Dynamic Scores
**Learning:** For dynamic real-time values like game scores that update frequently without page reloads, screen reader users miss out on crucial context if live regions are not used. Adding `aria-live` is critical.
**Action:** Always include `aria-live="polite"` and `aria-atomic="true"` on scoreboards, progress indicators, or dynamic text containers in custom UI or web games to ensure announcements are properly queued and read out.

## 2025-05-18 - "Invisible" Controls in Custom Game UIs
**Learning:** Creating custom keyboard event listeners in web interfaces (like space to jump) is often totally undiscoverable to users without explicit onboarding text.
**Action:** Whenever binding custom navigation or game actions to keydown events, verify that instructional helper text is visibly rendered in the UI context so users know what inputs are expected.
1 change: 0 additions & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
numpy
pandas
requests
venv
15 changes: 14 additions & 1 deletion src/views/mario-game.njk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,13 +52,26 @@
font-size: 20px;
font-family: Arial;
}

#instructions {
position: absolute;
top: 10px;
right: 10px;
color: rgba(255, 255, 255, 0.8);
font-size: 16px;
font-family: Arial, sans-serif;
background: rgba(0, 0, 0, 0.3);
padding: 5px 10px;
border-radius: 5px;
}
</style>
</head>

<body>

<div id="game">
<div id="score">Score: 0</div>
<div id="score" aria-live="polite" aria-atomic="true">Score: 0</div>
<div id="instructions" aria-hidden="true">Press <b>Space</b> or <b>Up Arrow</b> to jump</div>
<div id="mario"></div>
<div class="ground"></div>
</div>
Expand Down
Loading