Review updates - #210

Merged

jgriffiths merged 205 commits into

Jul 26, 2020

Commits on Jul 5, 2020

Commits on Jul 16, 2020

ec_sig_from_bytes: Prevent uninitialised read
jgriffiths
committed
ec_sig_from_bytes: Simplify parameter checking logic
jgriffiths
committed
psbt: In wally_combine_psbts, don't leak result if merge_unknowns_into fails
jgriffiths
committed
add WALLY_DISABLE_OP_CODE guard

k-matsuzawa
authored and
jgriffiths
committed
psbt: return ENOMEM for any wally_malloc failures

niftynei
authored and
jgriffiths
committed
psbt: Initial simplification of wally_psbt_init_alloc
jgriffiths
committed
psbt: Remove unneded saves/restores of num_items members
jgriffiths
committed
psbt: Don't set allocation len if allocation fails
jgriffiths
committed
psbt: Doc fixes
jgriffiths
committed
docs: wally_crypto doc fixes
jgriffiths
committed
psbt: Add missing output checks
jgriffiths
committed
psbt: constify wally_extract_psbt input and fix docs
jgriffiths
committed
psbt: Add missing checks to and simplify extract_psbt
jgriffiths
committed
psbt: Fix input and output leaks, clear data when freeing
jgriffiths
committed
travis: don't explicitly list what tests in tools/travis_build.sh

rustyrussell
authored and
jgriffiths
committed
psbt: add a simple test case, by copying some of BIP 0174.

rustyrussell
authored and
jgriffiths
committed
psbt: close some leaks.

rustyrussell
authored and
jgriffiths
committed
psbt: improve constness.

rustyrussell
authored and
jgriffiths
committed
pullpush: add routines for safe marshal / unmarshal.

rustyrussell
authored and
jgriffiths
committed
psbt: use push functions for converting input to bytes.

rustyrussell
authored and
jgriffiths
committed
psbt: make output_to_bytes use push.

rustyrussell
authored and
jgriffiths
committed
wally_psbt: make wally_psbt_to_bytes use push itself.

rustyrussell
authored and
jgriffiths
committed
psbt: make psbt_input_get_length use the same code as psbt_input_to_bytes.

rustyrussell
authored and
jgriffiths
committed
psbt: use pull_ functions to parse input section.

rustyrussell
authored and
jgriffiths
committed
psbt: use pull_ functions to parse output section.

rustyrussell
authored and
jgriffiths
committed
psbt: convert count_psbt_parts to use pull_ code.

rustyrussell
authored and
jgriffiths
committed
psbt: convert wally_psbt_from_bytes to use pull_code.

rustyrussell
authored and
jgriffiths
committed
psbt: add test for marshal/unmarshal limits.

rustyrussell
authored and
jgriffiths
committed
psbt: add limit testing to unmarshalling as well.

rustyrussell
authored and
jgriffiths
committed
psbt: Delete redundant struct wally_key_origin_info
jgriffiths
committed
transaction: Declare vars up front
jgriffiths
committed
docs: Add missing docs to cleanup.sh
jgriffiths
committed
transaction: Expose wally_tx_get_txid
jgriffiths
committed
psbt: Remove unneeded casts
jgriffiths
committed
docs: Update coverage report instructions
jgriffiths
committed
elements: Remove redundant parameter checks
jgriffiths
committed
symmetric: Add tests
jgriffiths
committed
symmetric: Remove SYMMETRIC_KEY_LEN from the public interface
jgriffiths
committed
transaction: Allow serialisation of partial transactions
jgriffiths
committed
elements: Remove redundant vars and simplify code
jgriffiths
committed
psbt: Allow partial transactions
jgriffiths
committed
psbt: Avoid magic numbers
jgriffiths
committed
Check that pointers are non-null rather than length is non-zero

achow101
authored and
jgriffiths
committed
Implement psbt global version type

achow101
authored and
jgriffiths
committed
Add wally_psbt_elements_input_init_alloc and elements fields setters

achow101
authored and
jgriffiths
committed
psbt: Avoid bool type in public interface
jgriffiths
committed
Add wally_psbt_elements_output_init_alloc and field setters

achow101
authored and
jgriffiths
committed
Have the PSBT store it's magic to distinguish between psbt and pset

achow101
authored and
jgriffiths
committed
psbt: Don't pass arrays by value in the public interface
jgriffiths
committed
Implement Elements psbt de/serialization as a proprietary type

achow101
authored and
jgriffiths
committed
psbt: Pass in correct flags for elements tx parsing
jgriffiths
committed
.gitignore: ignore ctags

niftynei
authored and
jgriffiths
committed
pset: use correct serialization for witness_utxo

niftynei
authored and
jgriffiths
committed
pset: Don't leak witness_utxo elements
jgriffiths
committed
pset: fixup key parsing for prefix + subtype

niftynei
authored and
jgriffiths
committed
pset: fixup serialization of proprietary elements keys

niftynei
authored and
jgriffiths
committed
pset: include length of amount in value for WALLY_PSBT_IN_ELEMENTS_VALUEs

niftynei
authored and
jgriffiths
committed
pset: add canonical pset example from elementsd

niftynei
authored and
jgriffiths
committed
configure: wouldn't compile MAP_ANON on Ubuntu 20.04 LTS

niftynei
authored and
jgriffiths
committed
transaction: expose wally_tx_output_clone

niftynei
authored and
jgriffiths
committed
psbt: clone passed in tx_output, makes us pset compatible

niftynei
authored and
jgriffiths
committed
psbt: Always allow identification of elements psets
jgriffiths
committed
psbt: Update docs
jgriffiths
committed
gitignore: Ignore swp files
jgriffiths
committed

Commits on Jul 22, 2020

Commits on Jul 23, 2020