-
Notifications
You must be signed in to change notification settings - Fork 156
Review updates #210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Review updates #210
Changes from all commits
Commits
Show all changes
205 commits
Select commit
Hold shift + click to select a range
79d8fad
Use WALLY_TXHASH_LEN for tx hash lengths.
jgriffiths fabb45b
transaction: Use GET_TX_B_FIXED instead of mostly duplicated GET_TX_A…
jgriffiths 995245d
Java: Add missing tx_input_get_txhash wrapper
jgriffiths 67c9132
bech32: Prevent witness version wrap-around bypassing allowed range c…
jgriffiths bbb17be
blech32: Add witness version check as per bech32
jgriffiths eebe38a
blech32: Formatting consistency nits
jgriffiths 1ddc85a
pytest: Don't use built-in function 'input' as a variable name
jgriffiths 897768f
pytest: Remove hashlib use from test_sign.py
jgriffiths dffd215
Docs: received -> receive
jgriffiths 3ebb7d9
docs: Add symmetric docs with minor fixes
jgriffiths d8bacc3
symmetric: Add java wrappers + test, pass given len
jgriffiths 01c690f
wally_asset_blinding_key_from_seed: remove redundant goto
jgriffiths 4574c82
wally_asset_blinding_key_to_ec_private_key: simplify logic
jgriffiths 9ae32e9
docs: Fix function refs in Liquid developer guide
jgriffiths aebd386
docs: Fix sphinx warning
jgriffiths 3a1f622
elements: Remove redundant goto's
jgriffiths 4280519
tests: Actually check pubkey recovery results
jgriffiths 5d7f840
docs: Fix sphinx warning
jgriffiths 91b84a0
ecdh: Use priv_key for param name, fix docs, expose nicely to Java
jgriffiths fe605a6
elements: Use wally for hashing in get_nonce_hash()
jgriffiths 1003309
SWIG: Add missing nonce_hash to Java bindings
jgriffiths a281961
SWIG: Silence JS wrapper build warnings
jgriffiths d2c5d2c
tests: Remove hashbangs from python tests
jgriffiths 73cdf0a
address.c: Remove unused includes
jgriffiths 2203ec3
wally_bip32_key_to_addr_segwit: Clear witness program before returning
jgriffiths 118cc76
SWIG: Java wrapper and test for ec_public_key_negate()
jgriffiths 333edf1
Compare return codes to WALLY_OK for consistency
jgriffiths 52cdf7c
pegin_contract_script_from_bytes: Don't use 'written' as a general va…
jgriffiths e312d47
address_to_scriptpubkey: Use common variable name for consistency
jgriffiths 5af7358
scriptpubkey_to_address: Don't ignore base58 errors
jgriffiths ec215ea
clone_tx: Simplify, constify, ensure input is valid
jgriffiths e4c4ae9
clone_tx: expose as wally_tx_clone, add tests
jgriffiths 89ee3a3
key_strip_private_key: Use single impl, expose to Java and C++
jgriffiths 80c49bd
CHANGES: Remove non-API changes from CHANGES.md
jgriffiths 9c7e48e
witness_p2wpkh_from_x: Simplify
jgriffiths 576235a
SWIG: Expose wally_address_to_scriptpubkey to Java
jgriffiths cd85f67
tests: Move scriptpubkey tests to cffi and de-duplicate
jgriffiths 437e6c9
psbt: Move FINGERPRINT_LEN to wally_bip32.h where it belongs
jgriffiths fc33a40
bip32: rename FINGERPRINT_LEN to BIP32_KEY_FINGERPRINT_LEN
jgriffiths f24fe1a
bip32: Expose key_get_fingerprint to Java and C++
jgriffiths 49b6095
scriptpubkey_to_address: Expose to C++
jgriffiths 619d7c4
SWIG: Fix psbt_get_length to allow python bindings to work
jgriffiths 6c69970
ec_sig_from_bytes: Prevent uninitialised read
jgriffiths 6cd87b5
ec_sig_from_bytes: Simplify parameter checking logic
jgriffiths b41fe01
psbt: In wally_combine_psbts, don't leak result if merge_unknowns_int…
jgriffiths dfe7cd6
add WALLY_DISABLE_OP_CODE guard
k-matsuzawa deb4873
psbt: return ENOMEM for any wally_malloc failures
niftynei 63cf542
psbt: Initial simplification of wally_psbt_init_alloc
jgriffiths bef7403
psbt: Remove unneded saves/restores of num_items members
jgriffiths 2a1e487
psbt: Don't set allocation len if allocation fails
jgriffiths 612802d
psbt: Doc fixes
jgriffiths 7c84ed1
docs: wally_crypto doc fixes
jgriffiths df1bb25
psbt: Add missing output checks
jgriffiths 4504a4a
psbt: constify wally_extract_psbt input and fix docs
jgriffiths 7ff892e
psbt: Add missing checks to and simplify extract_psbt
jgriffiths 336e56d
psbt: Fix input and output leaks, clear data when freeing
jgriffiths 0b3cdf4
travis: don't explicitly list what tests in tools/travis_build.sh
rustyrussell cd6af40
psbt: add a simple test case, by copying some of BIP 0174.
rustyrussell d638793
psbt: close some leaks.
rustyrussell b12804e
psbt: improve constness.
rustyrussell 7f2b5e9
pullpush: add routines for safe marshal / unmarshal.
rustyrussell a23aba6
psbt: use push functions for converting input to bytes.
rustyrussell 8aa08b0
psbt: make output_to_bytes use push.
rustyrussell 274de27
wally_psbt: make wally_psbt_to_bytes use push itself.
rustyrussell 372b70b
psbt: make psbt_input_get_length use the same code as psbt_input_to_b…
rustyrussell 87293c6
psbt: use pull_ functions to parse input section.
rustyrussell 6c055c1
psbt: use pull_ functions to parse output section.
rustyrussell 155c6eb
psbt: convert count_psbt_parts to use pull_ code.
rustyrussell c3a424f
psbt: convert wally_psbt_from_bytes to use pull_code.
rustyrussell 3430c11
psbt: add test for marshal/unmarshal limits.
rustyrussell cd24ad8
psbt: add limit testing to unmarshalling as well.
rustyrussell 666877c
psbt: Delete redundant struct wally_key_origin_info
jgriffiths c142302
transaction: Declare vars up front
jgriffiths ead83de
docs: Add missing docs to cleanup.sh
jgriffiths 009516a
transaction: Expose wally_tx_get_txid
jgriffiths 05802b7
psbt: Remove unneeded casts
jgriffiths 0f8e932
docs: Update coverage report instructions
jgriffiths b9c731d
elements: Remove redundant parameter checks
jgriffiths d550c93
symmetric: Add tests
jgriffiths c0352cb
symmetric: Remove SYMMETRIC_KEY_LEN from the public interface
jgriffiths 0031609
transaction: Allow serialisation of partial transactions
jgriffiths ac78bdc
elements: Remove redundant vars and simplify code
jgriffiths d92caca
psbt: Allow partial transactions
jgriffiths 076ccc6
psbt: Avoid magic numbers
jgriffiths b5cde6e
Check that pointers are non-null rather than length is non-zero
achow101 7b6ac5c
Implement psbt global version type
achow101 2860e25
Add wally_psbt_elements_input_init_alloc and elements fields setters
achow101 edf37aa
psbt: Avoid bool type in public interface
jgriffiths 34982cb
Add wally_psbt_elements_output_init_alloc and field setters
achow101 c69504a
Have the PSBT store it's magic to distinguish between psbt and pset
achow101 b9914e5
psbt: Don't pass arrays by value in the public interface
jgriffiths 0cae125
Implement Elements psbt de/serialization as a proprietary type
achow101 05a55d2
psbt: Pass in correct flags for elements tx parsing
jgriffiths 2f3aa8c
.gitignore: ignore ctags
niftynei 8351fb6
pset: use correct serialization for witness_utxo
niftynei b40274c
pset: Don't leak witness_utxo elements
jgriffiths 5337ca3
pset: fixup key parsing for prefix + subtype
niftynei 8c04554
pset: fixup serialization of proprietary elements keys
niftynei 8c4e6fc
pset: include length of amount in value for WALLY_PSBT_IN_ELEMENTS_VA…
niftynei beb5ac5
pset: add canonical pset example from elementsd
niftynei 158a0f7
configure: wouldn't compile MAP_ANON on Ubuntu 20.04 LTS
niftynei d04bc33
transaction: expose wally_tx_output_clone
niftynei 21f2c1f
psbt: clone passed in tx_output, makes us pset compatible
niftynei e9e095f
psbt: Always allow identification of elements psets
jgriffiths 5b83e31
psbt: Update docs
jgriffiths c182992
gitignore: Ignore swp files
jgriffiths 161e5cc
psbt: Move test data file to the common data file location
jgriffiths f1fa4b6
readme: add easier to skim notes for running the tests + formatter
niftynei 376f232
psbt: Replace asserts with error returns
jgriffiths acdc40c
tests: enable non swig elements tests even when swig not enabled
niftynei b6e2920
psbt: Avoid magic numbers
jgriffiths e46ea79
transaction: Generalise replace_script to replace_bytes
jgriffiths 3d3ab8e
psbt: Add helpers to simplify pubkey length checks
jgriffiths abcf7d4
psbt: Use replace_bytes to implement elements outputs setters
jgriffiths fdff995
tests: Use wally_free_string to free wally allocated string
jgriffiths dd35068
psbt: Fix leak in clone_unknowns_map
jgriffiths 8ed09e5
psbt: share code to set the unknown map member in inputs and outputs
jgriffiths 5b835cf
psbt: remove redundant checks before clear_and_free
jgriffiths bdd087b
psbt: Use replace_bytes to implement elements inputs setters
jgriffiths 6bd19a8
psbt: merge replace_unknowns with clone_unknowns_map
jgriffiths a722cbd
psbt: Share keypath setting code like the updated unknowns code
jgriffiths 33d2807
psbt: Don't leak peg_in_tx when setting it on inputs
jgriffiths 2f42da2
psbt: Share partial sigs setting code like the updated unknowns code
jgriffiths 679c876
psbt: psbt_input_set_final_witness: Add checks, allow NULL witness
jgriffiths 5ce62dd
psbt: psbt_input_set_non_witness_utxo: Add input check
jgriffiths 422f452
psbt: Share code to grow array members
jgriffiths f8f9310
psbt: add_new_keypath: Check parameters, clear on failure
jgriffiths 8950a6a
psbt: add_new_partial_sig: Check parameters, clear on failure, fix co…
jgriffiths 4991ee1
psbt: add_new_unknown: Check parameters, don't leak on failure
jgriffiths 12ba10e
psbt: Rename some psbt functions to follow library standards
jgriffiths 1375e09
psbt: final input/output review updates
jgriffiths d59b4a9
psbt: Only copy magic if psbt allocation succeeds
jgriffiths dfd5097
internal: Implement an internal calloc to simplify code
jgriffiths 1d615a6
psbt: set_global_tx: Don't leak inputs if output allocation fails
jgriffiths 7d8ac1b
psbt: Remove redundant pre-iteration of data when deserializing
jgriffiths 14ec80b
psbt: optimise to avoid cloning the parsed global tx
jgriffiths 842e0f2
psbt: psbt_to_bytes: Follow the library convention for too short buffers
jgriffiths a5e7f47
docs: Add docs for return codes and variable output buffers
jgriffiths 854df83
psbt: Standardise param name in order to correct doc generation
jgriffiths 423d9d6
psbt: fix warnings building without elements support
jgriffiths 7a7916f
Java: use consistent method prologues
jgriffiths e383d75
psbt: Clear decoded base64 data after unserialising
jgriffiths f1f70d9
psbt: Clean up test, use wally for hex conversion
jgriffiths 78409c7
psbt: constify psbt function parameters
jgriffiths 44fee6c
psbt: Don't use C++ stdlib types for parameter names
jgriffiths 5f1b62b
psbt: Use the same parameter names as other calls for consistency
jgriffiths bbcc4f8
psbt: Expose functions to C++
jgriffiths ef20e84
psbt: Add flags to serialisation calls for future use
jgriffiths f7303ef
pset: quick hack to create elements tx hash for signing
jgriffiths 55ca566
psbt: Add find functions for psbt map types
jgriffiths ae83283
psbt: ignore duplicate keys when adding to maps
jgriffiths 49b7027
psbt: Use find to prevent dupes when reading, add unknowns check
jgriffiths 4933da1
psbt: Use find to check for existing input signature when signing
jgriffiths 339a970
psbt: Use find to match keypaths when signing
jgriffiths 5f71525
psbt: Change psbt_combine to just combine two psbts together.
jgriffiths f538834
psbt: Remove duplicated code around merging unknown maps
jgriffiths c52d034
psbt: Remove duplicated code around merging keypath maps
jgriffiths de0b08e
psbt: Add pubkeys with the correct length
jgriffiths 58f381c
psbt: simplify push_psbt_key_with_pubkey
jgriffiths cbd800b
psbt: Add elements support for psbt_combine, clean up
jgriffiths 1527796
psbt: Allow clearing value and struct members of psbt inputs/outputs
jgriffiths 5b723ca
Revert "elements: don't fail silently if the buffer is too small"
jgriffiths fe3ac1d
elements: Document elements_pegout_script_from_bytes change
jgriffiths 2a26b05
elements: asset_pak_whitelistproof: Update and use correct return sem…
jgriffiths da87f5c
Add security issue reporting information
jgriffiths e109ac3
elements: make wally_is_elements_build take a size_t output
jgriffiths e372dc7
docs: Document asset_unblind_with_nonce
jgriffiths 22abab9
python: Add a script to auto-generate the CFFI function list
jgriffiths 57eddc5
python: Update the CFFI test wrapper
jgriffiths 92bfd30
script: Fix multisig limit for scriptpubkeys/scriptsigs to 15, update…
jgriffiths 213ef33
psbt: check script length as well as script when deserialising
jgriffiths fcbfc65
fix: mnemonic_w memory leak. and wordlist init/free memory leak.
k-matsuzawa d922969
pullpush: Address review nit
jgriffiths d8461a1
c++: Update wally.hpp with missing/incorrect functions
jgriffiths 2cc28c1
script: Update function layout to match others
jgriffiths 0325ab9
pullpush: remove unused LE16 functions
jgriffiths a37ef06
tests: Remove internal header from elements C test
jgriffiths 2d9b761
psbt: create empty inputs and outputs when setting the global tx
jgriffiths cab172e
transaction: Don't expose analyse_tx now that psbt doesnt need it
jgriffiths 5c9d805
transaction: Make clear_and_free available and use it internally
jgriffiths af29018
transaction: Expose tx_witness_stack_clone
jgriffiths d10846b
general: Use wally_calloc in more places to simplify code
jgriffiths e1aa193
psbt: Initial SWIG python wrapper implementation
jgriffiths c9ac89e
psbt: Add combining to psbt ctest for valgrind checking
jgriffiths 942c009
psbt: remove unused pull_psbt_key_start function
jgriffiths 1abd2a0
tests: fix clang warning
jgriffiths 71ffd97
psbt: Windows build fixes
jgriffiths 384947f
psbt: Add non-elements swig setters, with tests
jgriffiths 204419a
symmetric: Add missing symmetric header to install list
jgriffiths 467165b
psbt: Remove input and output allocation and free functions
jgriffiths ee4f030
psbt: Don't expose psbt input/output direct setters to SWIG
jgriffiths d1ebc72
psbt: push pubkey keys directly
jgriffiths c1ea199
psbt: Add a FIXME for adding validation to getters/setters
jgriffiths d74863e
psbt: Take the version in psbt_init_alloc for future compatibility
jgriffiths 36ed6c8
psbt: use BIP32_KEY_FINGERPRINT_LEN per review
jgriffiths b9b1897
psbt: rename elements input/output getters/setters
jgriffiths 1b61666
psbt: Update CHANGES.md to a simpler message for the next release
jgriffiths 6a9b309
transaction: update docs for allowed value lengths
jgriffiths 87e45e0
elements: use the correct constant for blinding factor lengths
jgriffiths 24e4db9
psbt: Expose output setters to python, with tests
jgriffiths d20c66b
psbt: Simplify input/output pull logic
jgriffiths 846a4d8
psbt: cleanup code for and validate field lengths when reading in psbts
jgriffiths f6ef719
psbt: Expose input setters to python, with tests
jgriffiths b396b85
psbt: Allow the caller to control sig grinding when signing
jgriffiths c9c45b6
psbt: Don't normalise signatures after signing
jgriffiths File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.