This repository was archived by the owner on Jul 17, 2024. It is now read-only.
🔥 Hotfix 🔥, Optimization, and Adjustment#1
Merged
Conversation
Readme.md Mit License Now every 25 combo cool get 1 jam Life now start with 100 More wiggle on Combo Number Combo Logo wiggle divided by 2 from Combo Number wiggle
AlberttFrgk
changed the title
Shorter Timer Draw stats by 50%
Combo Logo wiggle divided by 2 from Combo Number
Combo Logo wiggle divided by 2.5 from Combo Number
Owner
|
Mind you update the README.md again? at line Header where the forked title thingy need to be removed first. |
Improve accuracy frame limiter (idk if dev want uncap fps later) Merge all option ofn.lpstrFilter into one
Improve accuracy frame limiter reduce shuttering (idk if dev want uncap fps later) Merge all option ofn.lpstrFilter into one
AlberttFrgk
commented
May 3, 2023
|
|
||
| for (auto& it : textures) { | ||
| m_textures.push_back(new Texture2D(it)); | ||
| m_textures.emplace_back(new Texture2D(it)); |
Contributor
Author
There was a problem hiding this comment.
If you're loading a texture in your code, it's better to use 'emplace_back' instead of 'push_back' if you're not loading a string or a file. 'Push_back' should only be used if you want to load files like BMS, OJN, or OSU.
AlberttFrgk
changed the title
Estrol
approved these changes
May 5, 2023
|
|
||
| for (auto& it : textures) { | ||
| m_textures.push_back(new Texture2D(it)); | ||
| m_textures.emplace_back(new Texture2D(it)); |
Owner
There was a problem hiding this comment.
Any difference performance on this changes?
Owner
|
Looks good, Thank you :) |
Estrol
added a commit
that referenced
this pull request
Sep 6, 2023
Estrol
added a commit
that referenced
this pull request
Sep 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new icon
Now every 25 combo cool get 1 jam
Life now start with 100
̶M̶o̶r̶e̶ ̶w̶i̶g̶g̶l̶e̶ ̶o̶n̶ ̶C̶o̶m̶b̶o̶ ̶N̶u̶m̶b̶e̶r̶ (reworked animation)
Combo Logo wiggle divided by 2.5 from Combo Number wiggle (Still same)
🔥Fixed Combo and LongCombo animation affect by Framerate🔥