This repository was archived by the owner on Jul 17, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
🔥 Hotfix 🔥, Optimization, and Adjustment #1
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
9286763
Optimization, Adjustment, and Add icon
AlberttFrgk 900d5fa
Small Animation Changes
AlberttFrgk b0c8618
Update README.md
AlberttFrgk f7de1ac
Small Animation Changes (again)
AlberttFrgk 7636313
Small Animation Changes (again)
AlberttFrgk 86b22e1
Merge branch 'master' of https://github.com/AlberttFrgk/O2Game
AlberttFrgk f84ac79
Readme.md
AlberttFrgk 7233b5c
Improvement
AlberttFrgk 47d8fda
Improvement
AlberttFrgk d2394af
HOT Fix
AlberttFrgk 480188c
Merge branch 'master' of https://github.com/AlberttFrgk/O2Game
AlberttFrgk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,7 +18,7 @@ Sprite2D::Sprite2D(std::vector<std::string> textures, float delay) { | |
| AnchorPoint = { 0, 0 }; | ||
|
|
||
| for (auto& it : textures) { | ||
| m_textures.push_back(new Texture2D(it)); | ||
| m_textures.emplace_back(new Texture2D(it)); | ||
| } | ||
| } | ||
|
|
||
|
|
@@ -29,7 +29,7 @@ Sprite2D::Sprite2D(std::vector<std::filesystem::path> textures, float delay) { | |
| AnchorPoint = { 0, 0 }; | ||
|
|
||
| for (auto& it : textures) { | ||
| m_textures.push_back(new Texture2D(it)); | ||
| m_textures.emplace_back(new Texture2D(it)); | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If you're loading a texture in your code, it's better to use 'emplace_back' instead of 'push_back' if you're not loading a string or a file. 'Push_back' should only be used if you want to load files like BMS, OJN, or OSU. |
||
| } | ||
| } | ||
|
|
||
|
|
@@ -40,7 +40,7 @@ Sprite2D::Sprite2D(std::vector<ID3D11ShaderResourceView*> textures, float delay) | |
| AnchorPoint = { 0, 0 }; | ||
|
|
||
| for (auto& it : textures) { | ||
| m_textures.push_back(new Texture2D(it)); | ||
| m_textures.emplace_back(new Texture2D(it)); | ||
| } | ||
| } | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| // Icon Resource Definition | ||
| #define MAIN_ICON 102 | ||
| MAIN_ICON ICON "Icon.ico" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any difference performance on this changes?