[HOLD for payment 2023-06-12] [$1000] Chat - @here doesn't appear among possible mentions if typing with capital H

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #19304

Action Performed:

1. Login to NewDot
2. open any chat
3. Click compose box
4. Type @here

Expected Result:

Mention @here should among option in popup

Actual Result:

Mention @here with capital H letter doesn't show @here in pop-ip however shows possible email with here.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: Yes

Reproducible in staging?: New feature

Reproducible in production?:

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://platform.applause.com/services/links/v1/external/3f8362fd42a7cdc15bc6cb926d81f64be40e12c6d830a879ec2850fc5c554876

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013ff515081d6b94bc
• Upwork Job ID: 1663649838954299392
• Last Price Increase: 2023-05-30

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Chat - @here doesn't appear among possible mentions if typing with capital H

What is the root cause of that problem?

App/src/pages/home/report/ReportActionCompose.js

Line 465 in 21fefdb

if (CONST.AUTO_COMPLETE_SUGGESTER.HERE_TEXT.includes(searchValue)) {

We don't convert search value to lowercase when checking if it is here mention

What changes do you think we should make in order to solve the problem?

We should convert the search value to lowercase before checking if it is here mention like this

 if (CONST.AUTO_COMPLETE_SUGGESTER.HERE_TEXT.includes(searchValue.toLowerCase())) {

Optional:
In here

App/src/pages/home/report/ReportActionCompose.js

Line 467 in 21fefdb

text: CONST.AUTO_COMPLETE_SUGGESTER.HERE_TEXT,

We also check if the search value begins with H (capitalize) we will add @here to the composer and if the search value begins with h (lowercase) we will push @here to the composer when the user selects it

What alternative solutions did you explore? (Optional)

[strepanier03]

@kbecciv - Can you please include screenshots or videos from your testing and recreation when reporting a bug please? This helps reduce testing time on our end and is a critical component to clearing up any confusion we run into when trying to recreate ourselves.

[strepanier03]

I'm on iOS/Mac/ Chrome and unable to @here with a lower or upper case H. @kbecciv do you find the same or do you get a mention option with the lower case only?

[kbecciv]

@strepanier03 I added the video here

But if you need extra reproduction video, please attached mine.

Recording.2869.mp4

[melvin-bot]

@strepanier03 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[strepanier03]

Thank you @kbecciv - my computer was acting super funny last week and I couldn't get @ here to work with lower or upper.

However, today I was able to recreate this with no problem on Mac/Chrome.