fix: remove extra space after mention insertion by allroundexperts · Pull Request #19304 · Expensify/App

allroundexperts · 2023-05-19T17:35:56Z

Details

This PR edits the mention / emoji insertion behaviour such that an extra space is added ONLY if there isn't any extra space present after the mention.

Fixed Issues

$ #18742
PROPOSAL: #18742 (comment)

Tests

Open ND and go to any chat.
Insert any mention / emoji and verify that a space appears after it.
Move the cursor before the space such that the suggestion list shows again.
Select the suggestion again.

Verify that no additional space is added.

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Open ND and go to any chat.
Insert any mention / emoji and verify that a space appears after it.
Move the cursor before the space such that the suggestion list shows again.
Select the suggestion again.

Verify that no additional space is added.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screen.Recording.2023-05-19.at.10.23.58.PM.mov

Mobile Web - Chrome

Screen.Recording.2023-05-19.at.10.25.12.PM.mov

Mobile Web - Safari

Screen.Recording.2023-05-19.at.10.27.00.PM.mov

Desktop

Screen.Recording.2023-05-19.at.10.24.23.PM.mov

iOS

Screen.Recording.2023-05-19.at.10.26.24.PM.mov

Android

Screen.Recording.2023-05-19.at.10.25.50.PM.mov

melvin-bot · 2023-05-19T17:36:01Z

@puneetlath @thesahindia One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

thesahindia · 2023-05-22T17:53:02Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-05-22.at.9.53.23.PM.mov

Mobile Web - Chrome

Screen.Recording.2023-05-22.at.10.54.42.PM.mov

Mobile Web - Safari

Screen.Recording.2023-05-22.at.11.11.12.PM.mov

Desktop

Screen.Recording.2023-05-22.at.9.59.54.PM.mov

iOS

Screen.Recording.2023-05-22.at.11.06.12.PM.mov

Android

Screen.Recording.2023-05-22.at.10.36.15.PM.mov

thesahindia

Looks good and works well!

cc: @puneetlath

puneetlath · 2023-05-22T17:59:22Z

-        this.updateComment(`${commentBeforeAtSign}${mentionCode} ${commentAfterAtSignWithMentionRemoved}`, true);
+        this.updateComment(
+            `${commentBeforeAtSign}${mentionCode} ${
+                commentAfterAtSignWithMentionRemoved.slice(0, 1) === ' ' ? commentAfterAtSignWithMentionRemoved.slice(1) : commentAfterAtSignWithMentionRemoved


Given that we're doing the exact same thing on both line 609 and 576, could we move this into some sort of helper function?

@puneetlath Abstracted this into a helper function.

puneetlath · 2023-05-23T02:53:25Z

    }

+    /**
+     * Trims first character of the string


Suggested change

* Trims first character of the string

* Trims first character of the string if it is a space

puneetlath · 2023-05-23T02:53:47Z

+     * @param {String} str
+     * @returns {String}
+     */
+    trimLeftOneCharacter(str) {


Suggested change

trimLeftOneCharacter(str) {

trimLeadingSpace(str) {

Nice name 💯

thesahindia

LGTM!

OSBotify · 2023-05-23T15:38:22Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-05-25T00:35:09Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 1.3.18-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-05-25T01:08:41Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 1.3.18-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

OSBotify · 2023-05-25T01:30:37Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 1.3.18-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-05-26T07:07:49Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.3.18-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix: remove extra space after mention insertion

52fb5cc

allroundexperts requested a review from a team as a code owner May 19, 2023 17:35

melvin-bot Bot requested review from puneetlath and thesahindia and removed request for a team May 19, 2023 17:35

allroundexperts mentioned this pull request May 19, 2023

[HOLD for payment 2023-06-02] [$1000] Mention auto-suggester adds extra spaces when same mention is selected #18742

Closed

fix: prettier errors

07ed4d6

thesahindia previously approved these changes May 22, 2023

View reviewed changes

puneetlath requested changes May 22, 2023

View reviewed changes

fix: add trim left util function

29b826f

allroundexperts dismissed thesahindia’s stale review via 29b826f May 22, 2023 20:14

puneetlath requested changes May 23, 2023

View reviewed changes

fix: rename the trimLeftOneCharacter function

870e36f

allroundexperts requested review from puneetlath and thesahindia May 23, 2023 07:44

thesahindia approved these changes May 23, 2023

View reviewed changes

puneetlath approved these changes May 23, 2023

View reviewed changes

puneetlath merged commit 468b2a1 into Expensify:main May 23, 2023

OSBotify mentioned this pull request May 25, 2023

Deploy Checklist: New Expensify 2023-05-25 #19565

Closed

53 tasks

This was referenced May 26, 2023

[HOLD for payment 2023-06-12] [$1000] Chat - @here doesn't appear among possible mentions if typing with capital H #19645

Closed

Chat - Extra space is missing on Android app and mWeb if selected from emojis picker #19648

Closed

	* Trims first character of the string
	* Trims first character of the string if it is a space

Conversation

allroundexperts commented May 19, 2023

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented May 19, 2023

Uh oh!

thesahindia commented May 22, 2023

Reviewer Checklist

Screenshots/Videos

Uh oh!

thesahindia left a comment

Choose a reason for hiding this comment

Uh oh!

puneetlath May 22, 2023

Choose a reason for hiding this comment

Uh oh!

allroundexperts May 22, 2023

Choose a reason for hiding this comment

Uh oh!

puneetlath May 23, 2023

Choose a reason for hiding this comment

Uh oh!

puneetlath May 23, 2023

Choose a reason for hiding this comment

Uh oh!

allroundexperts May 23, 2023

Choose a reason for hiding this comment

Uh oh!

thesahindia left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented May 23, 2023

Uh oh!

OSBotify commented May 25, 2023

Uh oh!

OSBotify commented May 25, 2023

Uh oh!

OSBotify commented May 25, 2023

Uh oh!

OSBotify commented May 26, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants