Android - Profile - "Save" button overlaps on the self select pronouns field

[isagoico]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Expected Result:

User able to type text in the field

Actual Result:

"Save" button overlaps with the field and the user is unable to scroll.

Action Performed:

1. Launch the app and login
2. Tap avatar > profile
3. Select "Self select" from the preferred pronouns
4. Tap self select your pronoun field

Workaround:

Unknown

Platform:

Where is this issue confirmed?

Web
iOS
Android ✔️
Desktop App
Mobile Web

Version Number: 1.0.8-0

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:
Video

Expensify/Expensify Issue URL:

[shawnborton]

I think this is expected behavior since the Save button is sticky to the bottom of the viewport.

[shawnborton]

However, I can see an argument that we should add some white background behind the Save button so that it properly covers the content behind it. As in, the little bit of background UI you see under the save button feels weird to me. cc @NikkiWines @michelle-thompson @Maftalion

[isagoico]

I think this issue https://github.com/Expensify/Expensify/issues/158769 has the same source as this one. Maybe this one will be fixed when @marcaaron PR for the other issue is merged.

[NikkiWines]

I don't know if we have different functionality re:sticky buttons for iOS vs Android, but on iOS the save button doesn't show when selecting the Self Select input field.

If we do want sticky buttons on Android then your suggestion of a white background makes sense to me 👍

[michelle-thompson]

We have sticky buttons that respond to keyboards on other screens, so we should probably keep the same behavior here. I'm in favor of adding a white background too.

[shawnborton]

cc @trjExpensify - I think we recently chatted about our button inconsistencies throughout the Settings pages.

[marcaaron]

I think this issue Expensify/Expensify#158769 has the same source as this one. Maybe this one will be fixed when @marcaaron PR for the other issue is merged.

I did think this as well @isagoico, but upon further inspection believe it's a different issue.

[MelvinBot]

Triggered auto assignment to @RachCHopkins (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[NikkiWines]

So do we have a consensus on what kind of button functionality we want? I see both sticky and non-sticky buttons on iOS at the moment, in addition to the variations we have between android and ios.

Non Sticky:

• Profile View
• Change Password View
• Payments View

Sticky:

• Chat textbox (not a button, but it is sticky)
• New Group page once you've selected a user but not before then
  • Side note that this is also kind of a unique example in that the button doesn't show in the view at all until someone has been selected. In other cases, we seem to disable the button but still show it.

[shawnborton]

It seems like the Change Password view and the Payments view are using a bottom sticky button.

For Sign Out, I wonder if a better approach is to use the same kind of navigational menu option that we use for the Profile options. It feels way less heavy and then we have one less outlier:

For the sticky buttons, I think I like having the button be shown as disabled at all times, and then enable it when the button can actually take an action. I think this will better communicate functionality and end up being more predictable for us.

[mallenexpensify]

@shawnborton @michelle-thompson @NikkiWines can one of y'all break down exactly what's needed so @RachCHopkins can upload the issue to Upwork? Thanks