Move Sign Out button into Settings menu#2678
Merged
Merged
Conversation
deetergp
approved these changes
May 4, 2021
deetergp
left a comment
deetergp
left a comment
Contributor
There was a problem hiding this comment.
Tests pass and code looks good to me.
23 tasks
Contributor
|
🚀 Deployed to staging in version: 1.0.36-1🚀
|
Contributor
|
🚀 Deployed to production in version: 1.0.39-5🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc: @shawnborton
Details
Removes the dedicated
Sign Outbutton and instead includesSign Outas an option in the Settings menu.Fixed Issues
Fixes #2149 (comment)
Tests
Settingsby clicking on your user avatarProfile,Preferences,Change Password, andPayments) take you to their respective settings subpages.Sign Outsigns you out.QA Steps
Testssteps.Tested On
Screenshots
Web
web-signout.mov
Mobile Web
mweb-signout.mov
Desktop
desktop-signout.mov
iOS
ios-signout.mov
Android
android-signout.mov
React State Error on Android on current main
Just a note that I'm also experiencing that same react error on main currently for both Android and iOS but here's a video on Android
Screen.Recording.2021-05-03.at.2.30.45.PM.mov