[Due for payment 2025-05-14] [$250] Web - Expensify Card - Expensify Card page reloads after closing bank account setup RHP

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.16-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Create a new workspace
3. Go to workspace settings > More features
4. Enable Expensify Card
5. Go to Expensify Card
6. Click Issue new card
7. Click Upgrade to USD if prompted
8. Click RHP back button or click outside the RHP

Expected Result:

Expensify Card page will not reload after closing bank account setup RHP. (The issue was previously fixed in this PR #48613
).

Actual Result:

Expensify Card page reloads after closing bank account setup RHP

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6776895_1742479857654.20250320_220846.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021903124259903434822
• Upwork Job ID: 1903124259903434822
• Last Price Increase: 2025-04-18
• Automatic offers:
• nyomanjyotisa | Contributor | 107008958

Issue Owner

Current Issue Owner: @maddylewis

[melvin-bot]

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nyomanjyotisa]

🚨 Edited by proposal-police: This proposal was edited at 2025-04-10 13:06:30 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expensify Card page reloads after closing bank account setup RHP

What is the root cause of that problem?

We use useFocusEffect for the fetchExpensifyCards which will execute the fetchExpensifyCards everytime it refocused

We remove the && !cardsList from the isLoading condition in this PR #56331

App/src/pages/workspace/expensifyCard/WorkspaceExpensifyCardPage.tsx

Line 40 in 1814bf4

const isLoading = !isOffline && (!cardSettings || cardSettings.isLoading);

So it make the isLoading true everytime cardFeeds.isLoading is true

What changes do you think we should make in order to solve the problem?

Update to useEffect to only execute the fetchExpensifyCards every rerender only, and make it consistent with WorkspaceCompanyCardPage

App/src/pages/workspace/expensifyCard/WorkspaceExpensifyCardPage.tsx

Line 43 in 248f253

useFocusEffect(fetchExpensifyCards);

    useEffect(() => {
        fetchExpensifyCards();
    }, [fetchExpensifyCards]);

-1-New-Expensify.mp4

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

We should add isEmptyObject(cardsList) to the isLoading condition like we did in Company Cards here

const isLoading = !isOffline && (!cardSettings || (cardSettings.isLoading && isEmptyObject(cardsList)));

This makes the behavior consistent both on Expensify Card & Company Cards. And we need this to prevent the spinner show everytime user opens the page

We should update to useEffect to make it consistent with WorkspaceCompanyCardPage

App/src/pages/workspace/expensifyCard/WorkspaceExpensifyCardPage.tsx

Line 43 in 248f253

useFocusEffect(fetchExpensifyCards);

    useEffect(() => {
        fetchExpensifyCards();
    }, [fetchExpensifyCards]);

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021903124259903434822

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rojiphil (External)

[huult]

🚨 Edited by proposal-police: This proposal was edited at 2025-03-27 15:09:05 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expensify Card page reloads after closing bank account setup RHP

What is the root cause of that problem?

When we close the RHP while cardsList is empty, cardSettings is also triggered to load by useFocusEffect, causing cardSettings.isLoading to become true, which results in the loading indicator appearing and leads to this issue.

App/src/pages/workspace/expensifyCard/WorkspaceExpensifyCardPage.tsx

Line 40 in 99f22dd

const isLoading = !isOffline && (!cardSettings || cardSettings.isLoading);

What changes do you think we should make in order to solve the problem?

To resolve this issue, we simply prevent calling openPolicyExpensifyCardsPage when cardsList is empty.

App/src/pages/workspace/expensifyCard/WorkspaceExpensifyCardPage.tsx

Lines 31 to 33 in 99f22dd

	const fetchExpensifyCards = useCallback(() => {
	openPolicyExpensifyCardsPage(policyID, workspaceAccountID);
	}, [policyID, workspaceAccountID]);

update to:

    const fetchExpensifyCards = useCallback(() => {
        if (isEmptyObject(cardsList)) {
            return;
        }
        openPolicyExpensifyCardsPage(policyID, workspaceAccountID);
    }, [cardsList, policyID, workspaceAccountID]);

Screen.Recording.2025-03-23.at.23.47.25.mov

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

"I don't think we need to fetch Expensify cards when the Connect bank account modal is closed, since nothing has changed. useFocusEffect(fetchExpensifyCards); is only triggered on navigation, I believe.

1. We check if the previous screen was a modal.

App/src/pages/workspace/expensifyCard/WorkspaceExpensifyCardPage.tsx

Line 30 in 99f22dd

add

    const [modal] = useOnyx(ONYXKEYS.MODAL);
    const modalWasVisibleRef = useRef(false);

    useEffect(() => {
        // Track if modal is or was recently visible
        if (!modal?.isVisible) {
            return;
        }

        modalWasVisibleRef.current = true;
    }, [modal?.isVisible]);

2. We should return early if the previous RPH was a closed modal.

App/src/pages/workspace/expensifyCard/WorkspaceExpensifyCardPage.tsx

Lines 31 to 33 in 99f22dd

	const fetchExpensifyCards = useCallback(() => {
	openPolicyExpensifyCardsPage(policyID, workspaceAccountID);
	}, [policyID, workspaceAccountID]);

update to

    const fetchExpensifyCards = useCallback(() => {
        if (modalWasVisibleRef.current) {
            modalWasVisibleRef.current = false; 
            return;
        }
        openPolicyExpensifyCardsPage(policyID, workspaceAccountID);
    }, [policyID, workspaceAccountID]);

[melvin-bot]

@rojiphil Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@rojiphil Huh... This is 4 days overdue. Who can take care of this?