Turn channel log member message into HTML by tienifr · Pull Request #32161 · Expensify/App

tienifr · 2023-11-29T06:40:50Z

Details

Turn channel log member message into HTML so that room name is shown as link when copy to clipboard.

Fixed Issues

$ #31568
PROPOSAL: #31568 (comment)

Tests

Invite a user to the room
Open #admin room of that workspace
Long press invite message >> Copy to clipboard
Paste then Send the message
Verify the mention in the message is shown correctly
Press the room name in the message
Verify user is directed to the room chat

Verify that no errors appear in the JS console

Offline tests

NA

QA Steps

Invite a user to the room
Open #admin room of that workspace
Long press invite message >> Copy to clipboard
Paste then Send the message
Verify the mention in the message is shown correctly
Press the room name in the message
Verify user is directed to the room chat

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2023-11-29.at.14.31.31-compressed.mov

Android: mWeb Chrome

Screen.Recording.2023-11-29.at.14.35.33-compressed.mov

iOS: Native

Screen.Recording.2023-11-29.at.14.25.47-compressed.mov

iOS: mWeb Safari

Screen.Recording.2023-11-29.at.14.27.53-compressed.mov

MacOS: Chrome / Safari

Screen.Recording.2023-11-29.at.13.57.27-compressed.mov

MacOS: Desktop

Screen.Recording.2023-11-29.at.14.05.37-compressed.mov

melvin-bot · 2023-11-29T06:47:29Z

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

tienifr · 2023-11-29T06:48:00Z

@shubham1206agra Before completing screenshots, I found out one issue that the mention would be displayed as @Hidden after copy-pasting:

Because the personal detail was not retrieved properly here:

App/src/libs/ReportUtils.ts

Lines 4150 to 4154 in 1234b0d

    
           const mentions = (reportAction?.originalMessage as ChangeLog)?.targetAccountIDs?.map(() => { 
        
               const personalDetail = allPersonalDetails?.accountID; 
        
               const displayNameOrLogin = LocalePhoneNumber.formatPhoneNumber(personalDetail?.login ?? '') || (personalDetail?.displayName ?? '') || Localize.translateLocal('common.hidden'); 
        
               return `@${displayNameOrLogin}`; 
        
           });

The accountID variable was not defined and object retrieval by key was also incorrect. This is a regression from the TS migration (before that everything worked fine).

Do you want me to fix it as well or create another issue to handle that?

shubham1206agra · 2023-11-29T06:52:43Z

Can you fix it here only?

tienifr · 2023-11-29T07:22:14Z

@shubham1206agra Another edge case: If server returned the invited display name with spaces between, we could not render the mention after copy-pasting. I don't think this is possible with the current implementation of mention-user tag. Also this is an edge case, or maybe BE bug, because normally it would return login, I think we should ignore this.

Original:

Copy pasted:

shubham1206agra · 2023-11-29T08:51:40Z

@shubham1206agra Another edge case: If server returned the invited display name with spaces between, we could not render the mention after copy-pasting. I don't think this is possible with the current implementation of mention-user tag. Also this is an edge case, or maybe BE bug, because normally it would return login, I think we should ignore this.

Original:
Copy pasted:

@tienifr This looks weird bug. It should use email (login) here, instead of display name.
Can you put repro steps of this?

tienifr · 2023-11-29T08:58:41Z

@shubham1206agra I'm not sure about that, the invitation message was one month ago. I tried iniviting the same account again and accounts with display name but it just showed login. I believe this is a BE bug and has already been resolved somewhere.

shubham1206agra · 2023-11-29T09:00:14Z

+let environmentURL: string;
+Environment.getEnvironmentURL().then((url: string) => (environmentURL = url));
+


Can you see tryResolveUrlFromApiRoot instead of this?

Is there any specific reason? Because I took reference from ReportActionsUtils here:

App/src/libs/ReportActionsUtils.ts

Line 388 in 1234b0d

updatedReportAction.message[0].html = reportAction.message[0].html?.replace('%baseURL', environmentURL);

Maybe above method doesn't work in that case, thats why they have used environmentURL directly.

tryResolveUrlFromApiRoot requires a pre-defined/existing URL to resolve the base domain. In this case, there's no such URL. It's usually used for attachment link. For report actions, I see that environmentURL is used across the app like here, here, here, etc.

shubham1206agra · 2023-12-03T15:30:39Z

@tienifr In this, you may want to make link independent of platform cause clicking on room link from production website tries to take me to local link

shubham1206agra · 2023-12-04T03:43:50Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2023-12-03.at.8.57.46.PM.mov

Android: mWeb Chrome

Screen.Recording.2023-12-04.at.9.07.08.AM.mov

iOS: Native

Screen.Recording.2023-12-03.at.7.47.10.PM.mov

iOS: mWeb Safari

Screen.Recording.2023-12-04.at.9.04.57.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2023-12-04.at.9.02.51.AM.mov

MacOS: Desktop

Screen.Recording.2023-12-03.at.7.43.18.PM.mov

namhihi237 · 2023-12-04T07:21:04Z

Hi @shubham1206agra @tienifr , we have made changes related to the channel log, I think they are related to each other and may cause conflicts. Can the team help check to hold this PR until our PR is merged cc @cubuspl42 @mobilify

tienifr · 2023-12-04T07:29:58Z

@namhihi237 Can you link the related PR?

namhihi237 · 2023-12-04T07:31:02Z

Ah sorry,I am missing. I updated

shubham1206agra · 2023-12-04T07:41:42Z

@tienifr Can you see if this problem can be solved in the meantime? #32161 (comment)

tienifr · 2023-12-04T09:00:16Z

@shubham1206agra Sure! So by that you mean we put this PR on HOLD for #30927, don't you?

shubham1206agra · 2023-12-04T09:02:17Z

I think we can hold this as the holding PR is near merge state

jakub-trzebiatowski · 2023-12-04T09:22:11Z

Yes, please hold. We've had many, many review rounds there. I would be grateful if you applied your solution on top of those changes.

shubham1206agra · 2023-12-08T08:20:21Z

@tienifr Lets get this OFF HOLD now

tienifr · 2023-12-08T08:24:06Z

Seems like there was regression and they attempted to fix in #32612. I think we still need HOLD then.

jakub-trzebiatowski · 2023-12-11T13:35:25Z

I'll push #32612 forward ASAP

shubham1206agra · 2023-12-15T12:20:33Z

Lets get it OFF HOLD now as holding PR is now in production

shubham1206agra · 2023-12-19T04:48:05Z

@tienifr Bump here ^

tienifr · 2023-12-19T05:02:03Z

Taking a look.

tienifr · 2023-12-20T08:03:52Z

Discussing with #32612 author about the changes here. I'm close to to finishing this, just some minor details.

tienifr · 2023-12-20T09:03:43Z

@shubham1206agra We can continue here. #32612 already handled most of the parsing logic for us 🙏.

shubham1206agra

LGTM!

OSBotify · 2023-12-20T12:35:12Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-12-21T05:30:32Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.4.15-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-12-22T05:19:15Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.4.15-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

fix: room name in invite message does not show link

ad9ba61

tienifr marked this pull request as ready for review November 29, 2023 06:47

tienifr requested a review from a team as a code owner November 29, 2023 06:47

melvin-bot Bot requested review from shubham1206agra and removed request for a team November 29, 2023 06:47

remove redundat escape charaters

ebcd66f

tienifr added 2 commits November 29, 2023 13:52

Merge branch 'main' of https://github.com/tienifr/App into fix/31568

e69c631

fix: mention in copied invite message shown as hidden

fd0a9a9

shubham1206agra reviewed Nov 29, 2023

View reviewed changes

tienifr mentioned this pull request Dec 1, 2023

[$500] Room - Copy to clipboard and pasting specific email id in compose displays hidden #32359

Closed

6 tasks

tienifr changed the title ~~Turn channel log member message into HTML~~ [HOLD APP PR #30927] Turn channel log member message into HTML Dec 5, 2023

tienifr changed the title ~~[HOLD APP PR #30927] Turn channel log member message into HTML~~ Turn channel log member message into HTML Dec 20, 2023

Merge branch 'main' into fix/31568

f0acb42

tienifr added 2 commits December 20, 2023 16:01

copy mention

72da162

remove redundant imports

51f9bb0

shubham1206agra approved these changes Dec 20, 2023

View reviewed changes

melvin-bot Bot requested a review from luacmartins December 20, 2023 12:28

luacmartins approved these changes Dec 20, 2023

View reviewed changes

luacmartins merged commit 2540a7f into Expensify:main Dec 20, 2023

github-actions Bot mentioned this pull request Dec 21, 2023

Deploy Checklist: New Expensify 2023-12-21 #33391

Closed

51 tasks

melvin-bot Bot mentioned this pull request Dec 22, 2023

[HOLD for payment 2023-12-29] [$500] Room - In admin room, when copy to clipboard, the room name is not shown as link #31568

Closed

6 tasks

		let environmentURL: string;
		Environment.getEnvironmentURL().then((url: string) => (environmentURL = url));

Conversation

tienifr commented Nov 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Nov 29, 2023

Uh oh!

tienifr commented Nov 29, 2023

Uh oh!

shubham1206agra commented Nov 29, 2023

Uh oh!

tienifr commented Nov 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shubham1206agra commented Nov 29, 2023

Uh oh!

tienifr commented Nov 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shubham1206agra Nov 29, 2023

Choose a reason for hiding this comment

Uh oh!

tienifr Nov 29, 2023

Choose a reason for hiding this comment

Uh oh!

shubham1206agra Nov 29, 2023

Choose a reason for hiding this comment

Uh oh!

tienifr Nov 29, 2023

Choose a reason for hiding this comment

Uh oh!

shubham1206agra commented Dec 3, 2023

Uh oh!

shubham1206agra commented Dec 4, 2023

Reviewer Checklist

Screenshots/Videos

Uh oh!

namhihi237 commented Dec 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tienifr commented Dec 4, 2023

Uh oh!

namhihi237 commented Dec 4, 2023

Uh oh!

shubham1206agra commented Dec 4, 2023

Uh oh!

tienifr commented Dec 4, 2023

Uh oh!

shubham1206agra commented Dec 4, 2023

Uh oh!

jakub-trzebiatowski commented Dec 4, 2023

Uh oh!

shubham1206agra commented Dec 8, 2023

Uh oh!

tienifr commented Dec 8, 2023

Uh oh!

jakub-trzebiatowski commented Dec 11, 2023

Uh oh!

shubham1206agra commented Dec 15, 2023

Uh oh!

shubham1206agra commented Dec 19, 2023

Uh oh!

tienifr commented Dec 19, 2023

Uh oh!

tienifr commented Dec 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tienifr commented Dec 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shubham1206agra left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Dec 20, 2023

tienifr commented Nov 29, 2023 •

edited

Loading

tienifr commented Nov 29, 2023 •

edited

Loading

tienifr commented Nov 29, 2023 •

edited

Loading

namhihi237 commented Dec 4, 2023 •

edited

Loading

tienifr commented Dec 20, 2023 •

edited

Loading

tienifr commented Dec 20, 2023 •

edited

Loading