fix: getting unselected participants by dummy-1111 · Pull Request #32823 · Expensify/App

dummy-1111 · 2023-12-11T15:56:46Z

Details

Get unselected participants from the original participants list

Fixed Issues

$ #32808
PROPOSAL: #32808 (comment)

Tests

Open ND and log in with any account
Create a group chat and navigate to it
Tap "+" button near the main composer and select "Split bill"
Select "Manual" tab and input any amount and tap "Next" button
Uncheck the participants in the "Split with" list
Verify that unchecked participants remain in the list and user is able to toggle selection

Verify that no errors appear in the JS console

Offline tests

Open ND and log in with any account
Create a group chat and navigate to it
Tap "+" button near the main composer and select "Split bill"
Select "Manual" tab and input any amount and tap "Next" button
Uncheck the participants in the "Split with" list
Verify that unchecked participants remain in the list and user is able to toggle selection

QA Steps

Open ND and log in with any account
Create a group chat and navigate to it
Tap "+" button near the main composer and select "Split bill"
Select "Manual" tab and input any amount and tap "Next" button
Uncheck the participants in the "Split with" list
Verify that unchecked participants remain in the list and user is able to toggle selection

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

32808_android_native.mp4

Android: mWeb Chrome

32808_android_chrome.mp4

iOS: Native

32808_ios_native.mp4

iOS: mWeb Safari

32808_ios_safari.mp4

MacOS: Chrome / Safari

32808_mac_chrome.mp4

MacOS: Desktop

32808_mac_desktop.mp4

melvin-bot · 2023-12-11T16:28:42Z

@cubuspl42 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

jakub-trzebiatowski · 2023-12-11T17:37:01Z

    const optionSelectorSections = useMemo(() => {
        const sections = [];
-        const unselectedParticipants = _.filter(selectedParticipantsFiltered, (participant) => !participant.selected);
+        const unselectedParticipants = _.filter(selectedParticipants, (participant) => !participant.selected);


My gosh, these names are confusing. So we have...

selectedParticipants

selectedParticipantsFiltered, filtered on participant.selected

unselectedParticipants, also filtered, but on the negation of the above, i.e. on !participant.selected

Also, we consider selectedParticipantsFiltered heavy enough so it needs to be memoized, but unselectedParticipants not heavy enough to be memoized.

It's great that we found the root cause and fixed it, but maybe let's minimize the risk of a similar problem in this very area.

Do you understand the difference between selectedParticipants and selectedParticipantsFiltered? What is it actually filtered on?

/** Selected participants from MoneyRequestModal with login / accountID */ selectedParticipants: PropTypes.arrayOf(optionPropTypes).isRequired,

It sounds like these already are the "selected participants", how can they be more selected?

We need either some renaming, or some comments, or both

@cubuspl42

selectedParticipants are the participants selected in participants page(group chat members in our case)
selectedParticipantsFiltered are participants with selected = true. User can toggle them in the confirmation page. Initially all values of selected are true
unselectedParticipants are participants with selected = false

So maybe let's use another term for the "outer" selected participants, like chosenParticipants or pickedParticipants?

Then we could name the "inner" selected participants symmetrically, like...

selectedParticipants (where selected = true)

unselectedParticipants (where selected = false)

I think it would be clearer to declare them close to each other.

It's important to think about why it was easy to make a mistake and what we can do so it's, well, at least a bit harder to make a similar one in the future.

I searched the code briefly and it seems that there are not many usages to fix.

@cubuspl42

Please check again and let me know your thoughts

jakub-trzebiatowski · 2023-12-11T19:52:00Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

fix-participant-selection-web.mp4

Mobile Web - Chrome

fix-participant-selection-android-web-compressed.mp4

Mobile Web - Safari

fix-participant-selection-ios-web.mp4

Desktop

iOS

fix-participant-selection-ios.mp4

Android

fix-participant-selection-android-compressed.mp4

jakub-trzebiatowski · 2023-12-11T19:53:48Z

@tgolen Let me know if you agree that some renaming improves the readability here

luacmartins · 2023-12-11T20:32:23Z

Renaming seems to improve the readability to me. Nice suggestion!

OSBotify · 2023-12-11T20:53:12Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

fix: getting unselected participants (cherry picked from commit e5df7f6)

OSBotify · 2023-12-11T21:18:26Z

🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 1.4.11-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-12-13T11:10:04Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.11-25 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

fix: getting unseelected participants

b12afa0

dummy-1111 marked this pull request as ready for review December 11, 2023 16:28

dummy-1111 requested a review from a team as a code owner December 11, 2023 16:28

melvin-bot Bot requested review from jakub-trzebiatowski and removed request for a team December 11, 2023 16:28

dummy-1111 mentioned this pull request Dec 11, 2023

[HOLD for payment 2023-12-20] [$500] Split - Participants under “Split with” list disappear after unselecting them #32808

Closed

6 tasks

jakub-trzebiatowski reviewed Dec 11, 2023

View reviewed changes

fix: rename participant variables

7e362f2

jakub-trzebiatowski approved these changes Dec 11, 2023

View reviewed changes

melvin-bot Bot requested a review from tgolen December 11, 2023 19:53

luacmartins approved these changes Dec 11, 2023

View reviewed changes

tgolen merged commit e5df7f6 into Expensify:main Dec 11, 2023

OSBotify pushed a commit that referenced this pull request Dec 11, 2023

Merge pull request #32823 from s-alves10/fix/issue-32808

8f7af2d

fix: getting unselected participants (cherry picked from commit e5df7f6)

github-actions Bot mentioned this pull request Dec 11, 2023

Deploy Checklist: New Expensify 2023-12-11 #32794

Closed

81 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: getting unselected participants#32823

fix: getting unselected participants#32823
tgolen merged 2 commits into
Expensify:mainfrom
dummy-1111:fix/issue-32808

dummy-1111 commented Dec 11, 2023

Uh oh!

melvin-bot Bot commented Dec 11, 2023

Uh oh!

jakub-trzebiatowski Dec 11, 2023 •

edited

Loading

Uh oh!

dummy-1111 Dec 11, 2023

Uh oh!

jakub-trzebiatowski Dec 11, 2023

Uh oh!

dummy-1111 Dec 11, 2023

Uh oh!

jakub-trzebiatowski commented Dec 11, 2023

Uh oh!

jakub-trzebiatowski commented Dec 11, 2023

Uh oh!

luacmartins commented Dec 11, 2023

Uh oh!

OSBotify commented Dec 11, 2023

Uh oh!

OSBotify commented Dec 11, 2023

Uh oh!

OSBotify commented Dec 13, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

dummy-1111 commented Dec 11, 2023

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Dec 11, 2023

Uh oh!

jakub-trzebiatowski Dec 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dummy-1111 Dec 11, 2023

Choose a reason for hiding this comment

Uh oh!

jakub-trzebiatowski Dec 11, 2023

Choose a reason for hiding this comment

Uh oh!

dummy-1111 Dec 11, 2023

Choose a reason for hiding this comment

Uh oh!

jakub-trzebiatowski commented Dec 11, 2023

Reviewer Checklist

Screenshots/Videos

Uh oh!

jakub-trzebiatowski commented Dec 11, 2023

Uh oh!

luacmartins commented Dec 11, 2023

Uh oh!

OSBotify commented Dec 11, 2023

Uh oh!

OSBotify commented Dec 11, 2023

Uh oh!

OSBotify commented Dec 13, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

jakub-trzebiatowski Dec 11, 2023 •

edited

Loading