[QBO Export] Manual exports by kosmydel · Pull Request #44170 · Expensify/App

kosmydel · 2024-06-21T16:01:55Z

Details

This PR:

Add new exportToIntegration and markAsManuallyExported actions
Add a new Export menu item to the report details page
Create a new ReportDetailsExportPage with "Export" and "Mark as exported" options
Update ReportPreview actions to show export options
Update the MoneyReportHeader to show export options

Fixed Issues

$ #44022
PROPOSAL: N/A

Tests

Those tests should be performed on the staging environment. In your .env file add ENVIRONMENT=staging variable.

Do the tests below for both QBO and Xero integrations.

Prerequisites

Collect workspace with an admin and member
Setup QBO integration connection

Steps 1

Open the report details (click the carret in the header) on the failed report
Verify there’s an “Export” Item
Select it
Verify there’s a “Mark as manually entered” option and select it
Verify
A system message “marked this report as manually exported to QuickBooks Online” is added to the report
The red dot on the report in the LHN is removed
Click on the "Export" item and "Mark as manually entered" again, verify the "reports have already been exported" modal is displayed.
Steps 2
Turn off auto sync in Workspace -> Accountting -> Advanced
Create a new expense in the policy
Pay expense elsewhere
A Export button should appear in the report preview and report header.
Click on the "Export" button in the report preview
Verify everything works.

Offline tests

Offline pattern B is going to be implemented in a follow-up PR here.

QA Steps

Verify that no errors appear in the JS console
Do the tests from the Tests section above

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

mweb-android.mov

iOS: Native

ios.mp4

iOS: mWeb Safari

mweb-ios.mp4

MacOS: Chrome / Safari

web1.mov

web2.mov

MacOS: Desktop

desktop.mov

kosmydel · 2024-06-25T11:28:11Z

Hey @Expensify/design, could you please share the "Not ready to export" illustration with me? Thank you!

hungvu193 · 2024-06-26T02:30:47Z

~~@kosmydel it looks the same with the image we used in SageIntacct feature. In that case you can take in from here:~~
https://github.com/Expensify/App/pull/43661/files#diff-e81b59ee3960feb94e1b55384682e24b2fcece6d7fd90ad2e6a98fa5f31de532

hungvu193 · 2024-06-26T02:31:12Z

Oops my bad, it looks different 🤦

dannymcclain · 2024-06-27T14:14:37Z

@kosmydel Here's that illustration!

LaptopwithSecondScreenandHourglass.svg.zip

kosmydel · 2024-07-16T08:21:16Z

I've addressed the review, ready for re-review.

arosiclair · 2024-07-16T15:15:04Z

Thanks for the changes!

arosiclair · 2024-07-16T15:18:52Z

Hm actually looking at @hungvu193's screenshots, why doesn't "Quickbooks Online" show in the message text here? It looks like it's missing on all platforms

hungvu193 · 2024-07-16T15:42:48Z

Hm actually looking at @hungvu193's screenshots, why doesn't "Quickbooks Online" show in the message text here? It looks like it's missing on all platforms

Yeah, I think BE related, here's the return values from OpenReport, probably related to #44170 (comment) .

arosiclair · 2024-07-16T15:58:45Z

That's weird, but agree it shouldn't be an issue with this PR. Merging!

OSBotify · 2024-07-16T16:09:03Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-07-17T02:09:05Z

🚀 Deployed to staging by https://github.com/arosiclair in version: 9.0.8-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

kavimuru · 2024-07-17T11:43:31Z

@kosmydel @hungvu193 @arosiclair how to make a failed report as in the step 1

Open the report details (click the carret in the header) on the failed report

hungvu193 · 2024-07-17T11:44:54Z

@kosmydel @hungvu193 @arosiclair how to make a failed report as in the step 1

Open the report details (click the carret in the header) on the failed report

IIRC You neeed to export it first

arosiclair · 2024-07-17T14:28:46Z

@kosmydel @hungvu193 @arosiclair how to make a failed report as in the step 1

@kavimuru here are steps to force an export to QBO to fail:

Prerequisites

Add a chart of account (category) to QBO that you can delete later

Steps

Create a report with an expense
Categorize the expense using the new QBO category
Submit it
Log in as the workspace admin and approve the report
Log into QBO and deactivate the chart of account for the category (Menu > Transactions > Chart of accounts > {account} menu > Make inactive)
Export the report to QBO (3-dot menu > Export > Quickbooks Online)
Verify
- a system message “failed to auto-export this report due to an error” is added to the report
- a red dot is added next to the report in the LHN

OSBotify · 2024-07-17T15:49:25Z

🚀 Cherry-picked to staging by https://github.com/Beamanator in version: 9.0.8-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

…l/qbo-export/manual-exports" This reverts commit 303c398, reversing changes made to 936ae92.

OSBotify · 2024-07-18T13:49:29Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.8-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-19T19:36:07Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.9-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

s77rt · 2025-03-21T22:34:20Z

+                <ConfirmationPage
+                    illustration={Illustrations.LaptopwithSecondScreenandHourglass}
+                    heading={translate('workspace.export.notReadyHeading')}
+                    description={translate('workspace.export.notReadyDescription')}
+                    shouldShowButton
+                    buttonText={translate('common.buttonConfirm')}
+                    onButtonPress={Navigation.goBack}
+                    illustrationStyle={{width: 233, height: 162}}
+                />


This is missing flex styles to have the component occupies the whole page. Coming from #58342

@s77rt this is not the offending PR. There's another PR that added containeStyle recently (few weeks ago). This PR has been working fine for months

Ah my bad! You are right!

allroundexperts · 2025-06-01T20:17:10Z

-
    const shouldShowSubmitButton = isDraft && reimbursableSpend !== 0 && !allHavePendingRTERViolation;
+
+    const shouldShowExportIntegrationButton = !shouldShowPayButton && !shouldShowSubmitButton && connectedIntegration && !!policy;


Using connectedIntegration as a condition caused #59813. If the integration connection is invalid, its an empty object rather than being false.

kosmydel added 17 commits June 20, 2024 14:05

feat: setup the ReportDetailsExportPage.tsx and navigation

f48cff1

feat: add Onyx actions

6eb2f4d

feat: getConnectedIntegration

80389e9

feat: use SelectionScreen in ReportDetailsExportPage

bdb2917

feat: add ConfirmModal

87ea402

feat: export in ReportPreview

01b5268

Merge branch 'main' into @kosmydel/qbo-export/manual-exports

100e1dc

fix: exporting reports

e552a93

cleanup

062f557

Merge branch 'main' into @kosmydel/qbo-export/manual-exports

64620f6

feat: spanish translations

d00f1f0

feat: add manual button export to MoneyReportHeader

095b0cc

refactor: getConnectedIntegration

2ea4435

refactor: include dropdownOptions in ExportWithDropdownMenu

b8fcea9

feat: add not ready to export screen

92949a7

feat: add screen wrapper

82708fc

Merge branch 'main' into @kosmydel/qbo-export/manual-exports

cc0b95a

feat: empty Export screen translation

cff5d28

kosmydel added 2 commits June 26, 2024 11:42

Merge branch 'main' into @kosmydel/qbo-export/manual-exports

e8f6379

fix: types

f13f1cd

kosmydel added 6 commits June 27, 2024 16:32

feat: confirmation button in dropdown menu

2c8ab95

feat: add correct illustration

163718d

feat: dropdown menu clickable button

40a1462

feat: persist last export method

5e01f89

Merge branch 'main' into @kosmydel/qbo-export/manual-exports

f10a469

fix displaying integration names

4c43898

arosiclair approved these changes Jul 16, 2024

View reviewed changes

arosiclair merged commit 303c398 into Expensify:main Jul 16, 2024

github-actions Bot mentioned this pull request Jul 17, 2024

Deploy Checklist: New Expensify 2024-07-17 #45538

Closed

48 tasks

lakchote mentioned this pull request Jul 17, 2024

[CP Staging] Fix export integration next step showing for workspace members #45577

Merged

50 tasks

izarutskaya mentioned this pull request Jul 17, 2024

Xero - Export button is showing in report details page for Admin, but not for Employee #45590

Closed

6 tasks

izarutskaya mentioned this pull request Jul 17, 2024

Xero -"manually exported" message only appears after revisting export and it is missing "Xero" #45594

Closed

6 tasks

lanitochka17 mentioned this pull request Jul 17, 2024

[HOLD #43783][$250] Accounting - Submit button flickers in and out for non-admin submitter immediately after clicking Submit #45624

Closed

6 tasks

francoisl added a commit that referenced this pull request Jul 17, 2024

Revert "Merge pull request #44170 from software-mansion-labs/@kosmyde…

8be13b0

…l/qbo-export/manual-exports" This reverts commit 303c398, reversing changes made to 936ae92.

francoisl mentioned this pull request Jul 17, 2024

Revert "Merge pull request #44170 from software-mansion-labs/@kosmydel/qbo-export/manual-exports" #45641

Closed

50 tasks

izarutskaya mentioned this pull request Jul 18, 2024

[HOLD for payment 2024-08-01] [$250] Xero export - Different thread title when opening export error message in thread #45669

Closed

6 tasks

melvin-bot Bot mentioned this pull request Jul 18, 2024

[HOLD for payment 2024-07-25] [QBO Export] [$250] Implement manual report exports #44022

Closed

hungvu193 mentioned this pull request Jul 18, 2024

Format message for olddot action #45683

Merged

50 tasks

s77rt reviewed Mar 21, 2025

View reviewed changes

s77rt mentioned this pull request Mar 21, 2025

[PAY 26th MARCH][$250] Accounting - Export page content is not wrapped correctly #58342

Closed

8 tasks

allroundexperts reviewed Jun 1, 2025

View reviewed changes


		const shouldShowSubmitButton = isDraft && reimbursableSpend !== 0 && !allHavePendingRTERViolation;

		const shouldShowExportIntegrationButton = !shouldShowPayButton && !shouldShowSubmitButton && connectedIntegration && !!policy;

Conversation

kosmydel commented Jun 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

kosmydel commented Jun 25, 2024

Uh oh!

hungvu193 commented Jun 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hungvu193 commented Jun 26, 2024

Uh oh!

dannymcclain commented Jun 27, 2024

Uh oh!

kosmydel commented Jul 16, 2024

Uh oh!

arosiclair commented Jul 16, 2024

Uh oh!

arosiclair commented Jul 16, 2024

Uh oh!

hungvu193 commented Jul 16, 2024

Uh oh!

arosiclair commented Jul 16, 2024

Uh oh!

OSBotify commented Jul 16, 2024

Uh oh!

OSBotify commented Jul 17, 2024

Uh oh!

kavimuru commented Jul 17, 2024

Uh oh!

hungvu193 commented Jul 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

arosiclair commented Jul 17, 2024

Uh oh!

OSBotify commented Jul 17, 2024

Uh oh!

OSBotify commented Jul 18, 2024

Uh oh!

OSBotify commented Jul 19, 2024

Uh oh!

s77rt Mar 21, 2025

Choose a reason for hiding this comment

Uh oh!

hungvu193 Mar 22, 2025

Choose a reason for hiding this comment

Uh oh!

s77rt Mar 22, 2025

Choose a reason for hiding this comment

Uh oh!

allroundexperts Jun 1, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

kosmydel commented Jun 21, 2024 •

edited

Loading

hungvu193 commented Jun 26, 2024 •

edited

Loading

hungvu193 commented Jul 17, 2024 •

edited

Loading