Skip to content

Revert "Merge pull request #44170 from software-mansion-labs/@kosmydel/qbo-export/manual-exports"#45641

Closed
francoisl wants to merge 3 commits into
mainfrom
francois-revert-44170
Closed

Revert "Merge pull request #44170 from software-mansion-labs/@kosmydel/qbo-export/manual-exports"#45641
francoisl wants to merge 3 commits into
mainfrom
francois-revert-44170

Conversation

@francoisl

@francoisl francoisl commented Jul 17, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Details

Revert of #44170
Revert of #44930 (because of TS type changes that depended on the previous PR)

Fixed Issues

$ #45624

Tests / QA steps

(Same as #45624)

Pre-requisites:

  • Have a collect workspace
  • Enable delayed submission for the workspace
  • Create either a QBO or Xero connection
  1. Navigate to staging.new.expensify.com
  2. Sign in as the admin of the workspace
  3. Create an expense in the workspace chat
  4. Navigate to the combined expense report page and click on submit
  5. Wait for a few seconds and observe the header button
  6. Make sure the button changes to "Pay"
  • Verify that no errors appear in the JS console

Offline tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

MacOS: Chrome / Safari
Screen.Recording.2024-07-17.at.5.33.40.PM.mov

There's also a delay with the button changing from "Approve" to "Pay" in production

Screen.Recording.2024-07-17.at.5.32.12.PM.mov

@francoisl
Revert "Merge pull request #44170 from software-mansion-labs/@kosmyde…
8be13b0 
…l/qbo-export/manual-exports"

This reverts commit 303c398, reversing
changes made to 936ae92.
@francoisl francoisl self-assigned this Jul 17, 2024
@francoisl francoisl mentioned this pull request Jul 17, 2024
Closed
6 tasks
@github-actions

This comment has been minimized.

Sign in to view
@francoisl
Revert "Merge pull request #44930 from Expensify/arosiclair-export-in…
3e15424 
…tegration-action"

This reverts commit 8825b89, reversing
changes made to 825821b.
@github-actions

github-actions Bot commented Jul 18, 2024

Copy link
Copy Markdown
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/45641/index.html https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/45641/index.html
Android iOS
Desktop 💻 Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/45641/NewExpensify.dmg https://45641.pr-testing.expensify.com
Desktop Web

👀 View the workflow run that generated this build 👀

@francoisl francoisl requested a review from thienlnam July 18, 2024 01:50
@francoisl

francoisl commented Jul 18, 2024

Copy link
Copy Markdown
Contributor Author

Keeping this in draft but ready to go in case we can't figure out #45624

@francoisl

francoisl commented Jul 23, 2024

Copy link
Copy Markdown
Contributor Author

We no longer need this.

@francoisl francoisl closed this Jul 23, 2024
@francoisl francoisl deleted the francois-revert-44170 branch July 23, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thienlnam thienlnam Awaiting requested review from thienlnam

Assignees

@francoisl francoisl

Labels

Ready To Build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@francoisl