Fix crashes when saving 0 as custom tag name #44391

bernhardoj · 2024-06-25T13:27:58Z

Details

Saving the tag name as 0 will crash the app. This PR fix it.

Fixed Issues

$ #43773
PROPOSAL: #43773 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Go to workspace tags page
Press Settings
Press the tag name
Rename the tag to 0
When it fails, verify the tag name reverts to the previous name
Press the close error button
Verify the error is cleared

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-06-25.at.21.26.07.mov

Android: mWeb Chrome

Screen.Recording.2024-06-25.at.21.28.36.mov

iOS: Native

Screen.Recording.2024-06-25.at.21.18.27.mov

iOS: mWeb Safari

Screen.Recording.2024-06-25.at.21.19.55.mov

MacOS: Chrome / Safari

Screen.Recording.2024-06-25.at.21.15.57.mov

MacOS: Desktop

Screen.Recording.2024-06-25.at.21.16.56.mov

melvin-bot · 2024-06-25T13:28:03Z

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ZhenjaHorbach · 2024-06-25T16:28:15Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

android-web.mov

iOS: Native

ios.mov

iOS: mWeb Safari

ios-web.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

ZhenjaHorbach · 2024-06-26T07:07:38Z

@bernhardoj
Thank you for your PR
But I noticed a slight discrepancy in behavior here
Can you please check ?

When we open the page and change the tag to 0
We will have the tag name in white
When we change the tag to the correct value, and then change it to 0
Then our tag will be gray

Plus

When we have an error and we change the value to the correct one
The error does not go away

2024-06-26.09.03.43.mov

bernhardoj · 2024-06-26T08:14:23Z

Fixed.

ZhenjaHorbach · 2024-06-26T10:04:48Z

Fixed.

Thank you
But we still have issues related with tag color

Plus when we change text to valid value and then change to 0 we will have this

Can you take a look, please ?

2024-06-26.12.03.54.mov

bernhardoj · 2024-06-26T10:31:55Z

Oh, I thought it's already fixed. I will take a look at it later. Idk why somehow the network request keep stuck.

I did:

Change the name to 0
Change the name to a valid name
Change the name to 0 (stuck here, never processed, it's in the networkRequestQueue)

ZhenjaHorbach · 2024-06-26T10:36:45Z

Oh, I thought it's already fixed. I will take a look at it later. Idk why somehow the network request keep stuck.

I did:

Change the name to 0

Change the name to a valid name

Change the name to 0 (stuck here, never processed, it's in the networkRequestQueue)

But from other side
I'm not sure what we should fix as part of this PR

@danieldoglas
What do you think about it?
Should we waste time on this issue?
Although it is not related to our changes and requirements in this issue

bernhardoj · 2024-06-27T07:47:57Z

Fixed the grayed-out issue. Still have no idea what causes the other issue.

bernhardoj · 2024-06-27T08:07:25Z

Ok, so for the other issue, it's related to the BE too. If we update the tag name from A to B, we will optimistically merge:
A: null (old tag)
B: newTagData

then, if we quickly change the name from B to 0 (or others) before the first rename request completes, we will optimistically merge:
B: null (old tag)
0: newTagData

After the first request completes (A -> B), the BE response will merge the B tag data.

So now, we have 2 tag lists, B and 0 which is detected as multi-level tags. After the second request fails, the 0 tag is removed, so we are back with 1 tag.

ZhenjaHorbach · 2024-06-27T12:33:08Z

Ok, so for the other issue, it's related to the BE too. If we update the tag name from A to B, we will optimistically merge: A: null (old tag) B: newTagData

then, if we quickly change the name from B to 0 (or others) before the first rename request completes, we will optimistically merge: B: null (old tag) 0: newTagData

After the first request completes (A -> B), the BE response will merge the B tag data.

So now, we have 2 tag lists, B and 0 which is detected as multi-level tags. After the second request fails, the 0 tag is removed, so we are back with 1 tag.

Thank you very much for checking
@danieldoglas
I think this will be useful for the internal team

ZhenjaHorbach · 2024-06-27T12:33:51Z

The changes look great

LGTM

OSBotify · 2024-07-08T11:13:24Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-07-08T12:06:14Z

🚀 Deployed to staging by https://github.com/danieldoglas in version: 9.0.5-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-07-08T15:31:51Z

🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.0.5-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-07-08T15:42:13Z

🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.0.5-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-07-10T11:01:14Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.5-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-15T20:20:47Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.6-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

bernhardoj added 2 commits June 25, 2024 21:21

set the error correctly

8baf254

allow to clear the error

6b59f2a

bernhardoj requested a review from a team as a code owner June 25, 2024 13:27

melvin-bot bot removed the request for review from a team June 25, 2024 13:28

melvin-bot bot requested a review from ZhenjaHorbach June 25, 2024 13:28

update test

d510418

bernhardoj added 2 commits June 26, 2024 15:54

Merge branch 'main' into fix/43773-crash-when-saving-tag-name-error

b3b1952

clear errors when updating name

3436e79

clear pending action when fails

c73fedc

ZhenjaHorbach approved these changes Jun 27, 2024

View reviewed changes

melvin-bot bot requested a review from danieldoglas June 27, 2024 12:33

danieldoglas approved these changes Jul 8, 2024

View reviewed changes

danieldoglas merged commit 8d99586 into Expensify:main Jul 8, 2024

github-actions bot mentioned this pull request Jul 8, 2024

Deploy Checklist: New Expensify 2024-07-08 #44947

Closed

86 tasks

lanitochka17 mentioned this pull request Jul 8, 2024

[$500] Web - It's possible to create a tag name "0", the app will crash when it's deleted #45016

Closed

6 tasks

Fix crashes when saving 0 as custom tag name #44391

Fix crashes when saving 0 as custom tag name #44391

Uh oh!

Conversation

bernhardoj commented Jun 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jun 25, 2024

Uh oh!

ZhenjaHorbach commented Jun 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ZhenjaHorbach commented Jun 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bernhardoj commented Jun 26, 2024

Uh oh!

ZhenjaHorbach commented Jun 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bernhardoj commented Jun 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ZhenjaHorbach commented Jun 26, 2024

Uh oh!

bernhardoj commented Jun 27, 2024

Uh oh!

bernhardoj commented Jun 27, 2024

Uh oh!

ZhenjaHorbach commented Jun 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ZhenjaHorbach commented Jun 27, 2024

Uh oh!

OSBotify commented Jul 8, 2024

Uh oh!

OSBotify commented Jul 8, 2024

Uh oh!

OSBotify commented Jul 8, 2024

Uh oh!

OSBotify commented Jul 8, 2024

Uh oh!

OSBotify commented Jul 10, 2024

Uh oh!

OSBotify commented Jul 15, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

bernhardoj commented Jun 25, 2024 •

edited

Loading

ZhenjaHorbach commented Jun 25, 2024 •

edited

Loading

ZhenjaHorbach commented Jun 26, 2024 •

edited

Loading

ZhenjaHorbach commented Jun 26, 2024 •

edited

Loading

bernhardoj commented Jun 26, 2024 •

edited

Loading

ZhenjaHorbach commented Jun 27, 2024 •

edited

Loading