Skip to content

Fix crashes when saving 0 as custom tag name #44391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danieldoglas merged 6 commits into from
Jul 8, 2024
Merged

Fix crashes when saving 0 as custom tag name #44391

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8baf254
set the error correctly
bernhardoj Jun 25, 2024
6b59f2a
allow to clear the error
bernhardoj Jun 25, 2024
d510418
update test
bernhardoj Jun 25, 2024
b3b1952
Merge branch 'main' into fix/43773-crash-when-saving-tag-name-error
bernhardoj Jun 26, 2024
3436e79
clear errors when updating name
bernhardoj Jun 26, 2024
c73fedc
clear pending action when fails
bernhardoj Jun 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
set the error correctly
  • Loading branch information
@bernhardoj
bernhardoj committed Jun 25, 2024
commit 8baf2540cdc7f6df53c6bb3f8b0dffdb72f2d009
9 changes: 4 additions & 5 deletions src/libs/actions/Policy/Tag.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -589,12 +589,11 @@ function renamePolicyTaglist(policyID: string, policyTagListName: {oldName: stri
onyxMethod: Onyx.METHOD.MERGE,
key: `${ONYXKEYS.COLLECTION.POLICY_TAGS}${policyID}`,
value: {
errors: {
[oldName]: oldName,
[newName]: ErrorUtils.getMicroSecondOnyxErrorWithTranslationKey('workspace.tags.genericFailureMessage'),
},
[newName]: null,
[oldName]: oldPolicyTags,
[oldName]: {
...oldPolicyTags,
errors: ErrorUtils.getMicroSecondOnyxErrorWithTranslationKey('workspace.tags.genericFailureMessage'),
},
},
},
],
Expand Down