Fix broken two touch zoom for Attachment Images#4440
Merged
Conversation
yuwenmemon
previously approved these changes
Aug 6, 2021
marcaaron
requested changes
Aug 9, 2021
marcaaron
left a comment
marcaaron
left a comment
Contributor
There was a problem hiding this comment.
Looks good there's just a small style guide rule we should fix up
| Create an invisible view on top of the image so we can capture and set the amount of touches before | ||
| the ImageZoom's PanResponder does. Children will be triggered first, so this needs to be inside the | ||
| ImageZoom to work | ||
| */} |
Contributor
Author
|
Updated! |
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
53 tasks
Contributor
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@marcaaron will you please review this?
Details
This PR fixes a regression where zooming with two fingers on an attachment was broken.
Fixed Issues
$ #2499
Tests/QA
Tested On
Screenshots