Deploy Checklist: Expensify.cash 2021-08-11

[OSBotify]

Release Version: 1.0.85-8
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Create custom TextInput #3414
• Inset the full screen modal used for workspaces on large devices #3887
• [CP Staging] Remove duplicate form fields #4117
• [No QA] Add deployer GH handle to deploy messages #4274
• Fixed Confirm Password Validation in "Change Password" screen #4409
• #4375 fix ios user redirect to set up password + update staging url for app association on native platforms #4418
• Fix broken two touch zoom for Attachment Images #4440
• Remove deleted workspaces from list #4453
• Add VBA loading animation #4465
• Remove auto-complete for Industry Classification Code #4471
• Copy update #4473
• [InternalQA] Update Onyx after validating bank account #4474
• Autofill previously entered accounting and routing numbers #4477
• Add incorporationState as required field in Bank Account flow #4479
• [InternalQA] Prevent UI change on VBA flow during data fetch #4480
• Redirect to New Workspace Creation with Invalid Policy Id in Workspace URL #4481
• Use centered modal for errors in the VBA flow in NewDot #4483
• fix: message alignment #4503
• Update Onyx hash (LRU cache) #4509
• stop adding duplicate members #4510
• Update e-common #4511
• Change the View open jobs URL to click through to E/App open issues instead of Upwork jobs #4516
• Added translation for edit button text #4521
• Show a growl when trying to create a chat with an invalid phone number #4525
• Add /generated folder in android to .gitignore #4527
• Update the password label in Plaid VBA flow #4530
• Require restricted business checkbox on CompanyStep #4531
• Always auto name and create new workspaces from oldDot #4533
• [No QA] Make a dummy change for a test PR #4568
• Dummy comment for a test PR #4569
• [No QA] Fix bug in markPullRequestsAsDeployed #4572
• Cleanup dummy change #4576
• Undo dummy change #4577
• Fix ExpensiInput autoFocus & tab Focus #4593
• Hide Password mismatch incase both the passwords are empty #4607
• Update react-native-onyx to reduce setState() calls / renders in withOnyx #4610
• Check for value before checking length #4613
• Clear storage immediately on sign out #4614
• Fix: autofill on the BaseExpensiInput #4632
• Update state picker component in VBA flow #4633
• Change picker value color #4641
• [CP Staging] Use props not state in NewPasswordForm #4684

Deploy Blockers:

• Attachment - Image does not zoom in when two fingers are used #2499
• Input does not handle Tab focus and autofocus correctly. #4514
• iOS / Android - After sign out of an account redirects user to resend link page #4595
• mWeb - Text is overlapping with the place holder text in What's for field #4596
• Web - New text input does not work with autofill #4597
• Android - Signup - Blank screen is displayed after updating the url to staging in the magic link #4599
• [Apple rejecting release] Investigate splash screen issue with apple test credentials #4608
• Android - Profile - Selected pronoun is not visible in the "Preferred Pronouns" field #4628
• State Dropdown not displaying properly on Company Step #4630
• Personal and Company Address input fields have a label that is too long #4631
• [HOLD for payment 2021-08-24] Desktop - Error message for password mismatch not dismissed #4665

cc @Expensify/applauseleads

[roryabraham]

Checked the following PRs off the checklist that were added in error due to https://github.com/Expensify/Expensify/issues/168349:

• Add offline message to IOU and Split bill and allow currency selection while offline #4019
• [CP Staging] Remove duplicate form fields #4117
• 🍒 Cherry pick PR #4117 to staging 🍒 #4125
• fix: paste and Ctrl+z #4131
• Modify line height so text does not get cut off in LHN #4143
• 🍒 Cherry pick PR #4131 to staging 🍒 #4149
• 🍒 Cherry pick PR #4143 to staging 🍒 #4152
• 🍒 Cherry pick PR #4019 to staging 🍒 #4193
• Update version to 1.0.79-5 on staging #4197
• Update version to 1.0.79-6 on staging #4202
• Update version to 1.0.80-0 on staging #4204
• Make sure we get state/status from the right variable name when we get chat report name #4239
• Web - Settings - Dropdown symbol overlaps with text in the box #4243
• 🍒 Cherry pick PR #4243 to staging 🍒 #4245
• 🍒 Cherry pick PR #4239 to staging 🍒 #4249
• Update version to 1.0.80-3 on staging #4278
• Update version to 1.0.81-0 on staging #4282
• Fix staging due to undefined Onyx key #4286
• 🍒 Cherry pick PR #4286 to staging 🍒 #4289
• Fix broken list components on staging #4300
• 🍒 Cherry pick PR #4300 to staging 🍒 #4306
• Patch for PR #4190  #4322
• 🍒 Cherry pick PR #4322 to staging 🍒 #4327
• Update version to 1.0.81-5 on staging #4332
• Update version to 1.0.81-6 on staging #4335
• Update getPullRequestsMergedBetween to run pre-set string command #4336
• Update XCode to fix iOS deploy #4339
• Update version to 1.0.81-7 on staging #4341
• Update version to 1.0.81-8 on staging #4344
• Update version to 1.0.82-0 on staging #4347
• Fix User is able to upload a file larger than 50mb #4358
• Fix: Selecting a language does not update in real time #4366
• 🍒 Cherry pick PR #4358 to staging 🍒 #4369
• 🍒 Cherry pick PR #4339 to staging 🍒 #4373
• 🍒 Cherry pick PR #4366 to staging 🍒 #4390
• Fix: Infinite loader on login #4397
• Attempt at fixing race #4416
• 🍒 Cherry pick PR #4416 to staging 🍒 #4428
• 🍒 Cherry pick PR #4397 to staging 🍒 #4430
• Race fix attempt 2 #4436
• 🍒 Cherry pick PR #4436 to staging 🍒 #4439
• 🍒 Cherry pick PR #4336 to staging 🍒 #4442
• Update version to 1.0.82-8 on staging #4446
• Update version to 1.0.82-9 on staging #4450
• Update version to 1.0.82-10 on staging #4452
• Update version to 1.0.82-11 on staging #4455
• Update version to 1.0.83-0 on staging #4458
• 🍒 Cherry pick PR #4503 to staging 🍒 #4536
• Update version to 1.0.83-2 on staging #4553

[roryabraham]

Locking this per the testing steps from #4274

[roryabraham]

#4274 didn't work perfectly 😞

So I'm going to remove the lock label and try again with #4572

[francoisl]

Also checking off the following due to do https://github.com/Expensify/Expensify/issues/168349

• 🍒 Cherry pick PR #4568 to staging 🍒 #4571
• Update version to 1.0.84-2 on staging #4575
• Update version to 1.0.84-3 on staging #4581
• Update version to 1.0.84-4 on staging #4583
• Update version to 1.0.84-5 on staging #4585
• Update version to 1.0.85-0 on staging #4589
• [No QA] Fix bug in markPullRequestsAsDeployed #4572
• [CP Staging] Remove duplicate form fields #4117

[isagoico]

@roryabraham Looks like Desktop deploy failed in most PRs. We will hold on desktop regression until it's resolved.

[Jag96]

Checking off #4477, tests pass

[isagoico]

Starting QA 🚀

[isagoico]

@AndrewGable iOS build is 1.0.84-5, should we hold until .85-0?

[roryabraham]

Our last iOS staging deploy failed, but I think it may have been a fluke. So given the following two facts:

1. There should be no material difference between 1.0.84-5 and 1.0.85-0 other than the version – we just bump the PATCH version to get it ready to ship to the app stores.
2. The staging branch has already been updated to 1.0.85-0, so the next prod release will also use 1.0.85-0.

That means that in this case you should be fine to run iOS QA on 1.0.84-5, and if everything passes we can ship 1.0.85-0 to prod. Feel free to buddy-check me here @AndrewGable but I think we're safe in this case.

[roryabraham]

Now we're seeing a bunch of duplicate issues on the checklist, and I'm pretty sure it's because of the repo rename. I'm going to try and cleanup the issue and it should be resolved going forward.