[InternalQA] Update Onyx after validating bank account#4474
Merged
Conversation
marcaaron
previously approved these changes
Aug 9, 2021
marcaaron
left a comment
marcaaron
left a comment
Contributor
There was a problem hiding this comment.
LGTM, just left a question / NAB. Onyx is capable of batching merges, but it doesn't always lead to the clearest code IMO.
Contributor
Author
|
Updated! |
marcaaron
approved these changes
Aug 9, 2021
Contributor
Author
|
Self-merging as discussed 1:1 |
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
53 tasks
Contributor
|
🚀 Deployed to staging by @luacmartins in version: 1.0.83-2 🚀
|
Contributor
|
Hi @luacmartins, any chance you can run the internal QA steps and check this PR off #4554 if it works please? Thanks! |
Contributor
Author
|
Waiting for the validation codes here https://github.com/Expensify/Expensify/issues/173744 |
Contributor
Author
|
Steps confirmed in staging! |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/173086
$ #4466
Tests
Get StartedPENDINGstate.isUsingExpensifyCard:truehere so we can simulate auto provisioning of the card.Manage Card.QA Steps
Internal QA. Steps above.
Tested On
Screenshots
Web
web-1.mov
web-2.mov
Mobile Web
Desktop
iOS
Android