fix: List still shows receipt when removed#44762
Merged
Merged
Conversation
|
@thesahindia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
6 tasks
Member
|
Will review in the morning. |
Contributor
Author
|
@thesahindia friendly bump |
Member
|
For some reason, my comment didn't get posted.
The second part of the issue is still reproducible. Screen.Recording.2024-07-05.at.10.21.32.PM.mov |
Contributor
Author
|
@thesahindia I can't reproduce this bug. Please add more detailed steps. web-resize.mp4 |
Member
|
In order to repro this you have to make sure that the image is visible in the preview. Then you can go offline and delete it. Screen.Recording.2024-07-11.at.10.13.09.PM.mov |
Contributor
Author
|
@thesahindia I updated, please help to check again. |
Member
|
It's still reproducible @nkdengineer Screen.Recording.2024-07-16.at.11.51.17.PM.mov |
Member
|
Bump @nkdengineer |
Contributor
Author
|
I will update tomorrow morning. |
Contributor
Author
|
@thesahindia I checked this bug and it also happens on staging. I think we should handle this bug as a separate issue. |
Member
@nkdengineer, this will need to be fixed here since it was already mentioned in the OP at the last step.
|
Contributor
Author
|
Thanks. I will check this again. |
Contributor
Author
|
@thesahindia I fixed this bug and tested, please help to check again. |
Member
I can still repro it. |
Contributor
Author
|
@thesahindia I can't reproduce it anymore. I just updated to fix another bug when adding the receipt again. Please help to check again. Screen.Recording.2024-07-26.at.13.37.46.mp4 |
Contributor
Author
|
@thesahindia Friendly bump. |
Member
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-07-30.at.1.47.05.PM.movAndroid: mWeb ChromeScreen.Recording.2024-07-30.at.1.41.03.PM.moviOS: NativeScreen.Recording.2024-07-30.at.12.17.25.PM.moviOS: mWeb SafariScreen.Recording.2024-07-30.at.12.22.18.PM.movMacOS: Chrome / SafariScreen.Recording.2024-07-30.at.11.21.21.AM.movMacOS: DesktopScreen.Recording.2024-07-30.at.12.10.35.PM.mov |
techievivek
approved these changes
Jul 30, 2024
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
github-actions
Bot
added
the
DeployBlockerCash
Contributor
Performance Comparison Report 📊Significant Changes To Duration
Show details
Meaningless Changes To DurationShow entries
Show details
|
Contributor
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
Contributor
|
Note: it's unlikely this PR introduced the regression. The regression has been introduced earlier and thus all following PRs will run into the same regression. |
Contributor
|
True, I saw that here as well: #45961 (comment), but the percentage increase value is different. 😕 |
Contributor
|
yeah the tests are not producing the same results 100% of the time, as its depending on the devices condition, they can lead to different values, however, that still means that a regression was detected. |
Contributor
|
🚀 Deployed to staging by https://github.com/techievivek in version: 9.0.15-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.0.15-9 🚀
|
rojiphil
reviewed
Jun 12, 2025
| ...transaction, | ||
| filename: '', | ||
| receipt: { | ||
| source: '', |
Contributor
There was a problem hiding this comment.
Not resetting the receipt here caused an issue as mentioned in PR here. And we fixed this in the same PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Fixed Issues
$ #44000
PROPOSAL: #44000 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android.mov
Android: mWeb Chrome
android-mweb-resize.mp4
iOS: Native
ios.mov
iOS: mWeb Safari
ios-mweb.mp4
MacOS: Chrome / Safari
web.mp4
MacOS: Desktop
desktop.mov