Support EXPORTINTEGRATION actions#44930
Conversation
…t-integration-action
|
Asked for Spanish translations here. |
|
Pushed some changes to fix the text in the LHN. This is code complete but still blocked on review for spanish translations. I bumped again here. |
|
Rereviewing now 👀 |
|
🎯 @ishpaul777, thanks for reviewing and testing this PR! 🎉 An E/App issue has been created to issue payment here: #45489. |
…t-integration-action
|
typeschecks failing : ( @arosiclair |
|
There's a TS check failing @arosiclair |
|
Fixed it @youssef-lr |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/youssef-lr in version: 9.0.8-1 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/Beamanator in version: 9.0.8-3 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.0.8-6 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.0.9-5 🚀
|
Details
Adds better copy and support for
EXPORTINTEGRATIONactions so that their reimbursable URLs are displayed. Also supports pending export actions.Fixed Issues
Part of #44019
Tests
Prerequisites
Steps
Offline tests
None, offline exports will be tested in #43040
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps./** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop