Update the password label in Plaid VBA flow#4530
Merged
Merged
Conversation
Contributor
|
Chiming in here quickly - it looks like the select menu is missing a small label above the value: |
Contributor
Author
|
@shawnborton You are right! I have raised the issue in here, but that was a wrong place probably. The thing is that there was no label originally. What label would you propose for this select, or should I ask in #product? |
Contributor
|
I think it could simply say "Account" or "Choose account" - looks like @roryabraham also reported this. |
Contributor
Author
53 tasks
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
See the issue for more context.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/173525
$ #4548
Tests
How to test it locally: SO here.
Follow the
Log Into Your Bankflow inAdd Bank Account, login in through Plaid, selectPlaid Savingand make sure the password field saysEnter Expensify passwordif English is selected as your language.QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android