fix: [P2P Distance] Split - Participants amount displayed 0.00 briefly on confirmation screen. by Krishna2323 · Pull Request #47370 · Expensify/App

Krishna2323 · 2024-08-14T00:23:33Z

Details

Fixed Issues

$ #47100
PROPOSAL: #47100 (comment)

Tests

Open a group chat
Tap + > Split expense > Distance
Enter the start and finish viewpoints
Verify correct participants amounts are displayed without any delay

Verify that no errors appear in the JS console

Offline tests

Open a group chat
Tap + > Split expense > Distance
Enter the start and finish viewpoints
Verify correct participants amounts are displayed without any delay

QA Steps

Open a group chat
Tap + > Split expense > Distance
Enter the start and finish viewpoints
Verify correct participants amounts are displayed without any delay

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android_native.mp4

Android: mWeb Chrome

android_chrome.mp4

iOS: Native

ios_native.mp4

iOS: mWeb Safari

ios_safari.mp4

MacOS: Chrome / Safari

web_chrome.mp4

MacOS: Desktop

desktop_app.mp4

…y on confirmation screen. Signed-off-by: krishna2323 <belivethatkg@gmail.com>

melvin-bot · 2024-08-14T00:23:38Z

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 · 2024-08-18T10:51:57Z

@parasharrajat, while testing, I found a bug that is not related to our issue. Should we handle it in this PR, or is it better to open a new issue to avoid regressions?

BUG: When we start split a distance request with multiple participants and go back and change the participant to a policy, an error message is shown.The sum of splits must equal the total amount..

STEPS:

Start a split distance request.
Select waypoints and proceed
Select multiple participants (not policy) and proceed
Go back and remove all participants and select a workspace

Monosnap.screencast.2024-08-18.16-15-06.mp4

parasharrajat · 2024-08-18T11:04:11Z

@Krishna2323 Is this issue happening on staging?

Krishna2323 · 2024-08-18T11:12:02Z

@Krishna2323 Is this issue happening on staging?

Yes, I can reproduce on latest main without any changes.

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

parasharrajat · 2024-08-18T12:39:51Z

I see. So let's not solve it here.

parasharrajat · 2024-08-18T12:40:19Z

We can discuss this on the issue and ask to create a new PR for this.

Krishna2323 · 2024-08-20T14:08:09Z

@parasharrajat, do we need to update anything here?

Krishna2323 · 2024-08-22T17:39:46Z

@parasharrajat, friendly bump.

parasharrajat · 2024-08-22T18:02:26Z

@Krishna2323 I am currently in a priority task. I will take a look as soon as possible.

parasharrajat · 2024-08-28T19:50:09Z

@Krishna2323 Thanks for waiting. my availability was low last week. I will for sure review this tomorrow.

parasharrajat · 2024-08-30T13:09:30Z

@Krishna2323 Could you please merge main?

Krishna2323 · 2024-09-02T03:50:59Z

Merged main.

Krishna2323 · 2024-09-03T05:41:19Z

@parasharrajat bump.

parasharrajat · 2024-09-07T13:32:59Z

+    // Sets `amount` and `split` share data before moving to the next step to avoid briefly showing `0.00` as the split share for participants
+    const setDistanceRequestData = useCallback(
+        (isPolicyExpenseChat: boolean) => {
+            // Get policy report based on transaction participants
+            const policyReport = transaction?.participants?.[0] ? ReportUtils.getReport(selectedReportID.current) : report;
+
+            const policyID = IOU.getIOURequestPolicyID(transaction, policyReport);
+            const policy = PolicyUtils.getPolicy(report?.policyID ?? policyID);
+            const policyCurrency = policy?.outputCurrency ?? PolicyUtils.getPersonalPolicy()?.outputCurrency ?? CONST.CURRENCY.USD;
+
+            const customUnitRateID = TransactionUtils.getRateID(transaction) ?? '-1';
+            const mileageRates = DistanceRequestUtils.getMileageRates(policy);
+            const defaultMileageRate = DistanceRequestUtils.getDefaultMileageRate(policy);
+            const mileageRate: MileageRate = TransactionUtils.isCustomUnitRateIDForP2P(transaction)
+                ? DistanceRequestUtils.getRateForP2P(policyCurrency)
+                : mileageRates?.[customUnitRateID] ?? defaultMileageRate;
+
+            const {unit, rate} = mileageRate ?? {};
+            const distance = TransactionUtils.getDistanceInMeters(transaction, unit);
+            const currency = mileageRate?.currency ?? policyCurrency;
+            const amount = DistanceRequestUtils.getDistanceRequestAmount(distance, unit ?? CONST.CUSTOM_UNITS.DISTANCE_UNIT_MILES, rate ?? 0);
+            IOU.setMoneyRequestAmount(transactionID, amount, currency);
+
+            const participantAccountIDs: number[] | undefined = transaction?.participants?.map((participant) => participant.accountID ?? -1);
+            if (isSplitRequest && amount && currency && !isPolicyExpenseChat) {
+                IOU.setSplitShares(transaction, amount, currency ?? '', participantAccountIDs ?? []);
+            }
+        },
+        [report, transaction, transactionID, isSplitRequest],
+    );


Don't we have to remove the similar logic from IOURequestStepConfirmation page after we added it here?

@parasharrajat, yeah you are right. I was looking at the wrong code and thought that it should be there to avoid regressions but we have a similar logic which only runs once when the IOURequestStepConfirmation mounts.

I have removed the code on IOURequestStepConfirmation page, please check and let me know. Thanks

Krishna2323 · 2024-10-05T02:18:52Z

done.

Krishna2323 · 2024-10-07T04:25:08Z

@parasharrajat, any updates?

Krishna2323 · 2024-10-09T19:04:31Z

@parasharrajat, friendly bump.

Krishna2323 · 2024-10-11T14:24:13Z

@parasharrajat, can you please review this?

parasharrajat · 2024-10-12T05:43:51Z

@Krishna2323 I will have it completed tested by tomorrow.

parasharrajat

Please fix lint issues. merge main.

parasharrajat · 2024-10-14T16:25:50Z

+            const policyID2 = IOU.getIOURequestPolicyID(transaction, policyReport);
+            const policy2 = PolicyUtils.getPolicy(report?.policyID ?? policyID2);


what is policy2? Please rename it.

parasharrajat · 2024-10-15T09:37:11Z

@Krishna2323 I was checking and I am not able to reproduce the problem on main. Are you? can you please share a vid of same?

Krishna2323 · 2024-10-15T19:09:49Z

I was checking and I am not able to reproduce the problem on main. Are you? can you please share a vid of same?

@parasharrajat #47370 (comment).

parasharrajat · 2024-10-15T20:13:49Z

Oh, I see. But it does not cause a real user problem. let me discuss this on the issue.

parasharrajat

Lint issues.
Update Tests.

parasharrajat · 2024-10-15T20:38:10Z

Please let me know when done.

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 · 2024-10-15T20:59:59Z

@parasharrajat, test steps and lint issues are fixed.

parasharrajat · 2024-10-15T22:01:16Z

Screenshots

🔲 iOS / native

16.10.2024_03.21.58_REC.mp4

🔲 iOS / Safari

16.10.2024_03.22.56_REC.mp4

🔲 MacOS / Desktop

16.10.2024_03.30.26_REC.mp4

🔲 MacOS / Chrome

16.10.2024_03.00.07_REC.mp4

🔲 Android / Chrome

16.10.2024_03.29.33_REC.mp4

🔲 Android / native

16.10.2024_03.20.55_REC.mp4

parasharrajat · 2024-10-15T22:02:20Z

@Krishna2323 Your Offline tests are not correct. We don't see any amount while offline on the confirm page. Please fix that.

parasharrajat · 2024-10-15T22:02:36Z

I noticed that I wasn't able to create Split request while offline same as Staging.

parasharrajat

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

OSBotify · 2024-10-15T23:38:34Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-10-17T01:58:38Z

🚀 Deployed to staging by https://github.com/jasperhuangg in version: 9.0.50-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

lakchote · 2024-10-17T13:24:14Z

Reverted since contributor is not online to fix it (#51014)

Asked for CP here

cc @jasperhuangg @Krishna2323 @parasharrajat

github-actions · 2024-10-18T18:47:28Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.50-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

lakchote · 2024-10-21T08:17:53Z

I've created an un-revert PR that was CP'ed to staging.

fix: [P2P Distance] Split - Participants amount displayed 0.00 briefl…

cbc9815

…y on confirmation screen. Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 requested a review from a team as a code owner August 14, 2024 00:23

melvin-bot Bot requested a review from parasharrajat August 14, 2024 00:23

melvin-bot Bot removed the request for review from a team August 14, 2024 00:23

Krishna2323 marked this pull request as draft August 14, 2024 00:23

Krishna2323 added 4 commits August 16, 2024 15:22

Merge branch 'Expensify:main' into krishna2323/issue/47100

0d5d809

minor fixes.

377be13

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

minor update.

932a839

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

remove extra dependency.

99f37b3

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 marked this pull request as ready for review August 16, 2024 10:59

Krishna2323 mentioned this pull request Aug 16, 2024

[HOLD for payment 2024-10-25] [$250] [P2P Distance] Split - Participants amount displayed 0.00 briefly on confirmation screen #47100

Closed

6 tasks

parasharrajat suggested changes Aug 17, 2024

View reviewed changes

Comment thread src/pages/iou/request/step/IOURequestStepParticipants.tsx Outdated

Comment thread src/pages/iou/request/step/IOURequestStepParticipants.tsx Outdated

Comment thread src/pages/iou/request/step/IOURequestStepParticipants.tsx Outdated

add suggested changes.

5e894bd

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

parasharrajat reviewed Aug 18, 2024

View reviewed changes

Comment thread src/pages/iou/request/step/IOURequestStepParticipants.tsx Outdated

define type for mileageRate.

30e13cc

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Merge branch 'Expensify:main' into krishna2323/issue/47100

e9992b9

parasharrajat suggested changes Sep 7, 2024

View reviewed changes

Merge branch 'Expensify:main' into krishna2323/issue/47100

2558819

parasharrajat suggested changes Oct 14, 2024

View reviewed changes

parasharrajat reviewed Oct 14, 2024

View reviewed changes

parasharrajat suggested changes Oct 15, 2024

View reviewed changes

Merge branch 'Expensify:main' into krishna2323/issue/47100

dfad015

minor updates.

22ada28

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

parasharrajat approved these changes Oct 15, 2024

View reviewed changes

melvin-bot Bot requested a review from jasperhuangg October 15, 2024 22:02

jasperhuangg approved these changes Oct 15, 2024

View reviewed changes

jasperhuangg merged commit 5fc191c into Expensify:main Oct 15, 2024

github-actions Bot mentioned this pull request Oct 17, 2024

Deploy Checklist: New Expensify 2024-10-17 #50969

Closed

90 tasks

lakchote mentioned this pull request Oct 17, 2024

Split - When creating a Split expense the user is shown as Hidden #51003

Closed

8 tasks

		const policyID2 = IOU.getIOURequestPolicyID(transaction, policyReport);
		const policy2 = PolicyUtils.getPolicy(report?.policyID ?? policyID2);

Conversation

Krishna2323 commented Aug 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Aug 14, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Krishna2323 commented Aug 18, 2024

Uh oh!

parasharrajat commented Aug 18, 2024

Uh oh!

Uh oh!

Krishna2323 commented Aug 18, 2024

Uh oh!

parasharrajat commented Aug 18, 2024

Uh oh!

parasharrajat commented Aug 18, 2024

Uh oh!

Krishna2323 commented Aug 20, 2024

Uh oh!

Krishna2323 commented Aug 22, 2024

Uh oh!

parasharrajat commented Aug 22, 2024

Uh oh!

parasharrajat commented Aug 28, 2024

Uh oh!

parasharrajat commented Aug 30, 2024

Uh oh!

Krishna2323 commented Sep 2, 2024

Uh oh!

Krishna2323 commented Sep 3, 2024

Uh oh!

parasharrajat Sep 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Krishna2323 Sep 9, 2024

Choose a reason for hiding this comment

Uh oh!

Krishna2323 commented Oct 5, 2024

Uh oh!

Krishna2323 commented Oct 7, 2024

Uh oh!

Krishna2323 commented Oct 9, 2024

Uh oh!

Krishna2323 commented Oct 11, 2024

Uh oh!

parasharrajat commented Oct 12, 2024

Uh oh!

parasharrajat left a comment

Choose a reason for hiding this comment

Uh oh!

parasharrajat Oct 14, 2024

Choose a reason for hiding this comment

Uh oh!

parasharrajat commented Oct 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Krishna2323 commented Oct 15, 2024

Uh oh!

parasharrajat commented Oct 15, 2024

Uh oh!

parasharrajat left a comment

Choose a reason for hiding this comment

Uh oh!

parasharrajat commented Oct 15, 2024

Uh oh!

Krishna2323 commented Oct 15, 2024

Uh oh!

parasharrajat commented Oct 15, 2024

Screenshots

Krishna2323 commented Aug 14, 2024 •

edited

Loading

parasharrajat Sep 7, 2024 •

edited

Loading

parasharrajat commented Oct 15, 2024 •

edited

Loading

lakchote commented Oct 21, 2024 •

edited

Loading