Skip to content

[CP Staging] Revert "fix: [P2P Distance] Split - Participants amount displayed 0.00 briefly on confirmation screen."#51014

Merged
MarioExpensify merged 1 commit into
mainfrom
revert-47370-krishna2323/issue/47100
Oct 17, 2024
Merged

[CP Staging] Revert "fix: [P2P Distance] Split - Participants amount displayed 0.00 briefly on confirmation screen."#51014
MarioExpensify merged 1 commit into
mainfrom
revert-47370-krishna2323/issue/47100

Conversation

@lakchote

@lakchote lakchote commented Oct 17, 2024

Copy link
Copy Markdown
Contributor

Reverts blocker #51003

@lakchote lakchote self-assigned this Oct 17, 2024
@lakchote lakchote requested a review from a team as a code owner October 17, 2024 13:00
@melvin-bot melvin-bot Bot requested a review from MarioExpensify October 17, 2024 13:00
@melvin-bot

melvin-bot Bot commented Oct 17, 2024

Copy link
Copy Markdown

@MarioExpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot Bot removed the request for review from a team October 17, 2024 13:00
@MarioExpensify MarioExpensify merged commit ee384b0 into main Oct 17, 2024
@MarioExpensify MarioExpensify deleted the revert-47370-krishna2323/issue/47100 branch October 17, 2024 13:18
@melvin-bot

melvin-bot Bot commented Oct 17, 2024

Copy link
Copy Markdown

@MarioExpensify looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@melvin-bot melvin-bot Bot added the Emergency label Oct 17, 2024
@lakchote

lakchote commented Oct 17, 2024

Copy link
Copy Markdown
Contributor Author

Not an emergency. It's a straight revert.

@lakchote lakchote mentioned this pull request Oct 17, 2024
Merged
50 tasks
@OSBotify

OSBotify commented Oct 17, 2024

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify pushed a commit that referenced this pull request Oct 17, 2024
@MarioExpensify @OSBotify
Merge pull request #51014 from Expensify/revert-47370-krishna2323/iss…
8f508df 
…ue/47100

[CP Staging] Revert "fix: [P2P Distance] Split - Participants amount displayed 0.00 briefly on confirmation screen."

(cherry picked from commit ee384b0)

(CP triggered by mountiny)
@github-actions github-actions Bot added the CP Staging marks PRs that have been CP'd to staging label Oct 17, 2024
@github-actions github-actions Bot mentioned this pull request Oct 17, 2024
Closed
90 tasks
@github-actions

github-actions Bot commented Oct 17, 2024

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.0.50-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@github-actions

github-actions Bot commented Oct 18, 2024

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.50-8 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@lakchote lakchote mentioned this pull request Oct 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@MarioExpensify MarioExpensify MarioExpensify approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lakchote lakchote

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lakchote @OSBotify @MarioExpensify