[CP Staging] Fix exporter payload by aldo-expensify · Pull Request #49818 · Expensify/App

aldo-expensify · 2024-09-26T21:01:54Z

Details

Fixes regression introduced here: https://github.com/Expensify/App/pull/48080/files#diff-afb3647e9a1c6b4d00a7047f997bffa23c873bbd6807e726807f48ebef608bcaR57

The backend is really expecting the export.exporter value, and not JSON encoded:

https://github.com/Expensify/Web-Expensify/blob/d79638859720da369cd154bbe46c13e31e26691a/api.php#L2299-L2300

Before:

After:

Fixed Issues

$ #49797
PROPOSAL:

Tests

Navigate to Accounting
Click on Export
Click Preferred Exporter
Select the unchecked workspace admin
Wait for the connection to sync and check the preferred exporter
Confirm that after the sync finishes: the newly selected exporter is displayed with a checkmark and stays selected

Verify that no errors appear in the JS console

Offline tests

QA Steps

Navigate to Accounting
Click on Export
Click Preferred Exporter
Select the unchecked workspace admin
Wait for the connection to sync and check the preferred exporter
Confirm that after the sync finishes: the newly selected exporter is displayed with a checkmark and stays selected

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2024-09-26.at.2.05.01.PM.mov

MacOS: Desktop

aldo-expensify · 2024-09-26T21:09:04Z

There are some unrelated typechecks failing:

Error: src/languages/en.ts(4870,29): error TS1360: Type '{ common: { cancel: string; dismiss: string; yes: string; no: string; ok: string; notNow: string; learnMore: string; buttonConfirm: string; name: string; attachment: string; attachments: string; center: string; ... 224 more ...; rename: string; }; ... 173 more ...; debug: { ...; }; }' does not satisfy the expected type 'TranslationDeepObject<{ common: { cancel: string; dismiss: string; yes: string; no: string; ok: string; notNow: string; learnMore: string; buttonConfirm: string; name: string; attachment: string; attachments: string; center: string; ... 224 more ...; rename: string; }; ... 173 more ...; debug: { ...; }; }>'.
  The types of 'delegate.onBehalfOfMessage' are incompatible between these types.
    Type '(delegator: string) => string' is not assignable to type '(arg: Record<string, unknown>, ...noOtherArguments: unknown[]) => string | PluralForm'.
      Types of parameters 'delegator' and 'arg' are incompatible.
        Type 'Record<string, unknown>' is not assignable to type 'string'.
Error: src/languages/es.ts(5390,29): error TS[13](https://github.com/Expensify/App/actions/runs/11060184316/job/30730186656?pr=49818#step:4:14)60: Type '{ common: { cancel: string; dismiss: string; yes: string; no: string; ok: string; notNow: string; learnMore: string; buttonConfirm: string; name: string; attachment: string; attachments: string; from: string; ... 224 more ...; days: string; }; ... 173 more ...; debug: { ...; }; }' does not satisfy the expected type 'TranslationDeepObject<{ common: { cancel: string; dismiss: string; yes: string; no: string; ok: string; notNow: string; learnMore: string; buttonConfirm: string; name: string; attachment: string; attachments: string; center: string; ... 224 more ...; rename: string; }; ... 173 more ...; debug: { ...; }; }>'.
  The types of 'delegate.onBehalfOfMessage' are incompatible between these types.
    Type '(delegator: string) => string' is not assignable to type '(arg: Record<string, unknown>, ...noOtherArguments: unknown[]) => string | PluralForm'.
      Types of parameters 'delegator' and 'arg' are incompatible.
        Type 'Record<string, unknown>' is not assignable to type 'string'.

melvin-bot · 2024-09-26T21:09:10Z

@jayeshmangwani Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

aldo-expensify · 2024-09-26T21:15:35Z

Pushed main again to try to fix the typescript error

mananjadhav · 2024-09-26T23:26:10Z

Testing this.

aldo-expensify · 2024-09-26T23:28:14Z

Pushed main to fix the typecheck error

mananjadhav · 2024-09-26T23:49:28Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android-qbo-export.mov

Android: mWeb Chrome

mweb-chrome-qbo-export.mov

iOS: Native

ios-qbo-export.mov

iOS: mWeb Safari

mweb-safari-qbo-export.mov

MacOS: Chrome / Safari

web-qbo-export.mov

MacOS: Desktop

desktop-qbo-export.mov

mananjadhav

Changes are working fine. Left with only Android, build is running.

melvin-bot · 2024-09-26T23:51:12Z

@srikarparsi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mananjadhav · 2024-09-26T23:58:10Z

@aldo-expensify Android screencast also uploaded.

aldo-expensify · 2024-09-27T00:34:06Z

Requested CP: https://expensify.slack.com/archives/C07J32337/p1727397232865279

OSBotify · 2024-09-27T00:42:10Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Fix exporter payload (cherry picked from commit 1a3b84e) (CP triggered by marcaaron)

github-actions · 2024-09-27T01:23:20Z

🚀 Cherry-picked to staging by https://github.com/marcaaron in version: 9.0.40-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

aldo-expensify · 2024-09-27T01:26:41Z

QA passed:

Screen.Recording.2024-09-26.at.6.25.38.PM.mov

github-actions · 2024-09-27T17:46:30Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.0.40-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Fix exporter payload

ee68279

aldo-expensify self-assigned this Sep 26, 2024

aldo-expensify mentioned this pull request Sep 26, 2024

QBO – Unable to change preferred exporter in QBO connection #49797

Closed

6 tasks

aldo-expensify marked this pull request as ready for review September 26, 2024 21:09

aldo-expensify requested a review from a team as a code owner September 26, 2024 21:09

melvin-bot Bot requested review from jayeshmangwani and removed request for a team September 26, 2024 21:09

Merge branch 'main' of github.com:Expensify/App into aldo_fix-exporter

e7b82ab

aldo-expensify requested review from rushatgabhane and removed request for jayeshmangwani September 26, 2024 21:15

Beamanator approved these changes Sep 26, 2024

View reviewed changes

Merge branch 'main' of github.com:Expensify/App into aldo_fix-exporter

270f24e

aldo-expensify requested review from mananjadhav and removed request for rushatgabhane September 26, 2024 23:27

mananjadhav approved these changes Sep 26, 2024

View reviewed changes

melvin-bot Bot requested a review from srikarparsi September 26, 2024 23:51

aldo-expensify changed the title ~~Fix exporter payload~~ [CP Staging] Fix exporter payload Sep 27, 2024

aldo-expensify merged commit 1a3b84e into main Sep 27, 2024

aldo-expensify deleted the aldo_fix-exporter branch September 27, 2024 00:32

OSBotify pushed a commit that referenced this pull request Sep 27, 2024

Merge pull request #49818 from Expensify/aldo_fix-exporter

fb97c58

Fix exporter payload (cherry picked from commit 1a3b84e) (CP triggered by marcaaron)

github-actions Bot added the CP Staging marks PRs that have been CP'd to staging label Sep 27, 2024

github-actions Bot mentioned this pull request Sep 27, 2024

Deploy Checklist: New Expensify 2024-09-24 #49662

Closed

67 tasks

Conversation

aldo-expensify commented Sep 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

aldo-expensify commented Sep 26, 2024

Uh oh!

melvin-bot Bot commented Sep 26, 2024

Uh oh!

aldo-expensify commented Sep 26, 2024

Uh oh!

mananjadhav commented Sep 26, 2024

Uh oh!

aldo-expensify commented Sep 26, 2024

Uh oh!

mananjadhav commented Sep 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

mananjadhav left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Sep 26, 2024

Uh oh!

mananjadhav commented Sep 26, 2024

Uh oh!

aldo-expensify commented Sep 27, 2024

Uh oh!

OSBotify commented Sep 27, 2024

Uh oh!

github-actions Bot commented Sep 27, 2024

Uh oh!

aldo-expensify commented Sep 27, 2024

Uh oh!

github-actions Bot commented Sep 27, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

aldo-expensify commented Sep 26, 2024 •

edited

Loading

mananjadhav commented Sep 26, 2024 •

edited

Loading