Skip to content

[No QA] Add a line to PR template to emphasis the format of issue linking#5217

Merged
Beamanator merged 1 commit into
mainfrom
vit-updateReadme
Sep 13, 2021
Merged

[No QA] Add a line to PR template to emphasis the format of issue linking#5217
Beamanator merged 1 commit into
mainfrom
vit-updateReadme

Conversation

@mountiny

Copy link
Copy Markdown
Contributor

Details

Simple change in PR template. We see many contributors linking issues to their PR using a following format $ #1234. To emphasize this format is not allowed at the moment, we are adding a line to the PR template to increase chances contributor will notice.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/177275

Tests

QA Steps

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@mountiny mountiny requested a review from Beamanator September 13, 2021 08:33
@mountiny mountiny self-assigned this Sep 13, 2021
@mountiny mountiny requested a review from a team as a code owner September 13, 2021 08:33
@MelvinBot MelvinBot requested review from iwiznia and removed request for a team September 13, 2021 08:34

@Beamanator Beamanator left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@Beamanator Beamanator merged commit 3b62d29 into main Sep 13, 2021
@Beamanator Beamanator deleted the vit-updateReadme branch September 13, 2021 12:03
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @Beamanator in version: 1.0.97-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @francoisl in version: 1.0.98-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants