Rename route so that we expect traditional query paramters

[TomatoToaster]

@cead22, please review

All we need to do here is change the route and the query params pulled from here are expected to come after ?.

These lines essentially work the same, it just won't look inbetween the slashes for the params:

App/src/pages/LogInWithShortLivedTokenPage.js

Lines 51 to 54 in 269697b

	const accountID = parseInt(lodashGet(this.props.route.params, 'accountID', ''), 10);
	const email = lodashGet(this.props.route.params, 'email', '');
	const shortLivedToken = lodashGet(this.props.route.params, 'shortLivedToken', '');
	const encryptedAuthToken = lodashGet(this.props.route.params, 'encryptedAuthToken', '');

Details

Discussion from here: https://expensify.slack.com/archives/C020EPP9B9A/p1632347607474000
related to this PR: https://github.com/Expensify/Web-Expensify/pull/31996
and this issue: https://github.com/Expensify/Expensify/issues/177739

Tests

QA Steps

Same as here: #5396, but now it should actually work.
@MitchExpensify and @kevinksullivan will be testing this so QA team can skip over this one 👍🏾

Flow 1: Unvalidated new accounts

1. Create a new account in OldDot that has access to the freePlan beta.

2. Go to settings -> policy -> group and select the free plan here:
   

3. Verify that a new tab opens and you are logged into NewDot and you are seeing the Workspace Settings page for a newly created Workspace:
   

4. Wait a minute

5. Do any action (like add a comment)

6. Check you are not logged out

Flow 2: Existing accounts

1. Log into an account on NewDot Expensify, create a Workspace if you don't already have one using the + on the bottom right.
2. Log out of NewDot and then log into that same account on OldDot and go to Settings -> Policy and find your Workspace there. It should have a card icon like these:
   
3. Click on its name and verify it opens a new tab, automatically logs you in, and brings you to the workspace settings page:
   
4. Wait a minute
5. Do any action (like add a comment)
6. Check you are not logged out

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

N/A

[github-actions]

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

[cead22]

These lines essentially work the same, it just won't look inbetween parentheses for the params:

I'm assuming you means slashes, not parenthesis 👍

[TomatoToaster]

Ah sorry yes I meant in between the slashes 😄

[TomatoToaster]

Could you review again @cead22 @thienlnam, I realized I should change this log line: https://github.com/Expensify/App/pull/5430/files#diff-c3d3bf8bc4056d8f2e8ff15f6d72d7e81656cd36c30a202a084c50dda1dff582L35

since the route changed and we still don't want to be storing the authToken in the log lines.

[OSBotify]

🚀 Cherry-picked to staging by @TomatoToaster in version: 1.1.1-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

[MitchExpensify]

• Flow 1 on desktop
• Flow 2 on desktop

[OSBotify]

🚀 Deployed to production by @Jag96 in version: 1.1.1-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to staging by @TomatoToaster in version: 1.1.1-9 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by @timszot in version: 1.1.2-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅