Skip to content

Rename route so that we expect traditional query paramters #5430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomatoToaster merged 3 commits into from
Sep 23, 2021
Merged

Rename route so that we expect traditional query paramters #5430

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7f7611d
Rename route so that we expect traditional query paramters (i.e. afte…
Sep 22, 2021
623486f
Merge branch 'main' of github.com:Expensify/App into amal-query-param…
Sep 23, 2021
434584e
Changing log line condition so we don't log the authToken in the quer…
Sep 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ROUTES.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ export default {
getReportDetailsRoute: reportID => `r/${reportID}/details`,
VALIDATE_LOGIN: 'v',
VALIDATE_LOGIN_WITH_VALIDATE_CODE: 'v/:accountID/:validateCode',
LOGIN_WITH_SHORT_LIVED_TOKEN: 'transition/:accountID/:email/:shortLivedToken/:encryptedAuthToken/:exitTo',
LOGIN_WITH_SHORT_LIVED_TOKEN: 'transition',

// This is a special validation URL that will take the user to /workspace/new after validation. This is used
// when linking users from e.com in order to share a session in this app.
Expand Down
2 changes: 1 addition & 1 deletion src/libs/Navigation/NavigationRoot.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ class NavigationRoot extends Component {
const path = getPathFromState(state, linkingConfig.config);

// Don't log the route transitions from OldDot because they contain authTokens
if (path.includes('/transition/')) {
if (path.includes('/transition')) {
Log.info('Navigating from transition link from OldDot using short lived authToken');
} else {
Log.info('Navigating to route', false, {path});
Expand Down