Use correct api params for NewDot>OldDot links

[marcaaron]

Details

Looks like we changed the GetShortLivedAuthToken command to just return shortLivedAuthToken and encryptedAuthToken but didn't consider the change for NewDot > OldDot links.

Fixed Issues

#5359 (comment)

Tests

To test this I just quickly applied this diff and then tapped on manage cards (I don't have this set up on dev but I think it will work fine). Without the other changes we get the undefined stuff.

diff --git a/src/pages/workspace/WorkspaceCardPage.js b/src/pages/workspace/WorkspaceCardPage.js
index 4eee5d7f9..386c5a66e 100644
--- a/src/pages/workspace/WorkspaceCardPage.js
+++ b/src/pages/workspace/WorkspaceCardPage.js
@@ -100,13 +100,13 @@ const WorkspaceCardPage = ({
     }

     const onPress = () => {
-        if (user.isFromPublicDomain) {
-            openSignedInLink(CONST.ADD_SECONDARY_LOGIN_URL);
-        } else if (user.isUsingExpensifyCard) {
+        // if (user.isFromPublicDomain) {
+        //     openSignedInLink(CONST.ADD_SECONDARY_LOGIN_URL);
+        // } else if (user.isUsingExpensifyCard) {
             openSignedInLink(CONST.MANAGE_CARDS_URL);
-        } else {
-            openBankSetupModal();
-        }
+        // } else {
+        //     openBankSetupModal();
+        // }
     };

QA Steps

Repeat steps in #5359 (comment)

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

[github-actions]

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

[cead22]

I reproduced without this fix, and couldn't reproduce with this fix

[Jag96]

LGTM, good find!

[Jag96]

LGTM

[Jag96]

Skipping unnecessary e2e to get this to staging

[OSBotify]

🚀 Cherry-picked to staging by @Jag96 in version: 1.1.1-7 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

[OSBotify]

🚀 Deployed to production by @Jag96 in version: 1.1.1-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to staging by @Jag96 in version: 1.1.1-9 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by @timszot in version: 1.1.2-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅