[UX Reliability] Use new modal in `BaseReportActionContextMenu` by BartoszGrajdek · Pull Request #56606 · Expensify/App

BartoszGrajdek · 2025-02-10T14:52:09Z

Explanation of Change

We've decided to refactor the react-native-bottom-modal code so that it utilizes react-native-reanimated, our goal was to improve FPS, remove the outdated library and gradually switch to the new solution. This PR enables the new solution in BaseReportActionContextMenu.

Fixed Issues

$ #49354

Tests

I think testing should go like this:

Open the modal.
Close it by clicking the backdrop.
Open the modal.
Close it through the "back" button if it exists on your device.
Open the modal.
Go through each button/option in that modal and verify that everything's functioning properly.

To open the modal you need to:

Open any chat
Send a message
Long-press on the message you've sent

Offline tests

Same as above, but it shouldn't matter

QA Steps

Same as above

PR Author Checklist

Screenshots/Videos

Android: Native

Android.mov

Android: mWeb Chrome

Android.-.mWeb.mov

iOS: Native

iOS.mov

iOS: mWeb Safari

iOS.-.mWeb.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

…dit-modal

melvin-bot · 2025-03-04T13:57:23Z

@shawnborton @ZhenjaHorbach One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

blazejkustra · 2025-03-04T14:12:08Z

@ZhenjaHorbach I'll be handling this PR, so if anything comes up, please let me know!

shawnborton · 2025-03-04T15:14:11Z

Looks like the popover launches in the wrong spot on web for a split second:

ZhenjaHorbach · 2025-03-04T15:45:32Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screenrecorder-2025-03-29-08-46-01-658.mp4

Android: mWeb Chrome

Screenrecorder-2025-03-29-08-50-23-240.mp4

iOS: Native

2025-03-29.08.55.40.mp4

iOS: mWeb Safari

2025-03-29.08.55.37.mp4

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

ZhenjaHorbach · 2025-03-04T15:47:25Z

Looks like the popover launches in the wrong spot on web for a split second:

Confirm !
I also sometimes have this bug

ZhenjaHorbach · 2025-03-04T15:55:32Z

Also looks like a bug
That we have animation after changing the size of the modal

2025-03-04.16.54.42.mov

ZhenjaHorbach · 2025-03-04T16:06:14Z

On Ios-web and Android-web I have a mini context menu

blazejkustra · 2025-03-05T14:56:49Z

I'll come back to this later this week or next week as I have projects with higher priority, sorry!

shawnborton · 2025-03-25T11:51:33Z

Any update here?

ZhenjaHorbach · 2025-03-25T15:31:38Z

I suppose we will continue to work on this soon !

#49354 (comment)

…new-edit-modal

blazejkustra · 2025-03-28T13:47:53Z

Looks like the popover launches in the wrong spot on web for a split second:

Confirm ! I also sometimes have this bug

@ZhenjaHorbach Could you retest? I can't reproduce this

blazejkustra · 2025-03-28T13:58:53Z

Also looks like a bug That we have animation after changing the size of the modal

2025-03-04.16.54.42.mov

Same with this, looks like it works correct now @ZhenjaHorbach

ZhenjaHorbach · 2025-03-28T14:17:13Z

Sure !
I will recheck soon !

blazejkustra · 2025-03-28T14:34:17Z

On Ios-web and Android-web I have a mini context menu

@ZhenjaHorbach Should be fixed as well

blazejkustra · 2025-03-28T14:35:55Z

Bear in mind that we are only migrating modals of type bottom_docked:

Popovers shouldn't be affected at all:

ZhenjaHorbach · 2025-03-28T14:46:49Z

Remove unused import from BaseReportActionContextMenu

Actually this issue is similar to this

#58705

ZhenjaHorbach · 2025-03-29T07:58:45Z

LGTM !

ZhenjaHorbach · 2025-03-29T08:09:48Z

But wait
On real device notice this
And this is not reproduced in simulators

2025-03-29.09.08.12.mp4

mountiny · 2025-03-30T23:09:29Z

@blazejkustra can you please check that out? Thanks!

blazejkustra · 2025-03-31T12:43:54Z

Is this iOS? What browser are you using?@ZhenjaHorbach

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-03-31.at.14.42.52.mp4

mountiny · 2025-03-31T12:46:02Z

seems like normal safari to me

ZhenjaHorbach · 2025-03-31T12:50:28Z

Yes
It's a default safari !

blazejkustra · 2025-03-31T14:44:30Z

I can’t reproduce it 😢

Could you write out the detailed steps? I want to make sure I’m doing it the same way. Also, could you let me know which iPhone model you’re using, the iOS version, and the version of Safari? That’ll help a lot—thanks! @ZhenjaHorbach

ZhenjaHorbach · 2025-03-31T14:56:40Z

I can’t reproduce it 😢

Could you write out the detailed steps? I want to make sure I’m doing it the same way. Also, could you let me know which iPhone model you’re using, the iOS version, and the version of Safari? That’ll help a lot—thanks! @ZhenjaHorbach

Hmmm, good question.
Could you try using a video message for testing?

First, tap on the input.
Then, hold down the video to open a modal.
Next, tap outside the modal window to close it.
Repeat this several times.

I just tested it, and it works for me!

blazejkustra · 2025-03-31T15:10:19Z

I just tested it, and it works for me!

Wait - you mean it doesn't work for you when following these steps, right? 😆

First, tap on the input.
Then, hold down the video to open a modal.
Next, tap outside the modal window to close it.
Repeat this several times.

Still no luck, tried several times:

ScreenRecording_03-31-2025.17-05-38_1.MP4

could you let me know which iPhone model you’re using, the iOS version, and the version of Safari?

@ZhenjaHorbach bump 😄

blazejkustra · 2025-03-31T15:15:31Z

@mountiny Can you try? 😂 56606.pr-testing.expensify.com

ZhenjaHorbach · 2025-03-31T15:25:12Z

Wait - you mean it doesn't work for you when following these steps, right?

It reproduces stably for me following these steps 😅

could you let me know which iPhone model you’re using, the iOS version, and the version of Safari?

Oh
Sorry
I have iPhone 13 18.3.1 (18.4 - the same issue)

ZhenjaHorbach · 2025-03-31T16:23:34Z

By the way, I also have Chrome on my iPhone
I can also reproduce

And I can reproduce with any message

2025-03-31.18.25.35.mp4

blazejkustra · 2025-04-01T09:16:53Z

@mountiny @ZhenjaHorbach I asked two other team mates and they also can't reproduce:

ScreenRecording_04-01-2025.11-07-10_1.MP4

ScreenRecording_04-01-2025.11-10-48_1.MP4

blazejkustra · 2025-04-01T09:17:40Z

How about we ask QA for help? They have a talent for breaking the app, so maybe they have more luck with this 😅

ZhenjaHorbach · 2025-04-01T09:54:47Z

How about we ask QA for help? They have a talent for breaking the app, so maybe they have more luck with this 😅

Agree
Or at least create a separate issue to no block this PR !
And if it's just me who has this issue, then this issue will simply close!

mountiny · 2025-04-01T10:28:41Z

I cannot reproduce either, although one thing to look into that does not look nice on mweb is the top of the screen having a break in the background colour as the modal is opened and closed.

ScreenRecording_04-01-2025.12-22-56_1.mp4

mountiny

Changes look good to me, just gonna wait for @shawnborton sign off

ZhenjaHorbach · 2025-04-01T10:40:31Z

I cannot reproduce either, although one thing to look into that does not look nice on mweb is the top of the screen having a break in the background colour as the modal is opened and closed.

ScreenRecording_04-01-2025.12-22-56_1.mp4

The same issue is in staging
So I think we can skip this issue in this PR

shawnborton · 2025-04-01T14:55:57Z

Tested on my iPhone and this feels really nice to me. I think we're probably good to merge, cc @Expensify/design for viz

mountiny · 2025-04-01T21:35:41Z

Lets test this out in staging then, thank you!

OSBotify · 2025-04-01T21:43:39Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-04-03T16:10:09Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.23-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-04-07T20:30:52Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.23-7 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

BartoszGrajdek added 6 commits February 10, 2025 15:47

feat: enable new modal in report action context menu

9d21c42

fix: slide out animation not appearing

4cb6e96

fix: eslint issues

59900cf

fix: type mismatch

4e65f7d

Merge remote-tracking branch 'origin/main' into @BartoszGrajdek/new-e…

31b78ca

…dit-modal

Merge remote-tracking branch 'origin/main' into @BartoszGrajdek/new-e…

82e2740

…dit-modal

BartoszGrajdek marked this pull request as ready for review March 4, 2025 13:57

BartoszGrajdek requested a review from a team as a code owner March 4, 2025 13:57

melvin-bot Bot requested review from ZhenjaHorbach and shawnborton and removed request for a team March 4, 2025 13:57

Merge branch 'main' of github.com:Expensify/App into @BartoszGrajdek/…

39323cb

…new-edit-modal

Remove unused import from BaseReportActionContextMenu

8a310f2

Hide context menu on mobile

3ff53eb

mountiny self-requested a review March 28, 2025 23:12

ZhenjaHorbach approved these changes Mar 29, 2025

View reviewed changes

mountiny approved these changes Apr 1, 2025

View reviewed changes

mountiny merged commit 96f0172 into Expensify:main Apr 1, 2025

github-actions Bot mentioned this pull request Apr 3, 2025

Deploy Checklist: New Expensify 2025-04-03 #59590

Closed

86 tasks

daledah mentioned this pull request Apr 3, 2025

[Due for payment 2025-04-16] [Due for payment 2025-04-14] [$250] iOS - URL under "Copy URL to clipboard" text disappears when the modal is dismissing #59615

Closed

8 tasks

melvin-bot Bot mentioned this pull request Apr 7, 2025

[UX Reliability] Improve the bottom modal animations quality and reliability on native and mWeb platforms #49354

Closed

thelullabyy mentioned this pull request Apr 8, 2025

[Due for payment 2025-04-17] [Due for payment 2025-04-16] Android - Device back button is not responsive after closing context menu #59769

Closed

8 tasks

Conversation

BartoszGrajdek commented Feb 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Mar 4, 2025

Uh oh!

blazejkustra commented Mar 4, 2025

Uh oh!

shawnborton commented Mar 4, 2025

Uh oh!

ZhenjaHorbach commented Mar 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ZhenjaHorbach commented Mar 4, 2025

Uh oh!

ZhenjaHorbach commented Mar 4, 2025

Uh oh!

ZhenjaHorbach commented Mar 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

blazejkustra commented Mar 5, 2025

Uh oh!

shawnborton commented Mar 25, 2025

Uh oh!

ZhenjaHorbach commented Mar 25, 2025

Uh oh!

blazejkustra commented Mar 28, 2025

Uh oh!

blazejkustra commented Mar 28, 2025

Uh oh!

ZhenjaHorbach commented Mar 28, 2025

Uh oh!

blazejkustra commented Mar 28, 2025

Uh oh!

blazejkustra commented Mar 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ZhenjaHorbach commented Mar 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ZhenjaHorbach commented Mar 29, 2025

Uh oh!

ZhenjaHorbach commented Mar 29, 2025

Uh oh!

mountiny commented Mar 30, 2025

Uh oh!

blazejkustra commented Mar 31, 2025

Uh oh!

mountiny commented Mar 31, 2025

Uh oh!

ZhenjaHorbach commented Mar 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

blazejkustra commented Mar 31, 2025

Uh oh!

ZhenjaHorbach commented Mar 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

blazejkustra commented Mar 31, 2025

Uh oh!

blazejkustra commented Mar 31, 2025

Uh oh!

ZhenjaHorbach commented Mar 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ZhenjaHorbach commented Mar 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

blazejkustra commented Apr 1, 2025

Uh oh!

blazejkustra commented Apr 1, 2025

BartoszGrajdek commented Feb 10, 2025 •

edited

Loading

ZhenjaHorbach commented Mar 4, 2025 •

edited

Loading

ZhenjaHorbach commented Mar 4, 2025 •

edited

Loading

blazejkustra commented Mar 28, 2025 •

edited

Loading

ZhenjaHorbach commented Mar 28, 2025 •

edited

Loading

ZhenjaHorbach commented Mar 31, 2025 •

edited

Loading

ZhenjaHorbach commented Mar 31, 2025 •

edited

Loading

ZhenjaHorbach commented Mar 31, 2025 •

edited

Loading

ZhenjaHorbach commented Mar 31, 2025 •

edited

Loading

ZhenjaHorbach commented Apr 1, 2025 •

edited

Loading