fix: emoji picker jumps when open keyboard#59214
Conversation
|
@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
Screenshots/Videos
Android: Native
Screen.Recording.2025-03-31.at.19.55.19.mov
Android: mWeb Chrome
Screen.Recording.2025-03-31.at.17.32.52.mov
iOS: Native
Screen.Recording.2025-03-31.at.20.35.16.mov
iOS: mWeb Safari
Screen.Recording.2025-03-31.at.17.41.58.mov
MacOS: Chrome / Safari
Screen.Recording.2025-03-31.at.17.35.45.mov
MacOS: Desktop
|
@daledah The issue is still reproducible in android native. |
|
Even on iOS, the change in height is quite noticeable. |
|
@sobitneupane Is there any additional conditions? I tried multiple times and did not see the issue Screen.Recording.2025-04-03.at.02.56.17.mov |
Nope. @daledah Could you please try it in Android Native? The issue is quite noticeable in android and is also noticeable in the screen recording attached to the PR. |
|
@sobitneupane I can't reproduce the bug in main anymore, seems like #59539 has fixed this issue. Can you help confirm please? |
|
@daledah Seems like it. I couldn’t reproduce the issue on iOS native. Unfortunately, I wasn’t able to test it on Android due to some build errors. Could you please check it on your end for Android? Screen.Recording.2025-04-09.at.21.46.01.mov |
|
@sobitneupane Here's the latest main results on Android: Screen.Recording.2025-04-10.at.15.55.56.movScreen.Recording.2025-04-10.at.15.58.07.mov |
Explanation of Change
Fixed Issues
$ #58331
PROPOSAL: #58331 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2025-03-28.at.15.19.59.mov
Android: mWeb Chrome
Screen.Recording.2025-03-27.at.19.52.56.mov
iOS: Native
Screen.Recording.2025-03-27.at.19.53.09.mov
iOS: mWeb Safari
Screen.Recording.2025-03-28.at.15.22.49.mov
MacOS: Chrome / Safari
Screen.Recording.2025-03-27.at.19.55.00.mov
MacOS: Desktop
Screen.Recording.2025-03-27.at.19.55.13.mov