[UX Reliability] Use new modal in EmojiPicker by blazejkustra · Pull Request #59539 · Expensify/App

blazejkustra · 2025-04-02T14:05:09Z

Explanation of Change

We've decided to refactor the react-native-bottom-modal code so that it utilizes react-native-reanimated, our goal was to improve FPS, remove the outdated library and gradually switch to the new solution. This PR enables the new solution in EmojiPicker.

Fixed Issues

$ #49354

Tests

I think testing should go like this:

Open the modal.
Close it by clicking the backdrop.
Open the modal.
Close it through the "back" button if it exists on your device.
Open the modal.
Go through each button/option in that modal and verify that everything's functioning properly.

To open the modal you need to:

Open any chat
Click emoji button in the composer

You can also reach it through message reactions like so:

Long press on a message in chat
In the reaction list you should see smiley face with "+" next to it to see more emojis - click it

Offline tests

Same as above, but it shouldn't matter

QA Steps

Same as above

PR Author Checklist

Screenshots/Videos

Android: Native

Android.mov

Android: mWeb Chrome

Android.mWeb.mov

iOS: Native

iOS.mov

iOS: mWeb Safari

iOS.mWeb.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

…moji-modal

…new-emoji-modal

blazejkustra · 2025-04-02T14:15:53Z

FYI @ZhenjaHorbach — there's a visible jump when the keyboard opens or closes. This affects both Android and iOS. It already happens on main as well. I tried to fix it today but it is not trival (height logic around emoji modal is complex).

I think we should fix it ina follow up PR, thoughts? @mountiny

edit: actually Margelo worked on this before, here is more context

Before:

ios16-before.mp4

ios12mini-before.mp4

android-before.webm

After:

ios12mini-after.mp4

ios16-after.mp4

android-after.webm

melvin-bot · 2025-04-02T14:16:06Z

@shawnborton @ZhenjaHorbach One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ZhenjaHorbach · 2025-04-02T14:18:50Z

I think we should fix it ina follow up PR, thoughts?

Agree!
Plus It doesn't look so critical

And I will complete checklist today!

github-actions · 2025-04-02T15:00:11Z

🚧 @shawnborton has triggered a test app build. You can view the workflow run here.

shawnborton · 2025-04-02T15:52:47Z

Dang, mobile builds are failing for some reason...

ZhenjaHorbach · 2025-04-02T20:11:08Z

-                    isVisibleState && containerView
-                )}
+                <KeyboardAvoidingView
+                    behavior="padding"


Maybe we should left old condition ?
behavior={getPlatform() === CONST.PLATFORM.IOS ? 'padding' : undefined}

ZhenjaHorbach · 2025-04-02T21:50:15Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screenrecorder-2025-04-07-10-09-55-637.mp4

Android: mWeb Chrome

Screenrecorder-2025-04-07-10-11-53-427.mp4

iOS: Native

ios.mov

iOS: mWeb Safari

IMG_9878.MP4

MacOS: Chrome / Safari

2025-04-02.23.49.32.mov

MacOS: Desktop

2025-04-02.23.49.32.mov

ZhenjaHorbach · 2025-04-02T21:50:20Z

Don't say that this issue is only with me 😅

2025-04-02.23.47.28.mp4

ZhenjaHorbach · 2025-04-02T22:13:51Z

I have a warning on ios when open EmojiPicker

blazejkustra · 2025-04-03T07:58:50Z

Don't say that this issue is only with me 😅

2025-04-02.23.47.28.mp4

Uff, I have the same problem 😂

I have a warning on ios when open EmojiPicker

Looking into this too!

blazejkustra · 2025-04-04T09:57:10Z

but now we have an inconsistent between dev and staging
when the keyboard is open
And we can't change the skin tone

I'm working on it now 🫡

github-actions · 2025-04-04T10:01:43Z

🚧 @mountiny has triggered a test app build. You can view the workflow run here.

github-actions · 2025-04-04T10:41:01Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
Android 🤖🔄	iOS 🍎🔄
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/59539-hybrid/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/59539-hybrid/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/59539/NewExpensify.dmg	https://59539.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

…i-modal

blazejkustra · 2025-04-04T17:46:49Z

@ZhenjaHorbach I’ve reverted the changes related to KeyboardAvoidingView, except I kept behavior="padding" for both iOS and Android. The warning should be gone now - feel free to continue testing 😄

Videos:

ios.mp4

ios-web.mp4

web.mov

android.mp4

and-web.webm

blazejkustra · 2025-04-04T17:47:38Z

@mountiny Could you trigger the ad-hoc builds once more? 🙏

ZhenjaHorbach · 2025-04-04T17:49:56Z

Nice
Thanks !
I will check today or tomorrow !

shawnborton · 2025-04-07T06:34:06Z

Triggering the builds for us now 👍

github-actions · 2025-04-07T06:34:35Z

🚧 @shawnborton has triggered a test app build. You can view the workflow run here.

github-actions · 2025-04-07T07:16:36Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
Android 🤖🔄	iOS 🍎🔄
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/59539-hybrid/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/59539-hybrid/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/59539/NewExpensify.dmg	https://59539.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

ZhenjaHorbach · 2025-04-07T07:47:45Z

Noticed this
that when using search for the second time
EmojiPicker is fixed in a slightly wrong place

Update: But this bug is reproduced in staging
So I think we can skip this on this PR

trim.355DAB94-9099-47AE-8A48-F6012BCD8817.MOV

ZhenjaHorbach · 2025-04-07T08:17:04Z

Everything looks good now
Thanks for all fixes
LGTM !

mountiny

changes look good to me, curious if @shawnborton has any final feedback before we merge

shawnborton · 2025-04-07T16:49:16Z

Generally looks good to me!

The only thing I noticed is that if you do not have the composer focused on mobile (no keyboard showing), and then you launch the emoji picker, and then you close the emoji picker, we immediately focus the composer after the emoji picker closes. However, I think that exists in the staging/prod apps, we can deal with that in a separate issue.

mountiny · 2025-04-07T16:58:33Z

Sounds good, thanks for double checking!

OSBotify · 2025-04-07T17:06:57Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-04-07T23:09:34Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.24-2 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

izarutskaya · 2025-04-08T12:15:00Z

@blazejkustra QA team found issues #59771, #59777

github-actions · 2025-04-09T02:14:50Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.24-10 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

github-actions · 2025-04-09T04:33:11Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.24-10 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

BartoszGrajdek and others added 11 commits February 10, 2025 15:58

feat: enable new bottom modal in emoji picker

ee29cf1

fix: eslint problems

a6bd34f

fix: LayoutAnimationConfig mock

df606fb

chore: resolve merge conflicts

446234b

Merge remote-tracking branch 'origin/main' into @BartoszGrajdek/new-e…

7b82b78

…moji-modal

Merge branch 'main' of github.com:Expensify/App into @BartoszGrajdek/…

20f84c0

…new-emoji-modal

Merge branch 'main' of github.com:Expensify/App into @BartoszGrajdek/…

f4df8b7

…new-emoji-modal

Remove unnecessary comment and prop

ab9f94c

Use KeyboardAvoidingView from our codebase

8a82036

Add background color

3065947

Remove maxHeight restriction from popoverInnerContainer style

897f8c0

blazejkustra marked this pull request as ready for review April 2, 2025 14:16

blazejkustra requested review from a team as code owners April 2, 2025 14:16

melvin-bot Bot requested review from ZhenjaHorbach and shawnborton and removed request for a team April 2, 2025 14:16

This comment has been minimized.

Sign in to view

ZhenjaHorbach reviewed Apr 2, 2025

View reviewed changes

blazejkustra mentioned this pull request Apr 3, 2025

[UX Reliability] Improve the bottom modal animations quality and reliability on native and mWeb platforms #49354

Closed

Fix keyboard avoiding view on mobile web

9a64992

blazejkustra added 4 commits April 4, 2025 19:06

Bring back old code

bcc5485

Fix ios warning

d5ef18e

Use padding on android too

b12864f

Merge branch 'main' of github.com:Expensify/App into feature/new-emoj…

f5f59ca

…i-modal

ZhenjaHorbach approved these changes Apr 7, 2025

View reviewed changes

melvin-bot Bot requested a review from mountiny April 7, 2025 08:17

mountiny approved these changes Apr 7, 2025

View reviewed changes

mountiny merged commit 543a387 into Expensify:main Apr 7, 2025

github-actions Bot mentioned this pull request Apr 7, 2025

Deploy Checklist: New Expensify 2025-04-07 #59756

Closed

techievivek mentioned this pull request Apr 8, 2025

[Due for payment 2025-04-17] [Due for payment 2025-04-16] Android - Emoji - "Change default skin tone" button overlaps with device navigation bar #59777

Closed

8 tasks

daledah mentioned this pull request Apr 8, 2025

fix: emoji picker jumps when open keyboard #59214

Closed

50 tasks

daledah mentioned this pull request Apr 17, 2025

[$250] iOS - Chat - Emoji picker jumps when the keyboard is open #58331

Closed

8 tasks

Conversation

blazejkustra commented Apr 2, 2025

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

blazejkustra commented Apr 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

melvin-bot Bot commented Apr 2, 2025

Uh oh!

ZhenjaHorbach commented Apr 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Apr 2, 2025

Uh oh!

This comment has been minimized.

shawnborton commented Apr 2, 2025

Uh oh!

ZhenjaHorbach Apr 2, 2025

Choose a reason for hiding this comment

Uh oh!

ZhenjaHorbach commented Apr 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ZhenjaHorbach commented Apr 2, 2025

Uh oh!

ZhenjaHorbach commented Apr 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

blazejkustra commented Apr 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

blazejkustra commented Apr 4, 2025

Uh oh!

github-actions Bot commented Apr 4, 2025

Uh oh!

github-actions Bot commented Apr 4, 2025

Uh oh!

blazejkustra commented Apr 4, 2025

Uh oh!

blazejkustra commented Apr 4, 2025

Uh oh!

ZhenjaHorbach commented Apr 4, 2025

Uh oh!

shawnborton commented Apr 7, 2025

Uh oh!

github-actions Bot commented Apr 7, 2025

Uh oh!

github-actions Bot commented Apr 7, 2025

Uh oh!

ZhenjaHorbach commented Apr 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ZhenjaHorbach commented Apr 7, 2025

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

shawnborton commented Apr 7, 2025

Uh oh!

mountiny commented Apr 7, 2025

Uh oh!

OSBotify commented Apr 7, 2025

Uh oh!

github-actions Bot commented Apr 7, 2025

Uh oh!

izarutskaya commented Apr 8, 2025

Uh oh!

github-actions Bot commented Apr 9, 2025

Uh oh!

github-actions Bot commented Apr 9, 2025

Uh oh!

Reviewers

blazejkustra commented Apr 2, 2025 •

edited

Loading

ZhenjaHorbach commented Apr 2, 2025 •

edited

Loading

ZhenjaHorbach commented Apr 2, 2025 •

edited

Loading

ZhenjaHorbach commented Apr 2, 2025 •

edited

Loading

blazejkustra commented Apr 3, 2025 •

edited

Loading

ZhenjaHorbach commented Apr 7, 2025 •

edited

Loading