Enhance content measuring in PopoverWithMeasuredContent by rezkiy37 · Pull Request #59226 · Expensify/App

rezkiy37 · 2025-03-27T14:47:33Z

Explanation of Change

The PR fixes a bug where the popover was not being measured correctly when it was hidden and then shown again.

Fixed Issues

$ #58705
PROPOSAL: N/A

Tests

Verify that no errors appear in the JS console

Open an invoice report as a receiver.
Open the popover by clicking on the pay button.
Verify the popover is visible.
Close the popover.
Open the popover again by clicking on the pay button.
Verify the popover is visible and it does not blink.
Repeat it with clicking the "individual" and "business" buttons.
Close the popover when the subitmes are visible.
Open the popover again by clicking on the pay button.
Verify the popover is visible and it does not blink.

Offline tests

Same as tests.

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

Same as tests.

PR Author Checklist

Screenshots/Videos

Android: Native

Android.mp4

Android: mWeb Chrome

Android.Chrome.mp4

iOS: Native

IOS.mp4

iOS: mWeb Safari

IOS.Safari.mp4

MacOS: Chrome / Safari

Chrome.mp4

MacOS: Desktop

Desktop.mp4

…asurement on visibility change and include debug logs for measurement and visibility state.

…/58705-payment-modal-blinks

melvin-bot · 2025-03-27T15:12:14Z

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

rezkiy37 · 2025-03-27T15:12:55Z

One jest test has failed, but it is not associated with the PR. It is a known issue with ests/ui/GroupChatNameTests.tsx.

ZhenjaHorbach · 2025-03-27T19:47:03Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

NA

Android: mWeb Chrome

NA

iOS: Native

NA

iOS: mWeb Safari

NA

MacOS: Chrome / Safari

2025-04-03.20.07.26.mov

MacOS: Desktop

2025-04-03.20.07.26.mov

ZhenjaHorbach · 2025-03-27T19:52:35Z


    const modalId = useMemo(() => ComposerFocusManager.getId(), []);

+    useEffect(() => {


Minor comment
But let's leave a comment here what is this useEffect for !

Done - 6d4e69b.

ZhenjaHorbach · 2025-03-27T19:58:38Z

Looks like a bug is still reproduced

2025-03-27.21.00.40.mov

…/58705-payment-modal-blinks

rezkiy37 · 2025-03-28T09:57:34Z

@ZhenjaHorbach, I see it blinks in the first part of the video, but I don't see the bug in the second part. Anyway, I just retested it. Moreover, I used a B2B invoice report as well. Currently, it works properly on my side. Honestly, it is strange. Could you please retest?

Video

No.bug.mp4

rezkiy37 · 2025-03-28T09:58:00Z

I've synced it up.

ZhenjaHorbach · 2025-03-28T10:19:23Z

Unfortunately, it reproduces stably for me 😢

2025-03-28.11.18.37.mov

rezkiy37 · 2025-03-28T11:45:58Z

@ZhenjaHorbach, please send me your Onyx state. I'm gonna test this report on my side.

ZhenjaHorbach · 2025-03-28T11:53:00Z

Hmmmm
I'm not sure if it's related to onyx
But from other side
Maybe it's related with High Traffic account

onyx-state (5).txt

rezkiy37 · 2025-03-28T11:55:35Z

I also will ask my colleagues to test.

ZhenjaHorbach · 2025-03-28T11:59:57Z

Just tested on Safari
Same thing

2025-03-28.13.01.41.mov

rezkiy37 · 2025-03-28T12:03:28Z

@ZhenjaHorbach other reports the same?

rezkiy37 · 2025-03-28T12:08:55Z

@ZhenjaHorbach I've realized why you still can see the bug. You are tapping on the pay button to close but I was tapping outside of the button and popover. I can confirm the bug is still exists with this scenario.

ZhenjaHorbach · 2025-03-28T12:12:26Z

@ZhenjaHorbach other reports the same?

Yes

@ZhenjaHorbach I've realized why you still can see the bug. You are tapping on the pay button to close but I was tapping outside of the button and popover. I can confirm the bug is still exists with this scenario.

It reproduces for me even if I don't press the pay button to close
But I'm glad we found a stable way to reproduce !

2025-03-28.13.10.47.mov

rezkiy37 · 2025-03-28T12:20:02Z

@ZhenjaHorbach , I don't see the bug in the last video. Justo to clarify:

Open an invoice report as a receiver.

Click on the pay button.

Select the individual or business payment flow.

Click out of the modal to hide it.

Click on the pay button again.
Actual result: The modal blinks and opens on the payment actions and rerenders for resetting to the very beginning.
Expected result: The modal does not blink and opens immediately from the very beginning.

I see that it blinks when you tap on the business button. However, it is out of the scope.

ZhenjaHorbach · 2025-03-28T12:22:11Z

@ZhenjaHorbach , I don't see the bug in the last video. Justo to clarify:

Open an invoice report as a receiver.

Click on the pay button.

Select the individual or business payment flow.

Click out of the modal to hide it.

Click on the pay button again.
Actual result: The modal blinks and opens on the payment actions and rerenders for resetting to the very beginning.
Expected result: The modal does not blink and opens immediately from the very beginning.

I see that it blinks when you tap on the business button. However, it is out of the scope.

In that case, this is a regression from our previous PR where we implemented additional modal for payment methods
Isn't it? 😅

And I believe that the fix should apply to both modals

rezkiy37 · 2025-03-28T12:24:23Z

I agree; you are right. Let me fix it as well 🙂

…et logic

…/58705-payment-modal-blinks

rezkiy37 · 2025-03-31T10:33:41Z

Still at work. I have made progress, but the user can still see a blink in one scenario.

…/58705-payment-modal-blinks

rezkiy37 · 2025-04-01T18:12:15Z

Actively working on a fix. I've found the root cause and fixing it now.

…/58705-payment-modal-blinks

rezkiy37 · 2025-04-02T08:37:35Z

I guess I am pretty close to the fix. I have made good progress, but I need to polish it.

…/58705-payment-modal-blinks

…oning based on anchor alignment

rezkiy37 · 2025-04-03T11:52:29Z

Yehooo, I've finally fixed it - 71ce54d.
cc @ZhenjaHorbach

Video

Fix.mp4

ZhenjaHorbach · 2025-04-03T18:10:03Z

Yehooo, I've finally fixed it - 71ce54d. cc @ZhenjaHorbach

Video

Fix.mp4

Yeah
Now it looks perfect !
Thanks !

ZhenjaHorbach · 2025-04-03T18:10:23Z

LGTM !

OSBotify · 2025-04-03T19:01:05Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-04-07T23:08:31Z

🚀 Deployed to staging by https://github.com/cristipaval in version: 9.1.24-2 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-04-09T02:13:47Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.24-10 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

github-actions · 2025-04-09T04:32:08Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.24-10 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

Enhance PopoverWithMeasuredContent: Add useEffect to reset content me…

b5fa0e0

…asurement on visibility change and include debug logs for measurement and visibility state.

rezkiy37 mentioned this pull request Mar 27, 2025

[Due for payment 2025-04-16] Modal with payment methods blinks #58705

Closed

8 tasks

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fix…

adf38b9

…/58705-payment-modal-blinks

rezkiy37 changed the title ~~[WIP] Enhance content measuring in PopoverWithMeasuredContent~~ Enhance content measuring in PopoverWithMeasuredContent Mar 27, 2025

rezkiy37 marked this pull request as ready for review March 27, 2025 15:12

rezkiy37 requested a review from a team as a code owner March 27, 2025 15:12

melvin-bot Bot requested review from ZhenjaHorbach and removed request for a team March 27, 2025 15:12

ZhenjaHorbach reviewed Mar 27, 2025

View reviewed changes

rezkiy37 added 2 commits March 28, 2025 10:50

add comment

6d4e69b

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fix…

ce2c9f3

…/58705-payment-modal-blinks

rezkiy37 requested a review from ZhenjaHorbach March 28, 2025 09:57

Refactor PopoverWithMeasuredContent: Simplify content measurement res…

bd7311f

…et logic

ZhenjaHorbach mentioned this pull request Mar 28, 2025

[UX Reliability] Use new modal in BaseReportActionContextMenu #56606

Merged

48 tasks

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fix…

43b7361

…/58705-payment-modal-blinks

rezkiy37 added 2 commits April 1, 2025 17:47

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fix…

6c74558

…/58705-payment-modal-blinks

clear line

3496901

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fix…

9977d94

…/58705-payment-modal-blinks

rezkiy37 added 2 commits April 3, 2025 11:03

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fix…

c547bf3

…/58705-payment-modal-blinks

Enhance PopoverWithMeasuredContent to support dynamic vertical positi…

71ce54d

…oning based on anchor alignment

ZhenjaHorbach approved these changes Apr 3, 2025

View reviewed changes

melvin-bot Bot requested a review from cristipaval April 3, 2025 18:10

cristipaval approved these changes Apr 3, 2025

View reviewed changes

cristipaval merged commit a660ce8 into Expensify:main Apr 3, 2025

github-actions Bot mentioned this pull request Apr 7, 2025

Deploy Checklist: New Expensify 2025-04-07 #59756

Closed

daledah mentioned this pull request Apr 8, 2025

[Due for payment 2025-04-17] Copilot - Copilot context menu is blocked at the bottom of the page #59785

Closed

8 tasks


		const modalId = useMemo(() => ComposerFocusManager.getId(), []);

		useEffect(() => {

Conversation

rezkiy37 commented Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Mar 27, 2025

Uh oh!

rezkiy37 commented Mar 27, 2025

Uh oh!

ZhenjaHorbach commented Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ZhenjaHorbach Mar 27, 2025

Choose a reason for hiding this comment

Uh oh!

rezkiy37 Mar 28, 2025

Choose a reason for hiding this comment

Uh oh!

ZhenjaHorbach commented Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rezkiy37 commented Mar 28, 2025

Uh oh!

rezkiy37 commented Mar 28, 2025

Uh oh!

ZhenjaHorbach commented Mar 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rezkiy37 commented Mar 28, 2025

Uh oh!

ZhenjaHorbach commented Mar 28, 2025

Uh oh!

rezkiy37 commented Mar 28, 2025

Uh oh!

ZhenjaHorbach commented Mar 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rezkiy37 commented Mar 28, 2025

Uh oh!

rezkiy37 commented Mar 28, 2025

Uh oh!

ZhenjaHorbach commented Mar 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rezkiy37 commented Mar 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ZhenjaHorbach commented Mar 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rezkiy37 commented Mar 28, 2025

Uh oh!

rezkiy37 commented Mar 31, 2025

Uh oh!

rezkiy37 commented Apr 1, 2025

Uh oh!

rezkiy37 commented Apr 2, 2025

Uh oh!

rezkiy37 commented Apr 3, 2025

Uh oh!

ZhenjaHorbach commented Apr 3, 2025

Uh oh!

ZhenjaHorbach commented Apr 3, 2025

Uh oh!

OSBotify commented Apr 3, 2025

Uh oh!

github-actions Bot commented Apr 7, 2025

Uh oh!

github-actions Bot commented Apr 9, 2025

Uh oh!

github-actions Bot commented Apr 9, 2025

Uh oh!

rezkiy37 commented Mar 27, 2025 •

edited

Loading

ZhenjaHorbach commented Mar 27, 2025 •

edited

Loading

ZhenjaHorbach commented Mar 27, 2025 •

edited

Loading

ZhenjaHorbach commented Mar 28, 2025 •

edited

Loading

ZhenjaHorbach commented Mar 28, 2025 •

edited

Loading

ZhenjaHorbach commented Mar 28, 2025 •

edited

Loading

rezkiy37 commented Mar 28, 2025 •

edited

Loading

ZhenjaHorbach commented Mar 28, 2025 •

edited

Loading