update drop shadows on modals to match active theme#59271
Conversation
melvin-bot
Bot
requested review from
parasharrajat
and removed request for
a team
|
@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
| styles.pt2, | ||
| {top: 8 - BORDER_WIDTH, left: leftPopoverHorizontalPosition, right: rightPopoverHorizontalPosition}, | ||
| {boxShadow: variables.popoverMenuShadow}, | ||
| {boxShadow: `${variables.shadowPreset} ${theme.shadow}`}, |
There was a problem hiding this comment.
Rather than needing to always write two things here (shadowPreset and shadow), is there a way we can combine this into just one variable? Like even if in the individual theme files, like in dark.ts for example, we just did this: shadow: '0px 4px 12px 0px rgba(2,18,4,0.24)',
There was a problem hiding this comment.
Create a util for this and use it everywhere?
There was a problem hiding this comment.
Good point, I think defining the complete box-shadow directly in the theme files is a better idea, cleaner and avoids string concatenation, like:
shadow: '0px 4px 12px 0px rgba(2,18,4,0.24)' and
shadow: '0px 4px 12px 0px rgba(2,18,4,0.6)'.
|
Hi @Expensify/design , just to confirm, are these changes only for macOS Web and the desktop app? On mobile, we use the bottom-docked modal, which currently doesn’t have any box-shadow. Do we need to make any changes there? Thank you. Screen.20Recording.202025-03-29.20at.205-3.mp4 |
|
Also, we updated the shadow for Menus like FAB, Plus menu on chat. Please also confirm this. @Expensify/design |
|
Yup, confirming that we want to update all of those places.
Yup, pretty sure we want to add it here too on mobile. Does that sound right @Expensify/design? Basically if it's a popover/modal of any sort, it should get the shadow. |
|
Yep, that sounds right. Anything that's elevated over the content like that so that should be changed as well 👍 |
|
One point to mention is that the bottom-docked modal only has the top edge visible. Will this shadow work for that? Is it expanding on all edges? |
|
@Shahidullah-Muffakir Can you please update all of these? |
|
Yes, the same shadow should work just fine there. Let's try it out at least. |
|
Agree with the rest of the design team above 👍 |
|
Thank you for confirming, will add the changes. |
|
PR is ready for review now. |
|
Have you updated the screenshots in the original post? The shadow looks very harsh here:
|
The last commit includes changes for the mobile view only, and I added screenshots for that. |
|
Hmm just to clarify, is this new shadow being applied everywhere (web, desktop, mobile, etc) or not? |
Yes, everywhere. |
|
Great! @parasharrajat time for final review? |
The shadow seems overly harsh on iOS as well though!? Could we apply the shadow everywhere or at least in a consistent place on all platforms? |
|
Sorry @dubielzyk-expensify, I didn’t fully understand. |
|
I will start the review when we have finalized the shadow. |
|
considering the above comments, it looks like we're aligned and good to proceed. |
|
@Shahidullah-Muffakir Can you confirm if attached videos are uptodate? |
|
@dubielzyk-expensify Can you confirm if the shadow is as per your expectations on all platforms? |
Yes, all the videos are as per the final changes. |
|
This definitely looks wrong: And that's a video from the original post above. How can we fix and move forward? It definitely does not look anything like our mockups. |
|
@shawnborton 
|
|
@dubielzyk-expensify OP: CC: @Expensify/design |
|
@Shahidullah-Muffakir Ah! Looking into our Figma variables, I think that should be
cc @Expensify/design to confirm, but I'm pretty sure that's where the mismatch is coming from. |
|
@dannymcclain |
|
No worries! I went ahead and updated the description on the linked issue to reflect the correct opacity level as well 👍 |
|
@Shahidullah-Muffakir Can you please update vids on the description for design team and ping me here when done? |
I've updated the videos. @Expensify/design can review them now. |
|
Awesome that is looking way more like what we want! Sorry about that typo! Would love to give the rest of the @Expensify/design team a chance to check it out too. |
Screenshots🔲 iOS / native06.04.2025_19.49.47_REC.mp4🔲 iOS / Safari06.04.2025_19.51.21_REC.mp4🔲 MacOS / Desktop06.04.2025_19.52.31_REC.mp4🔲 MacOS / Chrome06.04.2025_19.39.06_REC.mp4🔲 Android / Chrome06.04.2025_19.37.42_REC.mp4🔲 Android / native06.04.2025_19.36.20_REC.mp4 |
parasharrajat
left a comment
parasharrajat
left a comment
There was a problem hiding this comment.
Reviewer Checklist
- I have verified the author checklist is complete (all boxes are checked off).
- I verified the correct issue is linked in the
### Fixed Issuessection above - I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the
Testssection - I verified the steps for Staging and/or Production testing are in the
QA stepssection - I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I verified the steps for local testing are in the
- I checked that screenshots or videos are included for tests on all platforms
- I included screenshots or videos for tests on all platforms
- I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
- If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
- I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
toggleReportand notonIconClick). - I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g.
myBool && <MyComponent />. - I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to
src/languages/*files and using the translation method - I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the
Waiting for Copylabel for a copy review on the original GH to get the correct copy. - I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in
STYLE.md) were followed
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
- If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
- I verified that this PR follows the guidelines as stated in the Review Guidelines
- I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like
Avatar, I verified the components usingAvatarhave been tested & I retested again) - I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
- I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
- If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a
/** comment above it */ - The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to
thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor) - Any internal methods bound to
thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick) - All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
- If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
- If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e.
StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
- If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
- If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like
Avataris modified, I verified thatAvataris working as expected in all cases) - If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
- If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
- If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added
Designlabel so the design team can review the changes.
- If a new page is added, I verified it's using the
ScrollViewcomponent to make it scrollable when more elements are added to the page. - If the
mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps. - I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
🎀 👀 🎀 C+ reviewed
Thanks Danny and that was totally MY typo so sorry for that! The screenshots above are looking great. @Expensify/design for gut check! |
|
Ah yes great sleuthing Danny, that was indeed the culprit! @parasharrajat shouldn't there be videos in your reviewer checklist? Thanks! |
|
@shawnborton I post them before the list. #59271 (comment) |
|
Ah okay I see them now, oops. I think we're good to merge then @mjasikowski |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.1.24-2 🚀
|
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.24-10 🚀
|
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.24-10 🚀
|
7 participants
Explanation of Change
Fixed Issues
$ #59196
PROPOSAL: #59196 (comment)
Tests
Offline tests
Same as tests.
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Dark Mode:
Screen.20Recording.202025-04-03.20at.209.mp4
Android: mWeb Chrome
Light Mode:
Screen.Recording.2025-04-04.at.10.45.07.PM.mov
Dark Mode:
Screen.Recording.2025-04-03.at.9.43.01.AM.mov
iOS: Native
Light mode:
Screen.Recording.2025-04-04.at.10.35.17.PM.mov
Dark mode:
Screen.Recording.2025-04-04.at.10.36.32.PM.mov
iOS: mWeb Safari
Light mode:
Screen.Recording.2025-04-04.at.10.23.49.PM.mov
Dark mode:
Screen.Recording.2025-04-04.at.10.25.54.PM.mov
MacOS: Chrome / Safari
Light mode:
Screen.Recording.2025-04-04.at.10.49.25.PM.mov
Dark mode:
macos.20web.20dark.mp4
MacOS: Desktop
Light Mode:
Screen.20Recording.202025-04-04.20at.2010-2.mp4
Dark mode:
Screen.20Recording.202025-03-29.20at.205.mp4