Skip to content

update drop shadows on modals to match active theme #59271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mjasikowski merged 5 commits into from
Apr 7, 2025
Merged

update drop shadows on modals to match active theme #59271

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
72ebec8
update drop shadows on modals to match active theme
Shahidullah-Muffakir Mar 28, 2025
3f239c4
store full boxShadow values in the theme files
Shahidullah-Muffakir Mar 28, 2025
cadc1a4
fix Prettier formatting issues
Shahidullah-Muffakir Mar 29, 2025
3f363d9
add boxshadow for modals in mobile
Shahidullah-Muffakir Apr 2, 2025
ffe084a
update shadow opacity for light mode
Shahidullah-Muffakir Apr 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/components/Search/SearchPageHeader/SearchPageHeaderInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import type {SelectionListHandle} from '@components/SelectionList/types';
import HelpButton from '@components/SidePane/HelpComponents/HelpButton';
import useLocalize from '@hooks/useLocalize';
import useResponsiveLayout from '@hooks/useResponsiveLayout';
import useTheme from '@hooks/useTheme';
import useThemeStyles from '@hooks/useThemeStyles';
import {navigateToAndOpenReport} from '@libs/actions/Report';
import {clearAllFilters} from '@libs/actions/Search';
Expand Down Expand Up @@ -55,6 +56,7 @@ function SearchPageHeaderInput({queryJSON, searchRouterListVisible, hideSearchRo
const {translate} = useLocalize();
const [showPopupButton, setShowPopupButton] = useState(true);
const styles = useThemeStyles();
const theme = useTheme();
const {shouldUseNarrowLayout: displayNarrowHeader} = useResponsiveLayout();
const personalDetails = usePersonalDetails();
const [reports] = useOnyx(ONYXKEYS.COLLECTION.REPORT);
Expand Down Expand Up @@ -303,7 +305,7 @@ function SearchPageHeaderInput({queryJSON, searchRouterListVisible, hideSearchRo
styles.pAbsolute,
styles.pt2,
{top: 8 - BORDER_WIDTH, left: leftPopoverHorizontalPosition, right: rightPopoverHorizontalPosition},
{boxShadow: variables.popoverMenuShadow},
{boxShadow: theme.shadow},
]
: [styles.pt4];
const inputWrapperActiveStyle = isAutocompleteListVisible ? styles.ph2 : null;
Expand Down
2 changes: 1 addition & 1 deletion src/styles/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ const styles = (theme: ThemeColors) =>
borderColor: theme.border,
justifyContent: 'center',
overflow: 'hidden',
boxShadow: variables.popoverMenuShadow,
boxShadow: theme.shadow,
paddingVertical: CONST.AUTO_COMPLETE_SUGGESTER.SUGGESTER_INNER_PADDING,
},

Expand Down
2 changes: 1 addition & 1 deletion src/styles/theme/themes/dark.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ const darkTheme = {
// Additional keys
overlay: colors.productDark400,
inverse: colors.productDark900,
shadow: colors.black,
shadow: '0px 4px 12px 0px rgba(2,18,4,0.24)',
componentBG: colors.productDark100,
hoverComponentBG: colors.productDark300,
messageHighlightBG: colors.messageHighlightDark,
Expand Down
2 changes: 1 addition & 1 deletion src/styles/theme/themes/light.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ const lightTheme = {
// Additional keys
overlay: colors.productLight400,
inverse: colors.productLight900,
shadow: colors.black,
shadow: '0px 4px 12px 0px rgba(2,18,4,0.06)',
componentBG: colors.productLight100,
messageHighlightBG: colors.yellow100,
hoverComponentBG: colors.productLight300,
Expand Down
13 changes: 7 additions & 6 deletions src/styles/utils/generators/ModalStyleUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ const createModalStyleUtils: StyleUtilGenerator<GetModalStylesStyleUtil> = ({the
},
};
modalContainerStyle = {
boxShadow: '0px 0px 5px 5px rgba(0, 0, 0, 0.1)',
boxShadow: theme.shadow,
borderRadius: variables.componentBorderRadiusLarge,
overflow: 'hidden',
width: variables.sideBarWidth,
Expand All @@ -98,7 +98,7 @@ const createModalStyleUtils: StyleUtilGenerator<GetModalStylesStyleUtil> = ({the
},
};
modalContainerStyle = {
boxShadow: '0px 0px 5px 5px rgba(0, 0, 0, 0.1)',
boxShadow: theme.shadow,
flex: 1,
marginTop: isSmallScreenWidth ? 0 : 20,
marginBottom: isSmallScreenWidth ? 0 : 20,
Expand Down Expand Up @@ -128,7 +128,7 @@ const createModalStyleUtils: StyleUtilGenerator<GetModalStylesStyleUtil> = ({the
},
};
modalContainerStyle = {
boxShadow: '0px 0px 5px 5px rgba(0, 0, 0, 0.1)',
boxShadow: theme.shadow,
flex: 1,
marginTop: isSmallScreenWidth ? 0 : 20,
marginBottom: isSmallScreenWidth ? 0 : 20,
Expand All @@ -155,7 +155,7 @@ const createModalStyleUtils: StyleUtilGenerator<GetModalStylesStyleUtil> = ({the
},
};
modalContainerStyle = {
boxShadow: '0px 0px 5px 5px rgba(0, 0, 0, 0.1)',
boxShadow: theme.shadow,
flex: 1,
marginTop: isSmallScreenWidth ? 0 : 20,
marginBottom: isSmallScreenWidth ? 0 : 20,
Expand All @@ -180,7 +180,7 @@ const createModalStyleUtils: StyleUtilGenerator<GetModalStylesStyleUtil> = ({the
},
};
modalContainerStyle = {
boxShadow: '0px 0px 5px 5px rgba(0, 0, 0, 0.1)',
boxShadow: theme.shadow,
borderRadius: variables.componentBorderRadiusLarge,
borderWidth: 0,
};
Expand Down Expand Up @@ -209,6 +209,7 @@ const createModalStyleUtils: StyleUtilGenerator<GetModalStylesStyleUtil> = ({the
paddingTop: variables.componentBorderRadiusLarge,
justifyContent: 'center',
overflow: 'hidden',
boxShadow: theme.shadow,
};

shouldAddBottomSafeAreaPadding = true;
Expand All @@ -232,7 +233,7 @@ const createModalStyleUtils: StyleUtilGenerator<GetModalStylesStyleUtil> = ({the
borderColor: theme.border,
justifyContent: 'center',
overflow: 'hidden',
boxShadow: variables.popoverMenuShadow,
boxShadow: theme.shadow,
};

hideBackdrop = true;
Expand Down
1 change: 0 additions & 1 deletion src/styles/variables.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,6 @@ export default {
pdfPageMaxWidth: 992,
tooltipzIndex: 10050,
gutterWidth: 12,
popoverMenuShadow: '0px 4px 12px 0px rgba(0, 0, 0, 0.06)',
optionRowHeight: 64,
optionRowHeightCompact: 52,
optionsListSectionHeaderHeight: getValueUsingPixelRatio(32, 38),
Expand Down