-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Remove the X pending #59653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Remove the X pending #59653
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
f0eed42
Remove the X pending
nkdengineer c58c9e7
remove unused dependencies
nkdengineer fbe121f
fix lint
nkdengineer d3dab37
add new key for deprecated code
nkdengineer d56b42e
prettier
nkdengineer fef6813
add more details
nkdengineer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||
|---|---|---|---|---|
|
|
@@ -947,7 +947,8 @@ const translations = { | |||
| yourCompanyWebsiteNote: 'Si no tiene un sitio web, puede proporcionar el perfil de LinkedIn o de las redes sociales de su empresa.', | ||||
| invalidDomainError: 'Ha introducido un dominio no válido. Para continuar, introduzca un dominio válido.', | ||||
| publicDomainError: 'Ha introducido un dominio público. Para continuar, introduzca un dominio privado.', | ||||
| expenseCount: ({scanningReceipts = 0, pendingReceipts = 0}: RequestCountParams) => { | ||||
| // TODO: This key should be deprecated. More details: https://github.com/Expensify/App/pull/59653#discussion_r2028653252 | ||||
| expenseCountWithStatus: ({scanningReceipts = 0, pendingReceipts = 0}: RequestCountParams) => { | ||||
| const statusText: string[] = []; | ||||
| if (scanningReceipts > 0) { | ||||
| statusText.push(`${scanningReceipts} escaneando`); | ||||
|
|
@@ -960,6 +961,12 @@ const translations = { | |||
| other: (count: number) => (statusText.length > 0 ? `${count} gastos (${statusText.join(', ')})` : `${count} gastos`), | ||||
| }; | ||||
| }, | ||||
| expenseCount: () => { | ||||
| return { | ||||
| one: '1 gasto', | ||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. did you verify these translations
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No need to reconfirm, it's used in here: Line 960 in 53786aa
|
||||
| other: (count: number) => `${count} gastos`, | ||||
| }; | ||||
| }, | ||||
| deleteExpense: () => ({ | ||||
| one: 'Eliminar gasto', | ||||
| other: 'Eliminar gastos', | ||||
|
|
||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.