Remove the X pending by nkdengineer · Pull Request #59653 · Expensify/App

nkdengineer · 2025-04-04T09:07:21Z

Explanation of Change

Fixed Issues

$ #59601
PROPOSAL: #59601 (comment)

Tests

Use the applause email account as that is on tableReportView beta

Create at least 3 expenses on a report, open a workspace chat where this report is
On wide web or desktop with mouse controls, Verify the text is shown X expenses before the pagination controls of an expense report preview
The arrows are not visible on mobile carousel so there are is no X expenses text there

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2025-04-04T09:08:22Z

@shawnborton @allgandalf One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

allgandalf · 2025-04-06T07:15:29Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

allgandalf · 2025-04-07T11:55:25Z

        },
+        expenseCount: () => {
+            return {
+                one: '1 gasto',


did you verify these translations

No need to reconfirm, it's used in here:

App/src/languages/es.ts

Line 960 in 53786aa

one: statusText.length > 0 ? `1 gasto (${statusText.join(', ')})` : `1 gasto`,

allgandalf · 2025-04-07T18:09:47Z

Verify the text is shown X expenses next to the pagination controls of an expense report preview

This testing step should be :

Verify the text is shown X expenses before the pagination controls of an expense report preview

@mountiny please update this if you merge it today

mountiny · 2025-04-07T18:29:00Z

Updated

allgandalf

LGTM!, just realised that we should also mention that these tests are not valid for small screens, please update that too, thanks!

mountiny

Thanks

OSBotify · 2025-04-07T18:53:19Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-04-07T23:10:16Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.24-2 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-04-09T02:15:32Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.24-10 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

github-actions · 2025-04-09T04:33:53Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.24-10 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

iwiznia · 2025-12-19T19:30:39Z

Randomly stumbled upon this line referencing this issue. @nkdengineer can you send a PR to remove the now unused translation please?

nkdengineer · 2025-12-30T13:14:42Z

@iwiznia Sorry for the late, here is the PR

Remove the X pending

f0eed42

nkdengineer marked this pull request as ready for review April 4, 2025 09:08

nkdengineer requested a review from a team as a code owner April 4, 2025 09:08

melvin-bot Bot requested review from allgandalf and shawnborton and removed request for a team April 4, 2025 09:08

nkdengineer added 2 commits April 4, 2025 16:10

remove unused dependencies

c58c9e7

fix lint

fbe121f

shawnborton reviewed Apr 4, 2025

View reviewed changes

Comment thread src/languages/en.ts

mountiny assigned nkdengineer Apr 4, 2025

add new key for deprecated code

d3dab37

allgandalf reviewed Apr 4, 2025

View reviewed changes

Comment thread src/languages/es.ts Outdated

nkdengineer added 2 commits April 4, 2025 22:27

prettier

d56b42e

add more details

fef6813

allgandalf reviewed Apr 7, 2025

View reviewed changes

allgandalf approved these changes Apr 7, 2025

View reviewed changes

melvin-bot Bot requested a review from mountiny April 7, 2025 18:34

mountiny approved these changes Apr 7, 2025

View reviewed changes

mountiny merged commit 767666f into Expensify:main Apr 7, 2025

github-actions Bot mentioned this pull request Apr 7, 2025

Deploy Checklist: New Expensify 2025-04-07 #59756

Closed

melvin-bot Bot mentioned this pull request Apr 9, 2025

[Due for payment 2025-04-16] [$125] [Better Expense Report View] Remove the (X pending) label from the carousel pagination control #59601

Closed

mountiny mentioned this pull request Dec 30, 2025

[No QA] remove expenseCountWithStatus translation #78579

Merged

53 tasks

Conversation

nkdengineer commented Apr 4, 2025 • edited by mountiny Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Apr 4, 2025

Uh oh!

Uh oh!

Uh oh!

allgandalf commented Apr 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

allgandalf Apr 7, 2025

Choose a reason for hiding this comment

Uh oh!

nkdengineer Apr 7, 2025

Choose a reason for hiding this comment

Uh oh!

allgandalf commented Apr 7, 2025

Uh oh!

mountiny commented Apr 7, 2025

Uh oh!

allgandalf left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Apr 7, 2025

Uh oh!

github-actions Bot commented Apr 7, 2025

Uh oh!

github-actions Bot commented Apr 9, 2025

Uh oh!

github-actions Bot commented Apr 9, 2025

Uh oh!

iwiznia commented Dec 19, 2025

Uh oh!

nkdengineer commented Dec 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

nkdengineer commented Apr 4, 2025 •

edited by mountiny

Loading

allgandalf commented Apr 6, 2025 •

edited

Loading