[Retract] fix reopen report bugs by rushatgabhane · Pull Request #62791 · Expensify/App

rushatgabhane · 2025-05-26T14:22:57Z

Explanation of Change

Fixed Issues

$ #59561
PROPOSAL:

Tests

Pre-req: have a report that is in closed state in a workspace (you can find it on old dot using filters)
And have two accounts that are admins for that workspace.

Test 1: Failing request

Go to a report that is in closed state.
Enable simulate failing requests
Click more > Reopen
You will now get a new comment - reopened and a error message for it
Dismiss the error message.
Verify that the comment reopened disappears

Test 2: updated next step for reopen

Go to a report that is in closed state
Click more > Reopen
Verify that the next step says - "Waiting for %submitter% to submit expense(s)"

Test 3: submit button after reopening a report

Go to a report that is in closed state
Click more > Reopen
Verify that you see submit button as a primary action - (i.e. green button)
Login as another user who is an admin for that report, verify that you see submit button inside More button.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Details

### Bug 1: failing requests

Screen.Recording.2025-05-26.at.13.01.36.mov

Bug 2: updated next step

Bug 3: submit button after reopening a report

Submitter

Admin

melvin-bot · 2025-05-26T14:40:03Z

@s77rt Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

rushatgabhane · 2025-05-26T14:45:07Z

            key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${expenseReport.reportID}`,
            value: {
                [optimisticReopenedReportAction.reportActionID]: {
-                    pendingAction: null,


this fixes failing request bug

s77rt · 2025-05-26T18:38:34Z

Bug: Infinite next step loader

Enable simulate failing requests
Undo close
Clear error
Disable Simulate failing request
Refresh page

Screen.Recording.2025-05-26.at.7.21.08.PM.mov

s77rt · 2025-05-26T18:43:08Z

Click more > Reopen

I think this may have been renamed but it's Undo close

rushatgabhane · 2025-05-26T19:13:40Z

Bug: Infinite next step loader

@s77rt that is on main too. it is backend related mostly.

@dangrous do you know if any backend change might have caused this?

steps:

reopen a report
sign out and sign in and go to report
observe that the report has infinite loading next step

#62791 (comment)

s77rt · 2025-05-26T20:35:25Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2025-05-26.at.7.27.50.PM.mov

MacOS: Desktop

s77rt · 2025-05-26T20:36:23Z

@rushatgabhane please update test step to state "Undo close" to avoid confusion

s77rt

I have tested on web only but that shouldn't be a blocker. (I'm not sure how to get reports into closed state)

s77rt · 2025-05-26T20:56:01Z

@dangrous BE bug: I have this report 426559800334358 that's closed (statusNum = 2) but I can't seem able to reopen it.

Edit: refreshing the page didn't help

requestID: 94602b719c814e22-LAX

dangrous · 2025-05-27T17:35:22Z

@dangrous do you know if any backend change might have caused this?

Oh huh, I was noticing this last week too, but I thought it was maybe just my local environment! I will look into it. Does it seem specific to reopen/reject, or no?

Do you know if it's an existing bug issue? If not we should report

dangrous · 2025-05-27T17:37:08Z

94602b719c814e22-LAX

So you're getting this error from the back end - The report status has changed since you started reviewing it. Please refresh the page to view the current status.' exceptionMessage: 'The report status has changed since you started reviewing it. Please refresh the page to view the current status. What's the set up for the report?

dangrous

This looks overall good, but now we have some conflicts, and one question about the logic.

I'll look into that next step thing when I can, and I'm curious about the error message noted, too. Let's see what we can do about that one - it might need an FE handling change.

s77rt · 2025-05-27T20:35:14Z

What's the set up for the report?

Nothing specific that I can recall. Can't you check in the BE why it's failing? I think all my closed reports can't be reopened (e.g. 5809779596558524, 426559800334358, etc.) Maybe it's related to some WS (A344B9B9011AB615) settings but I can't tell for sure. PS: I can submit new reports just fine.

rushatgabhane · 2025-05-27T20:49:20Z

@s77rt are you able to open the reports on old dot?

do you see take control option on old dot?

if yes, click it and then try to reopen on new dot

s77rt · 2025-05-27T20:56:22Z

@rushatgabhane Thanks! Yup that did it! In that case shouldn't we hide the Undo close button on ND if you are not in control

dangrous · 2025-05-28T16:17:02Z

hm yeah @joekaufmanexpensify will we need admins to "take control" for this to happen, like we do on Old Dot, or should it be updated (either here or in both places)?

@s77rt @rushatgabhane I know joe is OOO for the rest of the week, so I put that question up there, but I think we should probably move forward without his answer to get this moving.

Can we hide the button if you're not in control, for now? How do we determine that on the FE? I think the backend looks for "own" permission on the report.

Also conflicts, and bumping this question, too. Thanks!

rushatgabhane · 2025-05-29T15:04:45Z

Can we hide the button if you're not in control, for now? How do we determine that on the FE? I think the backend looks for "own" permission on the report.

hmm i do not know

i looked into old dot for own property in report. it has ownerAccountID and ownerEmail, but they belong my account.

@dangrous i will need your help on this 😄

dangrous · 2025-05-29T15:35:30Z

okay so the TakeControl command seems to basically just update the managerID of the report to be the accountID of the user taking ownership. Sooooo I guess we can just check if the current user's accountID matches the managerID, and not show the button unless that's true. Does that make sense?

I don't think we're handling taking control in ND yet.

rushatgabhane · 2025-05-29T15:50:30Z

oh yeah that makes sense

rushatgabhane · 2025-05-29T15:51:23Z

so reopen won't work unless we add take control to new dot

rushatgabhane · 2025-05-29T16:47:57Z

started discuss here - https://expensify.slack.com/archives/C07HPDRELLD/p1748534248715669

dangrous · 2025-05-29T20:12:59Z

~~hi! one note - when i was testing the take control thing (BE PR is now in review) I noticed:~~

If the App gets an error from the backend (or at least that incorrect state error we saw without taking control), the optimistic report action (reopened) does not disappear from the report until log out, even after switching reports. Is that something we can update?

EDIT - I'm dumb, I hadn't checked out this PR. This is all good

rushatgabhane · 2025-05-29T20:14:16Z

hahaha happens to me too sometimes

dangrous

LGTM! Let's do this. PR to handle the take control case is still in progress (discussion ongoing in Slack) but since this is behind a beta I think we're fine.

OSBotify · 2025-05-30T01:00:44Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-06-02T19:56:34Z

🚀 Deployed to staging by https://github.com/dangrous in version: 9.1.55-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-06-03T12:51:25Z

🚀 Deployed to staging by https://github.com/dangrous in version: 9.1.56-2 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

joekaufmanexpensify · 2025-06-03T16:37:01Z

Posted a bug here I found while testing.

nlemma · 2025-06-03T19:15:46Z

@rushatgabhane This PR is failing because of issue #63389

github-actions · 2025-06-03T20:03:50Z

🚀 Deployed to staging by https://github.com/dangrous in version: 9.1.58-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-06-04T16:20:04Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.1.58-4 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

rushatgabhane added 5 commits May 26, 2025 13:36

fix optimistic message for reopen

739ecd6

fix err message

330fe15

fix reopened report bugs

fd56804

revert err message

41d7103

run pretty

1bf1c08

rushatgabhane marked this pull request as ready for review May 26, 2025 14:39

rushatgabhane requested a review from a team as a code owner May 26, 2025 14:39

melvin-bot Bot requested a review from s77rt May 26, 2025 14:40

melvin-bot Bot removed the request for review from a team May 26, 2025 14:40

rushatgabhane commented May 26, 2025

View reviewed changes

s77rt suggested changes May 26, 2025

View reviewed changes

Comment thread src/libs/ReportPrimaryActionUtils.ts

s77rt approved these changes May 26, 2025

View reviewed changes

melvin-bot Bot requested a review from dangrous May 26, 2025 20:37

dangrous suggested changes May 27, 2025

View reviewed changes

Comment thread src/libs/ReportPrimaryActionUtils.ts

rushatgabhane force-pushed the retract-bugs branch from a23954a to 1bf1c08 Compare May 29, 2025 14:54

Merge branch 'main' of github.com:rushatgabhane/exfy into retract-bugs

a5204eb

run pretty

9b7fcc5

rushatgabhane added 3 commits May 29, 2025 22:16

Merge branch 'main' into retract-bugs

53b8662

fix bad merge

a72b316

fix new merge conflicts

d3cc7a0

rushatgabhane requested a review from dangrous May 29, 2025 23:09

dangrous approved these changes May 30, 2025

View reviewed changes

dangrous merged commit d6d25e6 into Expensify:main May 30, 2025
16 checks passed

github-actions Bot mentioned this pull request Jun 2, 2025

Deploy Checklist: New Expensify 2025-06-02 #63263

Closed

nlemma mentioned this pull request Jun 3, 2025

[Due for payment 2025-06-17] [$250] Expense - Submit button is not shown in More menu for workspace admin #63356

Closed

8 tasks

nlemma mentioned this pull request Jun 3, 2025

[$250] iOS-Reopen report-"Reopen" comment does not disappear after dismissing the error #63389

Closed

8 tasks

melvin-bot Bot mentioned this pull request Jun 4, 2025

[Due for payment 2025-06-11] [$250] Implement Reopen Report in New Dot #59561

Closed

daledah mentioned this pull request Sep 7, 2025

[Due for payment 2025-10-17] [$250] Expense - Submit option is missing in More if retract and hold expense #70037

Closed

8 tasks

Conversation

rushatgabhane commented May 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Test 1: Failing request

Test 2: updated next step for reopen

Test 3: submit button after reopening a report

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Bug 2: updated next step

Bug 3: submit button after reopening a report

Submitter

Admin

Uh oh!

melvin-bot Bot commented May 26, 2025

Uh oh!

rushatgabhane May 26, 2025

Choose a reason for hiding this comment

Uh oh!

s77rt commented May 26, 2025

Uh oh!

s77rt commented May 26, 2025

Uh oh!

Uh oh!

rushatgabhane commented May 26, 2025

Uh oh!

s77rt commented May 26, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

s77rt commented May 26, 2025

Uh oh!

s77rt left a comment

Choose a reason for hiding this comment

Uh oh!

s77rt commented May 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dangrous commented May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dangrous commented May 27, 2025

Uh oh!

dangrous left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

s77rt commented May 27, 2025

Uh oh!

rushatgabhane commented May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

s77rt commented May 27, 2025

Uh oh!

dangrous commented May 28, 2025

Uh oh!

rushatgabhane commented May 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dangrous commented May 29, 2025

Uh oh!

rushatgabhane commented May 29, 2025

Uh oh!

rushatgabhane commented May 29, 2025

Uh oh!

rushatgabhane commented May 29, 2025

Uh oh!

dangrous commented May 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rushatgabhane commented May 29, 2025

Uh oh!

dangrous left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rushatgabhane commented May 26, 2025 •

edited

Loading

s77rt commented May 26, 2025 •

edited

Loading

dangrous commented May 27, 2025 •

edited

Loading

rushatgabhane commented May 27, 2025 •

edited

Loading

rushatgabhane commented May 29, 2025 •

edited

Loading

dangrous commented May 29, 2025 •

edited

Loading