Add the NewRoomPage#6314
Conversation
… take into account our new design language
684401e
|
@yuwenmemon, @sketchydroide, this is ready for another look I've resolved the merge conflicts and put this feature behind the default rooms beta (that made the most sense to me). I decided not to add the UI for the Report page in this PR, so after creating a room it will look blank and weird (like in the test steps). I'm working on a report details page for Policy Rooms so I'll add that UI in another PR instead. |
|
Nice, thanks for taking this over @TomatoToaster! |
|
@sketchydroide all yours |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by @sketchydroide in version: 1.1.19-5 🚀
|
|
@TomatoToaster Seems like there was a regression found on staging here regarding the error when the same room name is inputted. |
|
A PR to fix the mal-functioning room name check can be found here. I have also tried the credentials listed in PR on staging, but there was no option to create a new room there so I assume that account does not have the betas required to QA this. |
|
🚀 Deployed to production by @Julesssss in version: 1.1.21-1 🚀
|


Details
This adds the New Room Page, which allows users to create a new room on a workspace.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/176850
Tests
<baseURL>/workspace/new-room.test_room_nameinto the room name input and select a workspace. Click "Create Room". Verify that the room is created and that you navigate to the room (<baseURL>/r/<reportID>).<baseURL>/workspace/new-room. Select the same workspace you used in [4]. Then, typetest_room_nameinto the Room Name input. Verify that theA room with this name already existserror message displays (in real-time as you finish typingtest_room_name).eoff of the room name. Verify the error disappears. Add the lasteback, and verify the error appears again.QA Steps
Same as the above tests, just use these credentials on staging:
margrett952@labeledhf.comasdfASDF00Tested On
Screenshots
Web
web.mp4
Mobile Web
Desktop
desktop.mp4
iOS
ios.mp4
Android
android.mp4