Deploy Checklist: New Expensify 2021-12-10

[OSBotify]

Release Version: 1.1.20-2
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Name and message aligned in iOS + Focus Mode - Issue 6096 #6289

  • QA
  • Accessibility

• Add the NewRoomPage #6314

  • QA
  • Accessibility

• Improve react-navigation CustomAction #6581

  • QA
  • Accessibility

• Added attachment size check for videos on native #6588

  • QA
  • Accessibility

• Create Security sub-settings menu #6624

  • QA
  • Accessibility

• Make bank account page scrollable #6648

  • QA
  • Accessibility

• Refactor Settlement Button for reuse in both Details and Confirm screens #6651

  • QA
  • Accessibility

• [No QA]Sign cherry pick PRs as @OSBotify #6655

  • QA
  • Accessibility

• growl width fix #6665

  • QA
  • Accessibility

• [CP Stg] Fix iPad pro SignInPageLayout #6670

  • QA
  • Accessibility

• [CP Stg] Wrap AddPersonalBankAccount with KeyboardAvoidingView #6672

  • QA
  • Accessibility

• Adding support for chunked chats #6673

  • QA
  • Accessibility

• Re-render ReportActionsView when report icons change #6684

  • QA
  • Accessibility

• fix: Redirect after fresh workspace creation #6697

  • QA
  • Accessibility

Deploy Blockers:

• Error message ''A room with this name already exist'' isn't displayed after type the same name for room the Room Name input #6709
• Chat - Message that are bigger than 10240 characters does not appear without reload #6710
• Workspace settings - App's orientation does not change to Landscape #6711
• IOS/Android - Black screen is displayed when try to create room #6712
• [HOLD for payment 2022-01-11] New Chat Room - Letters are doubled when entering Room Name  #6725
• Web - Unable to search room after it has been created #6726
• Room name is not shown in the header after creating a new room #6731
• iOS -Chat - App crashes tapping the room name in the chat  #6740
• New room - Unable to create a room with visibility as "Private" #6757
• New room - Creating a room in non admin workspace showing as normal chat with that admin user #6758

cc @Expensify/applauseleads

[MelvinBot]

📣 @applausebot You have been assigned to this job by @OSBotify!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[mvtglobally]

Starting QA

[mountiny]

I am demoting the Workspace settings - app orientation issue from deploy blockers. It is a new and expected behaviour. Please, @mvtglobally could you update the testing so that we test the orientation change is possible on tablets, but we cannot change to landscape on mobile? Thank you!

Also I am removing the Chat - Messages that are bigger than 10240 characters from the deploy blocker list, it is a duplicate of an existent issue, which apparently was not solved as expected and I have informed the author of the PR. As it is already bug on production for a while it should not block the deploy.

[isagoico]

Regression is finished!
Issues found:

1. Error message ''A room with this name already exist'' isn't displayed after type the same name for room the Room Name input #6709 is failing Add the NewRoomPage #6314
2. Chat - Message that are bigger than 10240 characters does not appear without reload #6710 - Not a deploy blocker
3. Workspace settings - App's orientation does not change to Landscape #6711 - Expected behaviour on phones
4. IOS/Android - Black screen is displayed when try to create room #6712 is failing Add the NewRoomPage #6314

Thanks!

[isagoico]

We found this issue on Android as well when closing the regression run - #6725. Looks like a Deploy Blocker

[ogumen]

I am demoting the Workspace settings - app orientation issue from deploy blockers. It is a new and expected behaviour. Please, @mvtglobally could you update the testing so that we test the orientation change is possible on tablets, but we cannot change to landscape on mobile? Thank you!

Also I am removing the Chat - Messages that are bigger than 10240 characters from the deploy blocker list, it is a duplicate of an existent issue, which apparently was not solved as expected and I have informed the author of the PR. As it is already bug on production for a while it should not block the deploy.

@mountiny from the accessibility perspective restricting the content view and operation to a single display orientation fails WCAG 2.1 SC 1.3.4

[mvtglobally]

@mountiny @roryabraham We got a new version. What blockers are we good to re-test now?

[isagoico]

Created this issue to get @mvtglobally added to the @Expensify/applauseleads team so she can get notified too. https://github.com/Expensify/Expensify/issues/188471

[mountiny]

@mvtglobally Great! Could you please retest these three issues:

• Error message ''A room with this name already exist'' isn't displayed after type the same name for room the Room Name input #6709
• IOS/Android - Black screen is displayed when try to create room #6712
• Room name is not shown in the header after creating a new room #6731

Thank you very much!

[isagoico]

While retesting #6724 we found this issue #6740. Fix is being worked on by @luacmartins here #6741 🎉

[isagoico]

Cherry pick #6741 was tested, we found 2 extra new issues surrounding the New Room creation flow. Not sure if they should be treated as DBs or not @TomatoToaster can you give them a look:

• New room - Unable to create a room with visibility as "Private" #6757
• New room - Creating a room in non admin workspace showing as normal chat with that admin user #6758

[roryabraham]

@isagoico what's the story with #6665 ?