Company Cards: Add statement close date to new commercial card feeds by s77rt · Pull Request #65113 · Expensify/App

s77rt · 2025-06-27T22:43:41Z

Explanation of Change

Fixed Issues

$ #64484
PROPOSAL:

Tests

Have a workspace with company cards enabled

Go to Workspaces > Workspace > Company Cards
Add a new card feed (choose Commercial feed if prompted)
Verify that at the last step you are asked to choose a statement close date
Verify that you can't proceed unless a valid date is selected
Choose a valid date and verify you were able to add the new card feed successfully

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Have a workspace with company cards enabled

Go to Workspaces > Workspace > Company Cards
Add a new card feed
Complete all the steps and verify you were able to add the new card feed successfully

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

Screen.Recording.2025-06-29.at.1.43.50.AM.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2025-06-29.at.1.42.25.AM.mov

MacOS: Desktop

…allback

melvin-bot · 2025-06-28T01:36:49Z

@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

s77rt · 2025-06-29T00:27:58Z

Found two bugs that I have to address:

On native the submit button is too close to the bottom
The offline indicator overlaps with the submit button

ikevin127

(13) Code review.

ikevin127 · 2025-06-29T00:23:56Z

+    const [error, setError] = useState<string | undefined>(undefined);
+
+    const sections = useMemo(() => {
+        const data = [...Array(28).keys()].reduce<CustomCloseDateListItem[]>((days, key) => {


About the 28 days logic, I followed the Slack discussion on this and noted that @JS00001 said:

I assume we'd want to show 31, and then on the BE we would set it to the min of their selected value, or the days in the month

and @JmillsExpensify said:

We can’t show higher than 28 since using higher than that would cause some months to fail, since they don’t have higher than that number.
As a result of that, I’m nearly certain that all banks never close a company card statement on a day other than 1-28.

🟡 My concern is that showing only 28 days regardless of month could confuse users who expect to see all valid days. I'd suggest we add an informational note at the top of the component to let the user know why we only allow 28 selectable days.

An additional concern is that we don't support more than 1-28 on OldDot, so by adding more options now, we're creating a backward compatibility issue. I'm down to add some text if anyone in this PR is passionate, though also worth noting that we've had this behavior in OldDot for years and I'm not aware of this question coming up.

s77rt · 2025-06-29T15:18:08Z

Heads up: The statement close date step is only displayed if you choose Commercial feed. I have asked in slack if we should display that step for Direct feed too.

Edit: I will add the same step for direct feed in a follow up PR

ikevin127 · 2025-07-01T01:11:20Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android-hybrid.mp4

Android: mWeb Chrome

android-mweb.mp4

iOS: HybridApp

ios-hybrid.mp4

iOS: mWeb Safari

ios-mweb.mp4

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

luacmartins

FYI we already have a similar date picker page for submission frequencies. I think we should align the design of both pages

App/src/pages/workspace/workflows/WorkspaceAutoReportingMonthlyOffsetPage.tsx

Line 22 in e89b522

const DAYS_OF_MONTH = 28;

s77rt · 2025-07-01T23:27:38Z

@luacmartins Thanks! I can reuse some of that existing logic but the figma design does not include the "Last day of the month" and "Last business day of the month" in the same selection list as the days

luacmartins · 2025-07-02T19:34:23Z

@Expensify/design for opinions on the above. It seems like we have a different existing design for selecting days of month, last day of month, etc

luacmartins

I'm gonna go ahead and merge this, we can address the design changes (if any) in a follow up

dubielzyk-expensify · 2025-07-02T23:10:37Z

FYI we already have a similar date picker page for submission frequencies. I think we should align the design of both pages

Agreed. I prefer the simpler execution in this video where the custom line item goes to a new screen with all the dates

shawnborton · 2025-07-03T10:16:09Z

Definitely agree with that.

dannymcclain · 2025-07-03T13:23:43Z

Sounds good to me!

github-actions · 2025-07-03T19:45:46Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.1.75-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	success ✅

IuliiaHerets · 2025-07-05T18:04:12Z

@s77rt @luacmartins We haven't a statement close date tab while adding the Company card feed. Is it an issue?

Bug6878216_1751643769750.Screen_Recording_2025-07-04_at_6.39.29_PM.mp4

s77rt · 2025-07-05T18:47:51Z

@IuliiaHerets No, not an issue. That's the expected result for now because we haven't made the statement close page available in staging/production yet.

github-actions · 2025-07-07T10:57:25Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.1.76-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

s77rt · 2025-07-15T15:56:52Z

I think we still need to change the existing design in submission frequency for consistency #65113 (review)

s77rt added 9 commits June 27, 2025 14:02

wip

1ebc7b6

update WorkspaceCompanyCardStatementCloseDateSelectionList

831ba3e

use compact mode in custom close date menu item

0bf1e64

WorkspaceCompanyCardStatementCloseDateSelectionList: added onSubmit c…

28ce0e4

…allback

add statement close date step

9e50cc1

store feeddetails in onyx as an object

3c9ea3c

added default values to details step

9085f8b

update CardFeedDetails type

298246f

lint

66a37c7

s77rt changed the title ~~Search: Statement close date~~ Company Cards: Add statement close date to new card feeds Jun 28, 2025

disable details and statement close date steps when offline

0fb57f3

s77rt marked this pull request as ready for review June 28, 2025 01:36

s77rt requested a review from a team as a code owner June 28, 2025 01:36

melvin-bot Bot requested review from ikevin127 and removed request for a team June 28, 2025 01:36

s77rt added 2 commits June 28, 2025 14:24

translate

978709b

fix options display on native

acf1b34

s77rt added 3 commits June 29, 2025 01:36

fixed submit button position

b5aa36a

use ScrollView

708fd95

remove unnecessary View

4bf28d7

ikevin127 suggested changes Jun 29, 2025

View reviewed changes

s77rt added 4 commits June 29, 2025 02:00

make deliveryFileName optional

aa3d8f3

move month days array to CONST

e2da6cb

fix Polish translation

a949dc8

add missing period at end of sentences

a16733e

s77rt requested a review from ikevin127 June 29, 2025 14:03

JS00001 self-requested a review June 30, 2025 17:39

s77rt changed the title ~~Company Cards: Add statement close date to new card feeds~~ Company Cards: Add statement close date to new commercial card feeds Jun 30, 2025

JS00001 reviewed Jul 1, 2025

View reviewed changes

Comment thread src/CONST/index.ts

add comment

e89b522

luacmartins self-requested a review July 1, 2025 13:11

s77rt mentioned this pull request Jul 1, 2025

[Tracking] [Suggested Search v2.1] Suggested Search v2.1 Unapproved Accruals #64583

Closed

ikevin127 approved these changes Jul 1, 2025

View reviewed changes

melvin-bot Bot requested a review from JS00001 July 1, 2025 22:24

luacmartins requested changes Jul 1, 2025

View reviewed changes

JS00001 approved these changes Jul 2, 2025

View reviewed changes

s77rt added 2 commits July 2, 2025 20:27

Merge branch 'main' into statement-close-date

96a59fc

Merge branch 'main' into statement-close-date

2904af3

luacmartins approved these changes Jul 2, 2025

View reviewed changes

luacmartins merged commit 8cca0a6 into Expensify:main Jul 2, 2025
18 checks passed

github-actions Bot mentioned this pull request Jul 2, 2025

Investigate workflow job failing on main: test / test (job 3) #65380

Closed

luacmartins mentioned this pull request Jul 2, 2025

[No QA] Company Cards: Add statement close date to existing card feeds #65154

Merged

51 tasks

github-actions Bot mentioned this pull request Jul 3, 2025

Deploy Checklist: New Expensify 2025-07-03 #65447

Closed

63 tasks

melvin-bot Bot mentioned this pull request Jul 7, 2025

[Due for payment 2025-07-22] [Due for payment 2025-07-14] [Suggested Search v2.3] [App] Add “Statement close date” step for new card feeds #64484

Closed

dominictb mentioned this pull request Jul 15, 2025

[Internal QA]: More Plaid import follow ups #64741

Merged

51 tasks

s77rt mentioned this pull request Aug 17, 2025

[Due for payment 2025-08-19] Company cards - No "No results found" when there is no search result on "Custom day of month" #68112

Closed

8 tasks

Conversation

s77rt commented Jun 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jun 28, 2025

Uh oh!

s77rt commented Jun 29, 2025

Uh oh!

ikevin127 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ikevin127 Jun 29, 2025

Choose a reason for hiding this comment

Uh oh!

JmillsExpensify Jul 1, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

s77rt commented Jun 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ikevin127 commented Jul 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

s77rt commented Jul 1, 2025

Uh oh!

luacmartins commented Jul 2, 2025

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dubielzyk-expensify commented Jul 2, 2025

Uh oh!

shawnborton commented Jul 3, 2025

Uh oh!

dannymcclain commented Jul 3, 2025

Uh oh!

github-actions Bot commented Jul 3, 2025

Uh oh!

IuliiaHerets commented Jul 5, 2025

Uh oh!

s77rt commented Jul 5, 2025

Uh oh!

github-actions Bot commented Jul 7, 2025

Uh oh!

s77rt commented Jul 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

s77rt commented Jun 27, 2025 •

edited

Loading

s77rt commented Jun 29, 2025 •

edited

Loading

ikevin127 commented Jul 1, 2025 •

edited

Loading