[No QA] Company Cards: Add statement close date to existing card feeds#65154
Merged
Conversation
Contributor
|
Is this a dupe of #65113? |
Contributor
|
Ah nvm this is for existing card feeds |
s77rt
commented
Jul 2, 2025
Comment on lines
-229
to
-230
| SCREENS.WORKSPACE.COMPANY_CARDS_SETTINGS, | ||
| SCREENS.WORKSPACE.COMPANY_CARDS_SETTINGS_FEED_NAME, |
Member
Author
|
@fedirjh, @ikevin127 will review this |
Member
Author
|
Code-wise this is ready for review |
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroid-hybrid.mp4Android: mWeb Chromeandroid-mweb.mp4iOS: HybridAppios-hybrid.mp4iOS: mWeb Safariios-mweb.mp4MacOS: Chrome / Safariweb.movMacOS: Desktopdesktop.mov |
ikevin127
suggested changes
Jul 5, 2025
ikevin127
approved these changes
Jul 5, 2025
ikevin127
left a comment
Contributor
There was a problem hiding this comment.
🟢 LGTM (except for the comment above ☝️)
JS00001
approved these changes
Jul 7, 2025
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
luacmartins
reviewed
Jul 7, 2025
luacmartins
left a comment
Contributor
There was a problem hiding this comment.
Thanks for working on this!
59 tasks
Contributor
|
🚀 Deployed to staging by https://github.com/JS00001 in version: 9.1.78-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.1.78-4 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixed Issues
$ #64485
PROPOSAL:
Tests
MorethenSettingsStatement close datemenu item and click on itApplydisplays an error unless a valid date is selectedNote: The statement date won't be displayed on the menu item yet, this will be done later after BE changes (same thing for offline feedback)
Offline tests
Same as Tests
QA Steps
N/A
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
Screen.Recording.2025-07-05.at.9.47.04.PM.mov
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2025-07-05.at.9.40.53.PM.mov
MacOS: Desktop