Disable landscape view on phones

[luacmartins]

Details

We decided to disable landscape view on phones, but keep it on tablets.

Fixed Issues

$ #6568

Tests

1. Launch the app on a phone and verify that the app orientation doesn't change when you rotate the phone.
2. Launch the app on a tablet and verify that the app orientation changes when you rotate the tablet.

QA Steps

Steps above.

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web

Mobile Web

Desktop

iOS

ios.mov

ipad.mov

Android

android.mov

android-tablet.mov

[puneetlath]

@luacmartins everything looks good. Just one thing -- I was reading this Stack Overflow post and it sounds like there are also some extra large Android tablets out there that wouldn't get captured via res/values-sw600dp but would get captured by adding res/values-xlarge . Do you think we should add that as well?

[luacmartins]

I decided to leave that out because it only affected devices running on pre-Android 3.2 (released 2011). However, I guess it's simple enough to support those as well, so I'm including it here. Thanks for the input!

Just a note for my future self: We actually only need res/values-large (equivalent to values-sw600dp) since old android versions (< 3.2) use device size, i.e. small, medium, large, etc and not screen width, i.e. 600px, 720px, etc. Any devices larger than large or 600px would be caught in the values-large and values-sw600dp config.

[puneetlath]

Looks good to me! Can merge once tests finish.

[luacmartins]

Self-merging with approval!

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by @luacmartins in version: 1.1.18-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[mvtglobally]

@luacmartins @puneetlath @roryabraham
We were able to pass this PR on iPad, iPhone and Android phone. Do we need to verify Android Tablet as well?

[roryabraham]

@mvtglobally while that would be ideal, let's not block deploy on it. We can check it off but let's try to remember to test this at some point?

[luacmartins]

I agree with @roryabraham! I asked for some testing help in Slack.

[mvtglobally]

@luacmartins @roryabraham , We were able to get Android tablet user verify this PR today and its a Pass. Checking off

[luacmartins]

That's great @mvtglobally! Thank you so much!

[OSBotify]

🚀 Deployed to production by @Julesssss in version: 1.1.21-1 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅