Skip to content

Make bank account page scrollable#6648

Merged
chiragsalian merged 1 commit into
Expensify:mainfrom
parasharrajat:fix-workspace-pages
Dec 9, 2021
Merged

Make bank account page scrollable#6648
chiragsalian merged 1 commit into
Expensify:mainfrom
parasharrajat:fix-workspace-pages

Conversation

@parasharrajat

@parasharrajat parasharrajat commented Dec 8, 2021

Copy link
Copy Markdown
Member

Details

Part of #6557 got reverted in #6630 due to regression and thus I am fixing the remaining page for core issue #6496.

Fixed Issues

$ #6496

Tests | QA Steps

  1. Navigate to workspace settings
  2. Change the orientation to landscape
  3. Click on any of the options.
  4. Scroll the page.

Test #6620 on this PR as well.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

output_file.mp4

@chiragsalian chiragsalian left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chiragsalian chiragsalian merged commit de5d2ba into Expensify:main Dec 9, 2021
@OSBotify

OSBotify commented Dec 9, 2021

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @chiragsalian in version: 1.1.19-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @Julesssss in version: 1.1.21-1 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@parasharrajat parasharrajat deleted the fix-workspace-pages branch November 20, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants