[No QA]Sign cherry pick PRs as @OSBotify#6655
Conversation
Jag96
left a comment
Jag96
left a comment
There was a problem hiding this comment.
LGTM, can we also add manual cherry-picking to the test list just to confirm that all still works?
|
|
||
| - name: Create branch for new pull request | ||
| run: | | ||
| git config user.name ${{ github.actor }} |
There was a problem hiding this comment.
I think this will fail if we don't specify a user name. I think we need to hardcode it to OSBotify if we want all CP commits to be done + signed by OSBotify:
git config user.name 'OSBotify'
There was a problem hiding this comment.
|
|
|
Let's see if this works |
(cherry picked from commit 7068258)
|
Seems like it worked for a label CP:
|
|
Testing this with a manual CP of #6684 |
|
This seemed to work with a manual CP as well 🎉
|
|
Awesome!! Thank you for testing this! |
|
🚀 Deployed to staging by @roryabraham in version: 1.1.19-5 🚀
|
|
🚀 Deployed to production by @Julesssss in version: 1.1.21-1 🚀
|
4 participants
Details
This PR should sign our cherry pick commits and make all the cherry picks created by @OSBotify. This is the last step to forcing signatures for all commits.
Fixed Issues
$ GH_LINK
Tests
stagingbranch are signed and verified