Skip to content

growl width fix#6665

Merged
Julesssss merged 1 commit into
Expensify:mainfrom
thesahindia:thesahindia/ui/growlfix
Dec 10, 2021
Merged

growl width fix#6665
Julesssss merged 1 commit into
Expensify:mainfrom
thesahindia:thesahindia/ui/growlfix

Conversation

@thesahindia

@thesahindia thesahindia commented Dec 9, 2021

Copy link
Copy Markdown
Member

Details

Center the growl

Fixed Issues

$ #6634

Tests

QA Steps

  1. Navigate to profile settings
  2. Makes some changes in profile
  3. Press the save button

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screenshot 2021-12-09 at 5 47 10 PM

Mobile Web

Desktop

iOS

Android

@thesahindia thesahindia requested a review from a team as a code owner December 9, 2021 12:22
@MelvinBot MelvinBot requested review from Julesssss and parasharrajat and removed request for a team December 9, 2021 12:22

@parasharrajat parasharrajat left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

cc: @Julesssss

@Julesssss Julesssss left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested Android & Web. All good.

@Julesssss Julesssss merged commit c86847d into Expensify:main Dec 10, 2021
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @Julesssss in version: 1.1.19-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @Julesssss in version: 1.1.21-1 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants