Skip to content

[CP Stg] Fix iPad pro SignInPageLayout#6670

Merged
luacmartins merged 1 commit into
mainfrom
Rory-FixiPadProLayout
Dec 9, 2021
Merged

[CP Stg] Fix iPad pro SignInPageLayout#6670
luacmartins merged 1 commit into
mainfrom
Rory-FixiPadProLayout

Conversation

@roryabraham

Copy link
Copy Markdown
Contributor

Details

  1. Fixes the isMediumScreenWidth breakpoint when screen is resized (variable was misnamed)
  2. Removes an unused prop which was passed to SignInPageLayout component.

Fixed Issues

$ #6667

Tests / QA Steps.

  1. Open the sign-in page
  2. Make sure the image on the right side is displayed in full
  3. Rotate the device. Make sure the image still is displayed in full.
  4. Repeat the previous step.
  5. Try on as many different devices as you want. I was able to reproduce this issue on an iPad Pro after rotating from landscape to portrait mode, and saw that it was fixed by the changes in this PR.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

image

image

@roryabraham roryabraham requested a review from a team December 9, 2021 18:25
@roryabraham roryabraham self-assigned this Dec 9, 2021
@github-actions

github-actions Bot commented Dec 9, 2021

Copy link
Copy Markdown
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@MelvinBot MelvinBot requested review from luacmartins and removed request for a team December 9, 2021 18:26
@parasharrajat

Copy link
Copy Markdown
Member

First thought was that I broke it in recent refactor but no it was not me..

@luacmartins luacmartins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tests well!

@luacmartins luacmartins merged commit 7708155 into main Dec 9, 2021
@luacmartins luacmartins deleted the Rory-FixiPadProLayout branch December 9, 2021 19:29
OSBotify pushed a commit that referenced this pull request Dec 9, 2021
[CP Stg] Fix iPad pro SignInPageLayout

(cherry picked from commit 7708155)
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @luacmartins in version: 1.1.19-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @Julesssss in version: 1.1.21-1 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants