Adding support for chunked chats#6673
Merged
Merged
Conversation
danieldoglas
changed the title
Contributor
Author
|
Fixed JS Lints. |
yuwenmemon
reviewed
Dec 9, 2021
yuwenmemon
left a comment
yuwenmemon
left a comment
Contributor
There was a problem hiding this comment.
Looks good! But one question for ya
Contributor
Author
|
Fixed flag for comment edit. |
yuwenmemon
approved these changes
Dec 10, 2021
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
parasharrajat
left a comment
parasharrajat
left a comment
Member
There was a problem hiding this comment.
Do you think we should also clean the duplicate call at L149 in pusher.js.
38 tasks
Contributor
|
🚀 Deployed to staging by @yuwenmemon in version: 1.1.19-5 🚀
|
Contributor
|
🚀 Deployed to production by @Julesssss in version: 1.1.21-1 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Adding new events for pusher with chunked push notifications.
Fixed Issues
$ #3797
Tests
QA Steps
Tested On
Screenshots
Web/Desktop/iOS/Android
Screen.Recording.2021-12-09.at.15.48.03.mov