Skip to content

fix: Redirect after fresh workspace creation#6697

Merged
chiragsalian merged 3 commits into
Expensify:mainfrom
mananjadhav:fix/workspace-popup-menu
Dec 10, 2021
Merged

fix: Redirect after fresh workspace creation#6697
chiragsalian merged 3 commits into
Expensify:mainfrom
mananjadhav:fix/workspace-popup-menu

Conversation

@mananjadhav

@mananjadhav mananjadhav commented Dec 10, 2021

Copy link
Copy Markdown
Collaborator

Details

Fixed Issues

$ #5185

Tests

  1. Tested by creating a workspace and checking General settings page

QA Steps

  1. Open any existing Workspace
  2. Open the Three Dots menu at the top and create a new workspace
  3. Click on General settings, it should show the new workspace details.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

web-workspace-redirection.mov

Mobile Web

mweb-workspace-redirection.mov

Desktop

desktop-workspace-redirection.mov

iOS

ios-workspace-redirection.mov

Android

android-workspace-redirection.mov

@mananjadhav mananjadhav requested a review from a team as a code owner December 10, 2021 18:20
@MelvinBot MelvinBot requested review from chiragsalian and removed request for a team December 10, 2021 18:20

@chiragsalian chiragsalian left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM and when i tested it worked well too. Left a minor comment.

Comment thread src/pages/workspace/WorkspaceInitialPage.js Outdated
Comment thread src/pages/workspace/WorkspaceInitialPage.js Outdated

@chiragsalian chiragsalian left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks manan 👍

@chiragsalian chiragsalian merged commit e9ca9e6 into Expensify:main Dec 10, 2021
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @chiragsalian in version: 1.1.19-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @Julesssss in version: 1.1.21-1 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants