Fix currency selector in IOU#6755
Merged
Merged
Conversation
Luke9389
previously approved these changes
Dec 14, 2021
Contributor
|
Just one NAB. Feel free to self-merge if you don't want to change the code. |
Julesssss
requested changes
Dec 16, 2021
Julesssss
left a comment
Julesssss
left a comment
Contributor
There was a problem hiding this comment.
that’s not quite right. Each time the IOUModal is opened it should reset to the IP currency. We allow users to change it only for the current IOU payment.
MonilBhavsar
changed the title
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
31 tasks
Contributor
|
🚀 Deployed to staging by @Julesssss in version: 1.1.21-2 🚀
|
Contributor
|
🚀 Deployed to production by @sketchydroide in version: 1.1.22-0 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
iouOnyx data was getting overwritten with default selected language of user.Stops overwriting it if user has already selected currency for IOU
Fixed Issues
$ #6749
Tests / QA
Tested On
Screenshots
Web
Screen.Recording.2021-12-14.at.6.53.49.PM.mov
Mobile Web
Desktop
iOS
Android